|
 |
1bdc94 |
From 5969300e27c6a28f1bc345b84cd9e690780e29f8 Mon Sep 17 00:00:00 2001
|
|
|
1bdc94 |
From: Serhii Popovych <spopovyc@redhat.com>
|
|
|
1bdc94 |
Date: Mon, 9 Jul 2018 11:31:18 +0200
|
|
|
1bdc94 |
Subject: [PATCH 28/89] Revert "usb: release the created buses"
|
|
|
1bdc94 |
MIME-Version: 1.0
|
|
|
1bdc94 |
Content-Type: text/plain; charset=UTF-8
|
|
|
1bdc94 |
Content-Transfer-Encoding: 8bit
|
|
|
1bdc94 |
|
|
|
1bdc94 |
RH-Author: Serhii Popovych <spopovyc@redhat.com>
|
|
|
1bdc94 |
Message-id: <1531135878-18813-4-git-send-email-spopovyc@redhat.com>
|
|
|
1bdc94 |
Patchwork-id: 81266
|
|
|
1bdc94 |
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH v2 3/3] Revert "usb: release the created buses"
|
|
|
1bdc94 |
Bugzilla: 1556678
|
|
|
1bdc94 |
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
RH-Acked-by: David Gibson <dgibson@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
|
|
|
1bdc94 |
The USB device don't hold the bus. There is no ASAN related reports
|
|
|
1bdc94 |
anymore.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
This reverts commit cd7bc87868d534f95e928cad98e2a52df7695771.
|
|
|
1bdc94 |
|
|
|
1bdc94 |
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
1bdc94 |
Message-id: 20180613172815.32738-3-marcandre.lureau@redhat.com
|
|
|
1bdc94 |
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
1bdc94 |
(cherry picked from commit 9b5c2fd53feb574036747d0284fd7f73dfedc89c)
|
|
|
1bdc94 |
Signed-off-by: Serhii Popovych <spopovyc@redhat.com>
|
|
|
1bdc94 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
1bdc94 |
---
|
|
|
1bdc94 |
hw/usb/dev-storage.c | 16 ----------------
|
|
|
1bdc94 |
hw/usb/dev-uas.c | 2 --
|
|
|
1bdc94 |
2 files changed, 18 deletions(-)
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
|
|
|
1bdc94 |
index 68e2062..9fb00a9 100644
|
|
|
1bdc94 |
--- a/hw/usb/dev-storage.c
|
|
|
1bdc94 |
+++ b/hw/usb/dev-storage.c
|
|
|
1bdc94 |
@@ -589,13 +589,6 @@ static const struct SCSIBusInfo usb_msd_scsi_info_bot = {
|
|
|
1bdc94 |
.load_request = usb_msd_load_request,
|
|
|
1bdc94 |
};
|
|
|
1bdc94 |
|
|
|
1bdc94 |
-static void usb_msd_unrealize_storage(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
-{
|
|
|
1bdc94 |
- MSDState *s = USB_STORAGE_DEV(dev);
|
|
|
1bdc94 |
-
|
|
|
1bdc94 |
- object_unref(OBJECT(&s->bus));
|
|
|
1bdc94 |
-}
|
|
|
1bdc94 |
-
|
|
|
1bdc94 |
static void usb_msd_storage_realize(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
{
|
|
|
1bdc94 |
MSDState *s = USB_STORAGE_DEV(dev);
|
|
|
1bdc94 |
@@ -645,13 +638,6 @@ static void usb_msd_storage_realize(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
s->scsi_dev = scsi_dev;
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
|
|
|
1bdc94 |
-static void usb_msd_bot_unrealize(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
-{
|
|
|
1bdc94 |
- MSDState *s = USB_STORAGE_DEV(dev);
|
|
|
1bdc94 |
-
|
|
|
1bdc94 |
- object_unref(OBJECT(&s->bus));
|
|
|
1bdc94 |
-}
|
|
|
1bdc94 |
-
|
|
|
1bdc94 |
static void usb_msd_bot_realize(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
{
|
|
|
1bdc94 |
MSDState *s = USB_STORAGE_DEV(dev);
|
|
|
1bdc94 |
@@ -716,7 +702,6 @@ static void usb_msd_class_storage_initfn(ObjectClass *klass, void *data)
|
|
|
1bdc94 |
USBDeviceClass *uc = USB_DEVICE_CLASS(klass);
|
|
|
1bdc94 |
|
|
|
1bdc94 |
uc->realize = usb_msd_storage_realize;
|
|
|
1bdc94 |
- uc->unrealize = usb_msd_unrealize_storage;
|
|
|
1bdc94 |
dc->props = msd_properties;
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
|
|
|
1bdc94 |
@@ -779,7 +764,6 @@ static void usb_msd_class_bot_initfn(ObjectClass *klass, void *data)
|
|
|
1bdc94 |
USBDeviceClass *uc = USB_DEVICE_CLASS(klass);
|
|
|
1bdc94 |
|
|
|
1bdc94 |
uc->realize = usb_msd_bot_realize;
|
|
|
1bdc94 |
- uc->unrealize = usb_msd_bot_unrealize;
|
|
|
1bdc94 |
uc->attached_settable = true;
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
|
|
|
1bdc94 |
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
|
|
|
1bdc94 |
index c218b53..eaf515d 100644
|
|
|
1bdc94 |
--- a/hw/usb/dev-uas.c
|
|
|
1bdc94 |
+++ b/hw/usb/dev-uas.c
|
|
|
1bdc94 |
@@ -896,8 +896,6 @@ static void usb_uas_unrealize(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
UASDevice *uas = USB_UAS(dev);
|
|
|
1bdc94 |
|
|
|
1bdc94 |
qemu_bh_delete(uas->status_bh);
|
|
|
1bdc94 |
-
|
|
|
1bdc94 |
- object_unref(OBJECT(&uas->bus));
|
|
|
1bdc94 |
}
|
|
|
1bdc94 |
|
|
|
1bdc94 |
static void usb_uas_realize(USBDevice *dev, Error **errp)
|
|
|
1bdc94 |
--
|
|
|
1bdc94 |
1.8.3.1
|
|
|
1bdc94 |
|