|
 |
9bac43 |
From d6db718295b53f11017aaba1dd8a0507c77d7a1e Mon Sep 17 00:00:00 2001
|
|
|
9bac43 |
From: Fam Zheng <famz@redhat.com>
|
|
|
9bac43 |
Date: Thu, 19 May 2016 06:39:44 +0200
|
|
|
9bac43 |
Subject: qmp: Report __com.redhat_drive_add error to monitor
|
|
|
9bac43 |
|
|
|
9bac43 |
RH-Author: Fam Zheng <famz@redhat.com>
|
|
|
9bac43 |
Message-id: <1463639984-1165-1-git-send-email-famz@redhat.com>
|
|
|
9bac43 |
Patchwork-id: 70412
|
|
|
9bac43 |
O-Subject: [RHEL-7.3 qemu-kvm-rhev PATCH] qmp: Report drive_add error to monitor
|
|
|
9bac43 |
Bugzilla: 1337100
|
|
|
9bac43 |
RH-Acked-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9bac43 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9bac43 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9bac43 |
|
|
|
9bac43 |
In other error cases of this function we use error_setg, the same should
|
|
|
9bac43 |
be done with drive_new() failures. This is useful for libvirt to
|
|
|
9bac43 |
correctly detect the failure and report proper error message when a
|
|
|
9bac43 |
specified image is not available.
|
|
|
9bac43 |
|
|
|
9bac43 |
This bug cames from the forward porting from qemu-kvm, at which point we
|
|
|
9bac43 |
overlooked the difference in QMP reporting between qerror_report and
|
|
|
9bac43 |
error_report.
|
|
|
9bac43 |
|
|
|
9bac43 |
Signed-off-by: Fam Zheng <famz@redhat.com>
|
|
|
9bac43 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9bac43 |
(cherry picked from commit c5736179da1a310ddb384836fc025b2582f9e90d)
|
|
|
9bac43 |
|
|
|
9bac43 |
Rebase notes (2.8.0):
|
|
|
9bac43 |
- Changed patch name
|
|
|
9bac43 |
|
|
|
9bac43 |
(cherry picked from commit 8a1f601ec13449e736c05789c4f5ae52ab34f3a7)
|
|
|
9bac43 |
---
|
|
|
9bac43 |
device-hotplug.c | 3 +--
|
|
|
9bac43 |
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
9bac43 |
|
|
|
9bac43 |
diff --git a/device-hotplug.c b/device-hotplug.c
|
|
|
9bac43 |
index 218f7b3..29f9a64 100644
|
|
|
9bac43 |
--- a/device-hotplug.c
|
|
|
9bac43 |
+++ b/device-hotplug.c
|
|
|
9bac43 |
@@ -145,8 +145,7 @@ void qmp_simple_drive_add(QDict *qdict, QObject **ret_data, Error **errp)
|
|
|
9bac43 |
mc = MACHINE_GET_CLASS(current_machine);
|
|
|
9bac43 |
dinfo = drive_new(opts, mc->block_default_type);
|
|
|
9bac43 |
if (!dinfo) {
|
|
|
9bac43 |
- error_report(QERR_DEVICE_INIT_FAILED,
|
|
|
9bac43 |
- qemu_opts_id(opts));
|
|
|
9bac43 |
+ error_setg(errp, QERR_DEVICE_INIT_FAILED, qemu_opts_id(opts));
|
|
|
9bac43 |
qemu_opts_del(opts);
|
|
|
9bac43 |
return;
|
|
|
9bac43 |
}
|
|
|
9bac43 |
--
|
|
|
9bac43 |
1.8.3.1
|
|
|
9bac43 |
|