|
 |
bca232 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
bca232 |
From: "Miss Islington (bot)"
|
|
|
bca232 |
<31488909+miss-islington@users.noreply.github.com>
|
|
|
bca232 |
Date: Wed, 15 Jul 2020 05:36:36 -0700
|
|
|
bca232 |
Subject: [PATCH] 00351: Avoid infinite loop in the tarfile module
|
|
|
bca232 |
|
|
|
bca232 |
Avoid infinite loop when reading specially crafted TAR files using the tarfile module
|
|
|
bca232 |
(CVE-2019-20907).
|
|
|
bca232 |
Fixed upstream: https://bugs.python.org/issue39017
|
|
|
bca232 |
---
|
|
|
bca232 |
Lib/tarfile.py | 2 ++
|
|
|
bca232 |
Lib/test/recursion.tar | Bin 0 -> 516 bytes
|
|
|
bca232 |
Lib/test/test_tarfile.py | 7 +++++++
|
|
|
bca232 |
.../2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst | 1 +
|
|
|
bca232 |
4 files changed, 10 insertions(+)
|
|
|
bca232 |
create mode 100644 Lib/test/recursion.tar
|
|
|
bca232 |
create mode 100644 Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst
|
|
|
bca232 |
|
|
|
bca232 |
diff --git a/Lib/tarfile.py b/Lib/tarfile.py
|
|
|
bca232 |
index 62d22150f5..2ea47978ff 100755
|
|
|
bca232 |
--- a/Lib/tarfile.py
|
|
|
bca232 |
+++ b/Lib/tarfile.py
|
|
|
bca232 |
@@ -1231,6 +1231,8 @@ class TarInfo(object):
|
|
|
bca232 |
|
|
|
bca232 |
length, keyword = match.groups()
|
|
|
bca232 |
length = int(length)
|
|
|
bca232 |
+ if length == 0:
|
|
|
bca232 |
+ raise InvalidHeaderError("invalid header")
|
|
|
bca232 |
value = buf[match.end(2) + 1:match.start(1) + length - 1]
|
|
|
bca232 |
|
|
|
bca232 |
# Normally, we could just use "utf-8" as the encoding and "strict"
|
|
|
bca232 |
diff --git a/Lib/test/recursion.tar b/Lib/test/recursion.tar
|
|
|
bca232 |
new file mode 100644
|
|
|
bca232 |
index 0000000000000000000000000000000000000000..b8237251964983f54ed1966297e887636cd0c5f4
|
|
|
bca232 |
GIT binary patch
|
|
|
bca232 |
literal 516
|
|
|
bca232 |
zcmYdFPRz+kEn=W0Fn}74P8%Xw3X=l~85kIuo0>8xq$A1Gm}!7)KUsFc41m#O8A5+e
|
|
|
bca232 |
I1_}|j06>QaCIA2c
|
|
|
bca232 |
|
|
|
bca232 |
literal 0
|
|
|
bca232 |
HcmV?d00001
|
|
|
bca232 |
|
|
|
bca232 |
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
|
|
|
bca232 |
index 4cd7d5370f..573be812ea 100644
|
|
|
bca232 |
--- a/Lib/test/test_tarfile.py
|
|
|
bca232 |
+++ b/Lib/test/test_tarfile.py
|
|
|
bca232 |
@@ -395,6 +395,13 @@ class CommonReadTest(ReadTest):
|
|
|
bca232 |
with self.assertRaisesRegex(tarfile.ReadError, "unexpected end of data"):
|
|
|
bca232 |
tar.extractfile(t).read()
|
|
|
bca232 |
|
|
|
bca232 |
+ def test_length_zero_header(self):
|
|
|
bca232 |
+ # bpo-39017 (CVE-2019-20907): reading a zero-length header should fail
|
|
|
bca232 |
+ # with an exception
|
|
|
bca232 |
+ with self.assertRaisesRegex(tarfile.ReadError, "file could not be opened successfully"):
|
|
|
bca232 |
+ with tarfile.open(support.findfile('recursion.tar')) as tar:
|
|
|
bca232 |
+ pass
|
|
|
bca232 |
+
|
|
|
bca232 |
class MiscReadTestBase(CommonReadTest):
|
|
|
bca232 |
def requires_name_attribute(self):
|
|
|
bca232 |
pass
|
|
|
bca232 |
diff --git a/Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst b/Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst
|
|
|
bca232 |
new file mode 100644
|
|
|
bca232 |
index 0000000000..ad26676f8b
|
|
|
bca232 |
--- /dev/null
|
|
|
bca232 |
+++ b/Misc/NEWS.d/next/Library/2020-07-12-22-16-58.bpo-39017.x3Cg-9.rst
|
|
|
bca232 |
@@ -0,0 +1 @@
|
|
|
bca232 |
+Avoid infinite loop when reading specially crafted TAR files using the tarfile module (CVE-2019-20907).
|