Blame SOURCES/00354-cve-2020-26116-http-request-method-crlf-injection-in-httplib.patch

ffce65
diff --git a/Lib/httplib.py b/Lib/httplib.py
ffce65
index fcc4152..a636774 100644
ffce65
--- a/Lib/httplib.py
ffce65
+++ b/Lib/httplib.py
ffce65
@@ -257,6 +257,10 @@ _contains_disallowed_url_pchar_re = re.compile('[\x00-\x20\x7f-\xff]')
ffce65
 #  _is_allowed_url_pchars_re = re.compile(r"^[/!$&'()*+,;=:@%a-zA-Z0-9._~-]+$")
ffce65
 # We are more lenient for assumed real world compatibility purposes.
ffce65
 
ffce65
+# These characters are not allowed within HTTP method names
ffce65
+# to prevent http header injection.
ffce65
+_contains_disallowed_method_pchar_re = re.compile('[\x00-\x1f]')
ffce65
+
ffce65
 # We always set the Content-Length header for these methods because some
ffce65
 # servers will otherwise respond with a 411
ffce65
 _METHODS_EXPECTING_BODY = {'PATCH', 'POST', 'PUT'}
ffce65
@@ -935,6 +939,8 @@ class HTTPConnection:
ffce65
         else:
ffce65
             raise CannotSendRequest()
ffce65
 
ffce65
+        self._validate_method(method)
ffce65
+
ffce65
         # Save the method for use later in the response phase
ffce65
         self._method = method
ffce65
 
ffce65
@@ -1020,6 +1026,16 @@ class HTTPConnection:
ffce65
         # On Python 2, request is already encoded (default)
ffce65
         return request
ffce65
 
ffce65
+    def _validate_method(self, method):
ffce65
+        """Validate a method name for putrequest."""
ffce65
+        # prevent http header injection
ffce65
+        match = _contains_disallowed_method_pchar_re.search(method)
ffce65
+        if match:
ffce65
+            raise ValueError(
ffce65
+                    "method can't contain control characters. %r "
ffce65
+                    "(found at least %r)"
ffce65
+                    % (method, match.group()))
ffce65
+
ffce65
     def _validate_path(self, url):
ffce65
         """Validate a url for putrequest."""
ffce65
         # Prevent CVE-2019-9740.
ffce65
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
ffce65
index d8a57f7..96a61dd 100644
ffce65
--- a/Lib/test/test_httplib.py
ffce65
+++ b/Lib/test/test_httplib.py
ffce65
@@ -385,6 +385,29 @@ class HeaderTests(TestCase):
ffce65
                 conn.putheader(name, value)
ffce65
 
ffce65
 
ffce65
+class HttpMethodTests(TestCase):
ffce65
+    def test_invalid_method_names(self):
ffce65
+        methods = (
ffce65
+            'GET\r',
ffce65
+            'POST\n',
ffce65
+            'PUT\n\r',
ffce65
+            'POST\nValue',
ffce65
+            'POST\nHOST:abc',
ffce65
+            'GET\nrHost:abc\n',
ffce65
+            'POST\rRemainder:\r',
ffce65
+            'GET\rHOST:\n',
ffce65
+            '\nPUT'
ffce65
+        )
ffce65
+
ffce65
+        for method in methods:
ffce65
+            with self.assertRaisesRegexp(
ffce65
+                    ValueError, "method can't contain control characters"):
ffce65
+                conn = httplib.HTTPConnection('example.com')
ffce65
+                conn.sock = FakeSocket(None)
ffce65
+                conn.request(method=method, url="/")
ffce65
+
ffce65
+
ffce65
+
ffce65
 class BasicTest(TestCase):
ffce65
     def test_status_lines(self):
ffce65
         # Test HTTP status lines
ffce65
@@ -1009,9 +1032,9 @@ class TunnelTests(TestCase):
ffce65
 
ffce65
 @test_support.reap_threads
ffce65
 def test_main(verbose=None):
ffce65
-    test_support.run_unittest(HeaderTests, OfflineTest, BasicTest, TimeoutTest,
ffce65
-                              HTTPTest, HTTPSTest, SourceAddressTest,
ffce65
-                              TunnelTests)
ffce65
+    test_support.run_unittest(HeaderTests, OfflineTest, HttpMethodTests,
ffce65
+                              BasicTest, TimeoutTest, HTTPTest, HTTPSTest,
ffce65
+                              SourceAddressTest, TunnelTests)
ffce65
 
ffce65
 if __name__ == '__main__':
ffce65
     test_main()