# Tests need an internet connection, so they are disabled by default

%bcond_with online_tests

%if 0%{?fedora}

%global _with_python3 1

%else

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")}

%endif

Name:           python-requests

Version:        2.6.0

Release:        10%{?dist}

Summary:        HTTP library, written in Python, for human beings

License:        ASL 2.0

URL:            http://pypi.python.org/pypi/requests

Source0:        http://pypi.python.org/packages/source/r/requests/requests-%{version}.tar.gz

# Explicitly use the system certificates in ca-certificates.

# https://bugzilla.redhat.com/show_bug.cgi?id=904614

Patch0:         python-requests-system-cert-bundle.patch

# Remove an unnecessary reference to a bundled compat lib in urllib3

Patch1:         python-requests-remove-nested-bundling-dep.patch

# Modify tests to run in pytest so that we can run backported parametrized

# tests (Patch4: fix-default-port-handling.patch).

# We cannot launch the tests during build as they require internet, but QE

# launches them later.

# Minimal version of this upstream change:

#   https://github.com/psf/requests/commit/6c2942b19865106a3ac65b3bfc1fc93aae2d346c

Patch2:         modify-tests-to-run-in-pytest.patch

# Fix for CVE-2018-18074

# Resolved upstream: https://github.com/requests/requests/pull/4718

Patch3:         fix-CVE-2018-18074.patch

# Fix handling of default ports in auth stripping

# Resolved upstream: https://github.com/psf/requests/pull/4851

Patch4:         fix-default-port-handling.patch

# Fix a leaking test that was making another test (test_auth_is_stripped_on_redirect_off_host) fail

# Resolved upstream: https://github.com/psf/requests/commit/9b63f9cd37d19f2d4bbce42caec112ad0606d8dd

Patch5:         fix-leaking-test.patch

# The upstream requests library bundles urllib3 and chardet, and then

# manipulates the module namespace in order to alias the packages to

# the system ones if a distribution unbundles them. This however can lead

# to side effects, such as creating different instances of the modules

# in memory where changes can happen to a module but not reflected to another,

# leading to undefined behavior.

# This patch changes all the import statements for urllib3 and chardet to import

# from the global namespace, thus avoiding the instance duplication.

# Partial backport from https://github.com/psf/requests/pull/4067

# Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1750839

Patch6: import-urllib3-and-chardet-from-the-global-namespace.patch

# While the requests.packages aliasing has been removed since

# it caused various issues while it's also an undocumented API,

# much code in the wild still relies on it. This fix ensures

# that while the naming scheme is there for backwards compatibility,

# the submodules contained in the requests.packages namespace

# are properly aliased to the system installed modules.

# Inspired by https://github.com/psf/requests/blob/v2.18.0/requests/packages.py

# Resolves: rhbz#1785607, rhbz#1785666, rhbz#1785696, rhbz#1787679

Patch7: fix-requests.packages-aliasing.patch

BuildArch:      noarch

BuildRequires:  python2-devel

BuildRequires:  python-chardet >= 2.2.1-1

BuildRequires:  python-urllib3 >= 1.10.2-1

%if %{with online_tests}

BuildRequires:  pytest

%endif

Requires:       ca-certificates

Requires:       python-chardet >= 2.2.1-1

Requires:       python-urllib3 >= 1.10.2-1

%if 0%{?rhel} && 0%{?rhel} <= 6

BuildRequires:  python-ordereddict >= 1.1

Requires:       python-ordereddict >= 1.1

%endif

Provides:       python2-requests = %{version}-%{release}

Obsoletes:      python2-requests < %{version}-%{release}

%description

Most existing Python modules for sending HTTP requests are extremely verbose and 

cumbersome. Python’s built-in urllib2 module provides most of the HTTP 

capabilities you should need, but the API is thoroughly broken. This library is 

designed to make HTTP requests easy for developers.

%if 0%{?_with_python3}

%package -n python3-requests

Summary: HTTP library, written in Python, for human beings

BuildRequires:  python3-devel

BuildRequires:  python3-chardet

BuildRequires:  python3-urllib3

%if %{with online_tests}

BuildRequires:  python3-pytest

%endif

Requires:       python3-chardet

Requires:       python3-urllib3

%description -n python3-requests

Most existing Python modules for sending HTTP requests are extremely verbose and

cumbersome. Python’s built-in urllib2 module provides most of the HTTP

capabilities you should need, but the API is thoroughly broken. This library is

designed to make HTTP requests easy for developers.

%endif

%prep

%setup -q -n requests-%{version}

%patch0 -p1

%patch1 -p1

%patch2 -p1

%patch3 -p1

%patch4 -p1

%patch5 -p1

%patch6 -p1

%patch7 -p1

# Unbundle the certificate bundle from mozilla.

rm -rf requests/cacert.pem

%if 0%{?_with_python3}

rm -rf %{py3dir}

cp -a . %{py3dir}

%endif # with_python3

%build

%if 0%{?_with_python3}

pushd %{py3dir}

%{__python3} setup.py build

# Unbundle chardet and urllib3.

rm -rf build/lib/requests/packages/chardet

rm -rf build/lib/requests/packages/urllib3

popd

%endif

%py2_build

# Unbundle chardet and urllib3.

rm -rf build/lib/requests/packages/chardet

rm -rf build/lib/requests/packages/urllib3

%install

rm -rf $RPM_BUILD_ROOT

%if 0%{?_with_python3}

pushd %{py3dir}

%{__python3} setup.py install --skip-build --root $RPM_BUILD_ROOT

popd

%endif

%py2_install

%if %{with online_tests}

# The tests succeed if run locally, but fail in koji.

# They require an active network connection to query httpbin.org

%check

%{__python} -m pytest test_requests.py

%if 0%{?_with_python3}

pushd %{py3dir}

%{__python3} -m pytest test_requests.py

popd

%endif

%endif #with online_tests

%files

%defattr(-,root,root,-)

%doc NOTICE LICENSE README.rst HISTORY.rst

%{python2_sitelib}/*.egg-info

%dir %{python2_sitelib}/requests

%{python2_sitelib}/requests/*

%if 0%{?_with_python3}

%files -n python3-requests

%{python3_sitelib}/*.egg-info

%{python3_sitelib}/requests/

%endif

%changelog

* Tue Mar 10 2020 Charalampos Stratakis <cstratak@redhat.com> - 2.6.0-10

- Fix test_urllib3_retries by having it import urllib3 from the global namespace

Resolves: rhbz#1771567

* Wed Feb 19 2020 Charalampos Stratakis <cstratak@redhat.com> - 2.6.0-9

- Bring back the requests.packages aliasing of its submodules

Resolves: rhbz#1785607, rhbz#1785666, rhbz#1785696, rhbz#1787679

* Thu Oct 24 2019 Charalampos Stratakis <cstratak@redhat.com> - 2.6.0-8

- Import urllib3 and chardet from the global namespace

Resolves: rhbz#1750839

* Thu Oct 03 2019 Tomas Orsava <torsava@redhat.com> - 2.6.0-7

- Modify tests to run in pytest

- Add a bcond online_tests to enable the tests

Related: rhbz#1745417

* Tue Aug 27 2019 Charalampos Stratakis <cstratak@redhat.com> - 2.6.0-6

- Fix handling of default ports in auth stripping

Resolves: rhbz#1745417

* Mon Nov 26 2018 Charalampos Stratakis <cstratak@redhat.com> - 2.6.0-5

- Fix CVE-2018-18074

Resolves: rhbz#1647368

* Wed Jun 03 2015 Matej Stuchlik <mstuchli@redhat.com> - 2.6.0-1

- Update to 2.6.0

Resolves: rhbz#1214365

* Mon Jan 12 2015 Endi S. Dewata <edewata@redhat.com> - 1.1.0-9

- Merged headers with different cases.

* Mon Jan 27 2014 Endi S. Dewata <edewata@redhat.com> - 1.1.0-8

- Removed authentication header on redirect.

* Fri Dec 27 2013 Daniel Mach <dmach@redhat.com> - 1.1.0-7

- Mass rebuild 2013-12-27

* Fri Oct  4 2013 Endi S. Dewata <edewata@redhat.com> - 1.1.0-6

- Removed bundled packages.

* Tue Jun 18 2013 Endi S. Dewata <edewata@redhat.com> - 1.1.0-5

- Fixed bogus date in changelog entry.

* Tue Jun 11 2013 Ralph Bean <rbean@redhat.com> - 1.1.0-4

- Correct a rhel conditional on python-ordereddict

* Thu Feb 28 2013 Ralph Bean <rbean@redhat.com> - 1.1.0-3

- Unbundled python-urllib3.  Using system python-urllib3 now.

- Conditionally include python-ordereddict for el6.

* Wed Feb 27 2013 Ralph Bean <rbean@redhat.com> - 1.1.0-2

- Unbundled python-charade/chardet.  Using system python-chardet now.

- Removed deprecated comments and actions against oauthlib unbundling.

  Those are no longer necessary in 1.1.0.

- Added links to bz tickets over Patch declarations.

* Tue Feb 26 2013 Ralph Bean <rbean@redhat.com> - 1.1.0-1

- Latest upstream.

- Relicense to ASL 2.0 with upstream.

- Removed cookie handling patch (fixed in upstream tarball).

- Updated cert unbundling patch to match upstream.

- Added check section, but left it commented out for koji.

* Fri Feb  8 2013 Toshio Kuratomi <toshio@fedoraproject.org> - 0.14.1-4

- Let brp_python_bytecompile run again, take care of the non-python{2,3} modules

  by removing them from the python{,3}-requests package that they did not belong

  in.

- Use the certificates in the ca-certificates package instead of the bundled one

  + https://bugzilla.redhat.com/show_bug.cgi?id=904614

- Fix a problem with cookie handling

  + https://bugzilla.redhat.com/show_bug.cgi?id=906924

* Mon Oct 22 2012 Arun S A G <sagarun@gmail.com>  0.14.1-1

- Updated to latest upstream release

* Sun Jun 10 2012 Arun S A G <sagarun@gmail.com> 0.13.1-1

- Updated to latest upstream release 0.13.1

- Use system provided ca-certificates

- No more async requests use grrequests https://github.com/kennethreitz/grequests

- Remove gevent as it is no longer required by requests

* Sun Apr 01 2012 Arun S A G <sagarun@gmail.com> 0.11.1-1

- Updated to upstream release 0.11.1

* Thu Mar 29 2012 Arun S A G <sagarun@gmail.com> 0.10.6-3

- Support building package for EL6

* Tue Mar 27 2012 Rex Dieter <rdieter@fedoraproject.org> 0.10.6-2

- +python3-requests pkg

* Sat Mar 3 2012 Arun SAG <sagarun@gmail.com> - 0.10.6-1

- Updated to new upstream version

* Sat Jan 21 2012 Arun SAG <sagarun@gmail.com> - 0.9.3-1

- Updated to new upstream version 0.9.3

- Include python-gevent as a dependency for requests.async

- Clean up shebangs in requests/setup.py,test_requests.py and test_requests_ext.py

* Sat Jan 14 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.8.2-2

- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild

* Sun Nov 27 2011 Arun SAG <sagarun@gmail.com> - 0.8.2-1

- New upstream version

- keep alive support

- complete removal of cookiejar and urllib2

* Thu Nov 10 2011 Arun SAG <sagarun@gmail.com> - 0.7.6-1

- Updated to new upstream release 0.7.6

* Thu Oct 20 2011 Arun SAG <sagarun@gmail.com> - 0.6.6-1

- Updated to version 0.6.6

* Fri Aug 26 2011 Arun SAG <sagarun@gmail.com> - 0.6.1-1

- Updated to version 0.6.1

* Sat Aug 20 2011 Arun SAG <sagarun@gmail.com> - 0.6.0-1

- Updated to latest version 0.6.0

* Mon Aug 15 2011 Arun SAG <sagarun@gmail.com> - 0.5.1-2

- Remove OPT_FLAGS from build section since it is a noarch package

- Fix use of mixed tabs and space

- Remove extra space around the word cumbersome in description

* Sun Aug 14 2011 Arun SAG <sagarun@gmail.com> - 0.5.1-1

- Initial package