|
 |
dbd2ef |
diff --git a/requests/sessions.py b/requests/sessions.py
|
|
|
dbd2ef |
index a0a23ee..9a51f33 100644
|
|
|
dbd2ef |
--- a/requests/sessions.py
|
|
|
dbd2ef |
+++ b/requests/sessions.py
|
|
|
dbd2ef |
@@ -18,7 +18,7 @@ from .cookies import (
|
|
|
dbd2ef |
cookiejar_from_dict, extract_cookies_to_jar, RequestsCookieJar, merge_cookies)
|
|
|
dbd2ef |
from .models import Request, PreparedRequest, DEFAULT_REDIRECT_LIMIT
|
|
|
dbd2ef |
from .hooks import default_hooks, dispatch_hook
|
|
|
dbd2ef |
-from .utils import to_key_val_list, default_headers, to_native_string
|
|
|
dbd2ef |
+from .utils import to_key_val_list, default_headers, to_native_string, DEFAULT_PORTS
|
|
|
dbd2ef |
from .exceptions import (
|
|
|
dbd2ef |
TooManyRedirects, InvalidSchema, ChunkedEncodingError, ContentDecodingError)
|
|
|
dbd2ef |
from .packages.urllib3._collections import RecentlyUsedContainer
|
|
|
dbd2ef |
@@ -103,8 +103,17 @@ class SessionRedirectMixin(object):
|
|
|
dbd2ef |
if (old_parsed.scheme == 'http' and old_parsed.port in (80, None)
|
|
|
dbd2ef |
and new_parsed.scheme == 'https' and new_parsed.port in (443, None)):
|
|
|
dbd2ef |
return False
|
|
|
dbd2ef |
+
|
|
|
dbd2ef |
+ # Handle default port usage corresponding to scheme.
|
|
|
dbd2ef |
+ changed_port = old_parsed.port != new_parsed.port
|
|
|
dbd2ef |
+ changed_scheme = old_parsed.scheme != new_parsed.scheme
|
|
|
dbd2ef |
+ default_port = (DEFAULT_PORTS.get(old_parsed.scheme, None), None)
|
|
|
dbd2ef |
+ if (not changed_scheme and old_parsed.port in default_port
|
|
|
dbd2ef |
+ and new_parsed.port in default_port):
|
|
|
dbd2ef |
+ return False
|
|
|
dbd2ef |
+
|
|
|
dbd2ef |
# Standard case: root URI must match
|
|
|
dbd2ef |
- return old_parsed.port != new_parsed.port or old_parsed.scheme != new_parsed.scheme
|
|
|
dbd2ef |
+ return changed_port or changed_scheme
|
|
|
dbd2ef |
|
|
|
dbd2ef |
def resolve_redirects(self, resp, req, stream=False, timeout=None,
|
|
|
dbd2ef |
verify=True, cert=None, proxies=None):
|
|
|
dbd2ef |
diff --git a/requests/utils.py b/requests/utils.py
|
|
|
dbd2ef |
index 8fba62d..14c94bd 100644
|
|
|
dbd2ef |
--- a/requests/utils.py
|
|
|
dbd2ef |
+++ b/requests/utils.py
|
|
|
dbd2ef |
@@ -37,6 +37,8 @@ NETRC_FILES = ('.netrc', '_netrc')
|
|
|
dbd2ef |
|
|
|
dbd2ef |
DEFAULT_CA_BUNDLE_PATH = certs.where()
|
|
|
dbd2ef |
|
|
|
dbd2ef |
+DEFAULT_PORTS = {'http': 80, 'https': 443}
|
|
|
dbd2ef |
+
|
|
|
dbd2ef |
|
|
|
dbd2ef |
def dict_to_sequence(d):
|
|
|
dbd2ef |
"""Returns an internal sequence dictionary update."""
|
|
|
dbd2ef |
diff --git a/test_requests.py b/test_requests.py
|
|
|
dbd2ef |
index e19b436..b76d2a4 100755
|
|
|
dbd2ef |
--- a/test_requests.py
|
|
|
dbd2ef |
+++ b/test_requests.py
|
|
|
dbd2ef |
@@ -1012,6 +1012,17 @@ class RequestsTestCase(unittest.TestCase):
|
|
|
dbd2ef |
s = requests.Session()
|
|
|
dbd2ef |
assert s.should_strip_auth('http://example.com:1234/foo', 'https://example.com:4321/bar')
|
|
|
dbd2ef |
|
|
|
dbd2ef |
+ @pytest.mark.parametrize(
|
|
|
dbd2ef |
+ 'old_uri, new_uri', (
|
|
|
dbd2ef |
+ ('https://example.com:443/foo', 'https://example.com/bar'),
|
|
|
dbd2ef |
+ ('http://example.com:80/foo', 'http://example.com/bar'),
|
|
|
dbd2ef |
+ ('https://example.com/foo', 'https://example.com:443/bar'),
|
|
|
dbd2ef |
+ ('http://example.com/foo', 'http://example.com:80/bar')
|
|
|
dbd2ef |
+ ))
|
|
|
dbd2ef |
+ def test_should_strip_auth_default_port(self, old_uri, new_uri):
|
|
|
dbd2ef |
+ s = requests.Session()
|
|
|
dbd2ef |
+ assert not s.should_strip_auth(old_uri, new_uri)
|
|
|
dbd2ef |
+
|
|
|
dbd2ef |
def test_manual_redirect_with_partial_body_read(self):
|
|
|
dbd2ef |
s = requests.Session()
|
|
|
dbd2ef |
r1 = s.get(httpbin('redirect/2'), allow_redirects=False, stream=True)
|