|
 |
b52212 |
From 393b4c2384639fc1c22e3493585c005009b58de7 Mon Sep 17 00:00:00 2001
|
|
|
b52212 |
From: Coiby Xu <coiby.xu@gmail.com>
|
|
|
b52212 |
Date: Tue, 15 Jun 2021 10:48:50 +0800
|
|
|
b52212 |
Subject: [PATCH 5/8] fix Error: MISSING_COMMA: detected by covscan
|
|
|
b52212 |
|
|
|
b52212 |
This commit fixes the following errors found by conscan,
|
|
|
b52212 |
|
|
|
b52212 |
Error: MISSING_COMMA: [#def3]
|
|
|
b52212 |
python-dmidecode-3.12.2/src/dmidecode.c:1375: missing_comma: In the initialization of "upgrade", a suspicious concatenated string ""Socket BGA1288Socket rPGA988B"" is produced due to a missing comma between lines.
|
|
|
b52212 |
python-dmidecode-3.12.2/src/dmidecode.c:1375: remediation: Did you intend to separate these two string literals with a comma?
|
|
|
b52212 |
# 1373| "Socket LGA1567",
|
|
|
b52212 |
# 1374| "Socket PGA988A",
|
|
|
b52212 |
# 1375|-> "Socket BGA1288" /* 0x20 */
|
|
|
b52212 |
# 1376| "Socket rPGA988B",
|
|
|
b52212 |
# 1377| "Socket BGA1023",
|
|
|
b52212 |
|
|
|
b52212 |
Error: MISSING_COMMA: [#def4]
|
|
|
b52212 |
python-dmidecode-3.12.2/src/dmidecode.c:1843: missing_comma: In the initialization of "type", a suspicious concatenated string ""64-way Set-associative20-way Set-associative"" is produced due to a missing comma between lines.
|
|
|
b52212 |
python-dmidecode-3.12.2/src/dmidecode.c:1843: remediation: Did you intend to separate these two string literals with a comma?
|
|
|
b52212 |
|
|
|
b52212 |
Error: MISSING_COMMA: [#def6]
|
|
|
b52212 |
python-dmidecode-3.12.2/src/dmidecode.c:2868: missing_comma: In the initialization of "type", a suspicious concatenated string ""DDR3FBD2"" is produced.
|
|
|
b52212 |
python-dmidecode-3.12.2/src/dmidecode.c:2868: remediation: Did you intend to separate these two string literals with a comma?
|
|
|
b52212 |
# 2866| "Reserved",
|
|
|
b52212 |
# 2867| "Reserved",
|
|
|
b52212 |
# 2868|-> "DDR3"
|
|
|
b52212 |
# 2869| "FBD2" /* 0x19 */
|
|
|
b52212 |
# 2870| };
|
|
|
b52212 |
# 1841| "32-way Set-associative",
|
|
|
b52212 |
# 1842| "48-way Set-associative",
|
|
|
b52212 |
# 1843|-> "64-way Set-associative" /* 0x0D */
|
|
|
b52212 |
# 1844| "20-way Set-associative" /* 0x0E */
|
|
|
b52212 |
|
|
|
b52212 |
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
|
|
|
b52212 |
---
|
|
|
b52212 |
src/dmidecode.c | 6 +++---
|
|
|
b52212 |
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
|
b52212 |
|
|
|
b52212 |
diff --git a/src/dmidecode.c b/src/dmidecode.c
|
|
|
b52212 |
index 9efab60..d30a5d3 100644
|
|
|
b52212 |
--- a/src/dmidecode.c
|
|
|
b52212 |
+++ b/src/dmidecode.c
|
|
|
b52212 |
@@ -1372,7 +1372,7 @@ void dmi_processor_upgrade(xmlNode *node, u8 code)
|
|
|
b52212 |
"Socket LGA1156",
|
|
|
b52212 |
"Socket LGA1567",
|
|
|
b52212 |
"Socket PGA988A",
|
|
|
b52212 |
- "Socket BGA1288" /* 0x20 */
|
|
|
b52212 |
+ "Socket BGA1288", /* 0x20 */
|
|
|
b52212 |
"Socket rPGA988B",
|
|
|
b52212 |
"Socket BGA1023",
|
|
|
b52212 |
"Socket BGA1224",
|
|
|
b52212 |
@@ -1840,7 +1840,7 @@ void dmi_cache_associativity(xmlNode *node, u8 code)
|
|
|
b52212 |
"24-way Set-associative",
|
|
|
b52212 |
"32-way Set-associative",
|
|
|
b52212 |
"48-way Set-associative",
|
|
|
b52212 |
- "64-way Set-associative" /* 0x0D */
|
|
|
b52212 |
+ "64-way Set-associative", /* 0x0D */
|
|
|
b52212 |
"20-way Set-associative" /* 0x0E */
|
|
|
b52212 |
};
|
|
|
b52212 |
xmlNode *data_n = xmlNewChild(node, NULL, (xmlChar *) "Associativity", NULL);
|
|
|
b52212 |
@@ -2865,7 +2865,7 @@ void dmi_memory_device_type(xmlNode *node, u8 code)
|
|
|
b52212 |
"Reserved",
|
|
|
b52212 |
"Reserved",
|
|
|
b52212 |
"Reserved",
|
|
|
b52212 |
- "DDR3"
|
|
|
b52212 |
+ "DDR3",
|
|
|
b52212 |
"FBD2" /* 0x19 */
|
|
|
b52212 |
};
|
|
|
b52212 |
xmlNode *data_n = xmlNewChild(node, NULL, (xmlChar *) "Type", NULL);
|
|
|
b52212 |
--
|
|
|
b52212 |
2.31.1
|
|
|
b52212 |
|