|
 |
4cf2aa |
From 5643ecc7530489bf0875c4fe96031671b3cda435 Mon Sep 17 00:00:00 2001
|
|
|
4cf2aa |
From: Lichen Liu <lichliu@redhat.com>
|
|
|
4cf2aa |
Date: Fri, 17 Feb 2023 11:09:05 +0800
|
|
|
4cf2aa |
Subject: [PATCH] Fix wrong DMI structures count
|
|
|
4cf2aa |
|
|
|
4cf2aa |
SMBIOS v3 64-bit entry points do not announce a structures count,
|
|
|
4cf2aa |
and only indicate a maximum size for the table.
|
|
|
4cf2aa |
|
|
|
4cf2aa |
Remove debug log.
|
|
|
4cf2aa |
|
|
|
4cf2aa |
Signed-off-by: Lichen Liu <lichliu@redhat.com>
|
|
|
4cf2aa |
---
|
|
|
4cf2aa |
src/dmidecode.c | 10 +++++++---
|
|
|
4cf2aa |
src/efi.c | 4 ----
|
|
|
4cf2aa |
2 files changed, 7 insertions(+), 7 deletions(-)
|
|
|
4cf2aa |
|
|
|
4cf2aa |
diff --git a/src/dmidecode.c b/src/dmidecode.c
|
|
|
4cf2aa |
index d1a10c1..a013c53 100644
|
|
|
4cf2aa |
--- a/src/dmidecode.c
|
|
|
4cf2aa |
+++ b/src/dmidecode.c
|
|
|
4cf2aa |
@@ -6241,13 +6241,17 @@ static void dmi_table(Log_t *logp, int type, u32 base, u32 len, u16 num, u32 ver
|
|
|
4cf2aa |
dmixml_AddAttribute(handle_n, "type", "%i", type);
|
|
|
4cf2aa |
dmixml_AddAttribute(handle_n, "notfound", "1");
|
|
|
4cf2aa |
}
|
|
|
4cf2aa |
-
|
|
|
4cf2aa |
- if(i != num) {
|
|
|
4cf2aa |
+ /*
|
|
|
4cf2aa |
+ * SMBIOS v3 64-bit entry points do not announce a structures count,
|
|
|
4cf2aa |
+ * and only indicate a maximum size for the table.
|
|
|
4cf2aa |
+ */
|
|
|
4cf2aa |
+ if(num && i != num) {
|
|
|
4cf2aa |
log_append(logp, LOGFL_NODUPS, LOG_WARNING,
|
|
|
4cf2aa |
"Wrong DMI structures count: %d announced, only %d decoded.", num, i);
|
|
|
4cf2aa |
}
|
|
|
4cf2aa |
|
|
|
4cf2aa |
- if(data - buf != len) {
|
|
|
4cf2aa |
+ if((unsigned long)(data - buf) > len
|
|
|
4cf2aa |
+ || (num && (unsigned long)(data - buf) < len)) {
|
|
|
4cf2aa |
log_append(logp, LOGFL_NODUPS, LOG_WARNING,
|
|
|
4cf2aa |
"Wrong DMI structures length: %d bytes announced, structures occupy %d bytes.",
|
|
|
4cf2aa |
len, (unsigned int)(data - buf));
|
|
|
4cf2aa |
diff --git a/src/efi.c b/src/efi.c
|
|
|
4cf2aa |
index e519257..362e2f9 100644
|
|
|
4cf2aa |
--- a/src/efi.c
|
|
|
4cf2aa |
+++ b/src/efi.c
|
|
|
4cf2aa |
@@ -83,10 +83,6 @@ int address_from_efi(Log_t *logp, size_t * address)
|
|
|
4cf2aa |
log_append(logp, LOGFL_NODUPS, LOG_WARNING, "%s: SMBIOS entry point missing", filename);
|
|
|
4cf2aa |
}
|
|
|
4cf2aa |
|
|
|
4cf2aa |
- if(ret == 0){
|
|
|
4cf2aa |
- log_append(logp, LOGFL_NODUPS, LOG_DEBUG, "%s: entry point at 0x%08llx", eptype, (unsigned long long)*address);
|
|
|
4cf2aa |
- }
|
|
|
4cf2aa |
-
|
|
|
4cf2aa |
return ret;
|
|
|
4cf2aa |
}
|
|
|
4cf2aa |
|
|
|
4cf2aa |
--
|
|
|
4cf2aa |
2.39.1
|
|
|
4cf2aa |
|