From 9c6e30f14e252fde87f7c851233180d03e29dcd3 Mon Sep 17 00:00:00 2001

From: Peter Meerwald <p.meerwald@bct-electronic.com>

Date: Mon, 16 Dec 2013 16:35:50 +0100

Subject: [PATCH 1/3] core: Fix resource leak in core-util

https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8477&defectInstanceId=3693&mergedDefectId=591269

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>

---

 src/pulsecore/core-util.c | 8 ++++++--

 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c

index 2685c78..bdfafd0 100644

--- a/src/pulsecore/core-util.c

+++ b/src/pulsecore/core-util.c

@@ -278,16 +278,20 @@ again:

         goto fail;

     }

-    if (!update_perms)

+    if (!update_perms) {

+        pa_assert_se(pa_close(fd) >= 0);

         return 0;

+    }

 #ifdef HAVE_FCHOWN

     if (uid == (uid_t) -1)

         uid = getuid();

     if (gid == (gid_t) -1)

         gid = getgid();

-    if (fchown(fd, uid, gid) < 0)

+    if (fchown(fd, uid, gid) < 0) {

+        pa_assert_se(pa_close(fd) >= 0);

         goto fail;

+    }

 #endif

 #ifdef HAVE_FCHMOD

-- 

1.9.3