Back-port of upstream 9.3 patch to support multiple sockets

(upstream git commits c9b0cbe98bd783e24a8c4d8d8ac472a494b81292 and

d2286a98ef3fb88bafb57381b4c20b8b878827f1, plus updates of derived

documentation files).

Note the patch also touches html-stamp and man-stamp in doc/src/sgml/;

this is to keep the makefiles from trying to rebuild the derived doc

files.  We don't want that to happen because the BuildRequires for the

package don't include the necessary documentation tools.  Those diff

hunks *must be at the end* so that those files are newer than the

master doc files.

diff -up postgresql-9.2.10/contrib/pg_upgrade/server.c.orig postgresql-9.2.10/contrib/pg_upgrade/server.c

--- postgresql-9.2.10/contrib/pg_upgrade/server.c.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/contrib/pg_upgrade/server.c	2015-02-26 14:04:26.613801158 +0100

@@ -197,7 +197,8 @@ start_postmaster(ClusterInfo *cluster)

 		snprintf(socket_string + strlen(socket_string),

 				 sizeof(socket_string) - strlen(socket_string),

 				 " -c %s='%s'",

-				 (GET_MAJOR_VERSION(cluster->major_version) < 903) ?

+	/* assume 9.1 build will not have unix_socket_directories patch */

+				 (GET_MAJOR_VERSION(cluster->major_version) < 902) ?

 				 "unix_socket_directory" : "unix_socket_directories",

 				 cluster->sockdir);

 #endif

diff -up postgresql-9.2.10/doc/src/sgml/client-auth.sgml.orig postgresql-9.2.10/doc/src/sgml/client-auth.sgml

--- postgresql-9.2.10/doc/src/sgml/client-auth.sgml.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/client-auth.sgml	2015-02-26 14:04:26.614801168 +0100

@@ -838,7 +838,7 @@ omicron         bryanh

     <varname>unix_socket_permissions</varname> (and possibly

     <varname>unix_socket_group</varname>) configuration parameters as

     described in <xref linkend="runtime-config-connection">.  Or you

-    could set the <varname>unix_socket_directory</varname>

+    could set the <varname>unix_socket_directories</varname>

     configuration parameter to place the socket file in a suitably

     restricted directory.

    </para>

diff -up postgresql-9.2.10/doc/src/sgml/config.sgml.orig postgresql-9.2.10/doc/src/sgml/config.sgml

--- postgresql-9.2.10/doc/src/sgml/config.sgml.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/config.sgml	2015-02-26 14:04:26.617801197 +0100

@@ -453,17 +453,24 @@ SET ENABLE_SEQSCAN TO OFF;

       </listitem>

      </varlistentry>

-     <varlistentry id="guc-unix-socket-directory" xreflabel="unix_socket_directory">

-      <term><varname>unix_socket_directory</varname> (<type>string</type>)</term>

+     <varlistentry id="guc-unix-socket-directories" xreflabel="unix_socket_directories">

+      <term><varname>unix_socket_directories</varname> (<type>string</type>)</term>

       <indexterm>

-       <primary><varname>unix_socket_directory configuration parameter</primary>

+       <primary><varname>unix_socket_directories configuration parameter</primary>

       </indexterm>

       <listitem>

        <para>

-        Specifies the directory of the Unix-domain socket on which the

-        server is to listen for

-        connections from client applications.  The default is normally

-        <filename>/tmp</filename>, but can be changed at build time.

+        Specifies the directory of the Unix-domain socket(s) on which the

+        server is to listen for connections from client applications.

+        Multiple sockets can be created by listing multiple directories

+        separated by commas.  Whitespace between entries is

+        ignored; surround a directory name with double quotes if you need

+        to include whitespace or commas in the name.

+        An empty value

+        specifies not listening on any Unix-domain sockets, in which case

+        only TCP/IP sockets can be used to connect to the server.

+        The default value is normally

+        <filename>/tmp</filename>, but that can be changed at build time.

         This parameter can only be set at server start.

        </para>

@@ -472,8 +479,8 @@ SET ENABLE_SEQSCAN TO OFF;

         <literal>.s.PGSQL.<replaceable>nnnn</literal> where

         <replaceable>nnnn is the server's port number, an ordinary file

         named <literal>.s.PGSQL.<replaceable>nnnn.lock</literal> will be

-        created in the <varname>unix_socket_directory directory.  Neither

-        file should ever be removed manually.

+        created in each of the <varname>unix_socket_directories directories.

+        Neither file should ever be removed manually.

        </para>

        <para>

@@ -490,8 +497,8 @@ SET ENABLE_SEQSCAN TO OFF;

       </indexterm>

       <listitem>

        <para>

-        Sets the owning group of the Unix-domain socket.  (The owning

-        user of the socket is always the user that starts the

+        Sets the owning group of the Unix-domain socket(s).  (The owning

+        user of the sockets is always the user that starts the

         server.)  In combination with the parameter

         <varname>unix_socket_permissions</varname> this can be used as

         an additional access control mechanism for Unix-domain connections.

@@ -514,7 +521,7 @@ SET ENABLE_SEQSCAN TO OFF;

       </indexterm>

       <listitem>

        <para>

-        Sets the access permissions of the Unix-domain socket.  Unix-domain

+        Sets the access permissions of the Unix-domain socket(s).  Unix-domain

         sockets use the usual Unix file system permission set.

         The parameter value is expected to be a numeric mode

         specified in the format accepted by the

@@ -6624,7 +6631,7 @@ LOG:  CleanUpLock: deleting: lock(0xb7ac

        </row>

        <row>

         <entry><option>-k <replaceable>x</replaceable></option></entry>

-        <entry><literal>unix_socket_directory = <replaceable>x</replaceable></entry>

+        <entry><literal>unix_socket_directories = <replaceable>x</replaceable></entry>

        </row>

        <row>

         <entry><option>-l</option></entry>

diff -up postgresql-9.2.10/doc/src/sgml/html/app-postgres.html.orig postgresql-9.2.10/doc/src/sgml/html/app-postgres.html

--- postgresql-9.2.10/doc/src/sgml/html/app-postgres.html.orig	2015-02-02 21:59:33.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/html/app-postgres.html	2015-02-26 14:04:26.618801207 +0100

@@ -574,11 +574,19 @@ CLASS="REPLACEABLE"

 CLASS="COMMAND"

 >postgres

 > is to listen for

-        connections from client applications.  The default is normally

+        connections from client applications.  The value can also be a

+        comma-separated list of directories.  An empty value

+        specifies not listening on any Unix-domain sockets, in which case

+        only TCP/IP sockets can be used to connect to the server.

+        The default value is normally

 CLASS="FILENAME"

 >/tmp

->, but can be changed at build time.

+>, but that can be changed at build time.

+        Specifying this option is equivalent to setting the 

+HREF="runtime-config-connection.html#GUC-UNIX-SOCKET-DIRECTORIES"

+>unix_socket_directories

+> configuration parameter.

 >

 >

diff -up postgresql-9.2.10/doc/src/sgml/html/auth-methods.html.orig postgresql-9.2.10/doc/src/sgml/html/auth-methods.html

--- postgresql-9.2.10/doc/src/sgml/html/auth-methods.html.orig	2015-02-02 21:59:17.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/html/auth-methods.html	2015-02-26 14:04:26.620801227 +0100

@@ -161,7 +161,7 @@ HREF="runtime-config-connection.html"

 >.  Or you

     could set the 

 CLASS="VARNAME"

->unix_socket_directory

+>unix_socket_directories

 >

     configuration parameter to place the socket file in a suitably

     restricted directory.

diff -up postgresql-9.2.10/doc/src/sgml/html/bookindex.html.orig postgresql-9.2.10/doc/src/sgml/html/bookindex.html

--- postgresql-9.2.10/doc/src/sgml/html/bookindex.html.orig	2015-02-02 22:00:12.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/html/bookindex.html	2015-02-26 14:04:26.625801276 +0100

@@ -17250,7 +17250,7 @@ HREF="xfunc-c.html#DFUNC"

 >

 >

 >

->unix_socket_directory configuration parameter,

+>unix_socket_directories configuration parameter,

 HREF="runtime-config-connection.html#RUNTIME-CONFIG-CONNECTION-SETTINGS"

 >Connection Settings

diff -up postgresql-9.2.10/doc/src/sgml/html/preventing-server-spoofing.html.orig postgresql-9.2.10/doc/src/sgml/html/preventing-server-spoofing.html

--- postgresql-9.2.10/doc/src/sgml/html/preventing-server-spoofing.html.orig	2015-02-02 21:59:16.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/html/preventing-server-spoofing.html	2015-02-26 14:04:26.626801286 +0100

@@ -115,8 +115,8 @@ CLASS="LITERAL"

 >local

 >

    connections is to use a Unix domain socket directory (

-HREF="runtime-config-connection.html#GUC-UNIX-SOCKET-DIRECTORY"

->unix_socket_directory

+HREF="runtime-config-connection.html#GUC-UNIX-SOCKET-DIRECTORIES"

+>unix_socket_directories

 >) that has write permission only

    for a trusted local user.  This prevents a malicious user from creating

    their own socket file in that directory.  If you are concerned that

diff -up postgresql-9.2.10/doc/src/sgml/html/runtime-config-connection.html.orig postgresql-9.2.10/doc/src/sgml/html/runtime-config-connection.html

--- postgresql-9.2.10/doc/src/sgml/html/runtime-config-connection.html.orig	2015-02-02 21:59:16.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/html/runtime-config-connection.html	2015-02-26 14:04:26.628801305 +0100

@@ -274,24 +274,31 @@ CLASS="VARNAME"

 >

 >

 >

-NAME="GUC-UNIX-SOCKET-DIRECTORY"

+NAME="GUC-UNIX-SOCKET-DIRECTORIES"

 >

 >

 CLASS="VARNAME"

->unix_socket_directory

+>unix_socket_directories

 > (

 CLASS="TYPE"

 >string

 >)

 >

 >

->        Specifies the directory of the Unix-domain socket on which the

-        server is to listen for

-        connections from client applications.  The default is normally

+>        Specifies the directory of the Unix-domain socket(s) on which the

+        server is to listen for connections from client applications.

+        Multiple sockets can be created by listing multiple directories

+        separated by commas.  Whitespace between entries is

+        ignored; surround a directory name with double quotes if you need

+        to include whitespace or commas in the name.

+        An empty value

+        specifies not listening on any Unix-domain sockets, in which case

+        only TCP/IP sockets can be used to connect to the server.

+        The default value is normally

 CLASS="FILENAME"

 >/tmp

->, but can be changed at build time.

+>, but that can be changed at build time.

         This parameter can only be set at server start.

 >

@@ -320,11 +327,11 @@ CLASS="REPLACEABLE"

 >

 >.lock

 > will be

-        created in the 

+        created in each of the 

 CLASS="VARNAME"

->unix_socket_directory

-> directory.  Neither

-        file should ever be removed manually.

+>unix_socket_directories

+> directories.

+        Neither file should ever be removed manually.

 >

 >        This parameter is irrelevant on Windows, which does not have

@@ -344,8 +351,8 @@ CLASS="TYPE"

 >)

 >

 >

->        Sets the owning group of the Unix-domain socket.  (The owning

-        user of the socket is always the user that starts the

+>        Sets the owning group of the Unix-domain socket(s).  (The owning

+        user of the sockets is always the user that starts the

         server.)  In combination with the parameter

 CLASS="VARNAME"

@@ -374,7 +381,7 @@ CLASS="TYPE"

 >)

 >

 >

->        Sets the access permissions of the Unix-domain socket.  Unix-domain

+>        Sets the access permissions of the Unix-domain socket(s).  Unix-domain

         sockets use the usual Unix file system permission set.

         The parameter value is expected to be a numeric mode

         specified in the format accepted by the

diff -up postgresql-9.2.10/doc/src/sgml/html/runtime-config-short.html.orig postgresql-9.2.10/doc/src/sgml/html/runtime-config-short.html

--- postgresql-9.2.10/doc/src/sgml/html/runtime-config-short.html.orig	2015-02-02 21:59:17.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/html/runtime-config-short.html	2015-02-26 14:04:26.629801315 +0100

@@ -330,7 +330,7 @@ CLASS="REPLACEABLE"

 >

 >

 CLASS="LITERAL"

->unix_socket_directory = 

+>unix_socket_directories = 

 CLASS="REPLACEABLE"

 >

 >x

diff -up postgresql-9.2.10/doc/src/sgml/man1/postgres.1.orig postgresql-9.2.10/doc/src/sgml/man1/postgres.1

--- postgresql-9.2.10/doc/src/sgml/man1/postgres.1.orig	2015-02-02 22:01:09.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/man1/postgres.1	2015-02-26 14:04:26.631801334 +0100

@@ -195,8 +195,10 @@ directly\&.

 .RS 4

 Specifies the directory of the Unix\-domain socket on which

 \fBpostgres\fR

-is to listen for connections from client applications\&. The default is normally

-/tmp, but can be changed at build time\&.

+is to listen for connections from client applications\&. The value can also be a comma\-separated list of directories\&. An empty value specifies not listening on any Unix\-domain sockets, in which case only TCP/IP sockets can be used to connect to the server\&. The default value is normally

+/tmp, but that can be changed at build time\&. Specifying this option is equivalent to setting the

+unix_socket_directories

+configuration parameter\&.

 .RE

 .PP

 \fB\-l\fR

diff -up postgresql-9.2.10/doc/src/sgml/ref/postgres-ref.sgml.orig postgresql-9.2.10/doc/src/sgml/ref/postgres-ref.sgml

--- postgresql-9.2.10/doc/src/sgml/ref/postgres-ref.sgml.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/ref/postgres-ref.sgml	2015-02-26 14:04:26.632801344 +0100

@@ -254,8 +254,14 @@ PostgreSQL documentation

        <para>

         Specifies the directory of the Unix-domain socket on which

         <command>postgres</command> is to listen for

-        connections from client applications.  The default is normally

-        <filename>/tmp</filename>, but can be changed at build time.

+        connections from client applications.  The value can also be a

+        comma-separated list of directories.  An empty value

+        specifies not listening on any Unix-domain sockets, in which case

+        only TCP/IP sockets can be used to connect to the server.

+        The default value is normally

+        <filename>/tmp</filename>, but that can be changed at build time.

+        Specifying this option is equivalent to setting the 

+        linkend="guc-unix-socket-directories"> configuration parameter.

        </para>

       </listitem>

      </varlistentry>

diff -up postgresql-9.2.10/doc/src/sgml/runtime.sgml.orig postgresql-9.2.10/doc/src/sgml/runtime.sgml

--- postgresql-9.2.10/doc/src/sgml/runtime.sgml.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/doc/src/sgml/runtime.sgml	2015-02-26 14:04:26.633801354 +0100

@@ -1800,7 +1800,7 @@ pg_dumpall -p 5432 | psql -d postgres -p

   <para>

    The simplest way to prevent spoofing for <literal>local

    connections is to use a Unix domain socket directory (

-   linkend="guc-unix-socket-directory">) that has write permission only

+   linkend="guc-unix-socket-directories">) that has write permission only

    for a trusted local user.  This prevents a malicious user from creating

    their own socket file in that directory.  If you are concerned that

    some applications might still reference <filename>/tmp for the

diff -up postgresql-9.2.10/src/backend/libpq/pqcomm.c.orig postgresql-9.2.10/src/backend/libpq/pqcomm.c

--- postgresql-9.2.10/src/backend/libpq/pqcomm.c.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/src/backend/libpq/pqcomm.c	2015-02-26 14:04:26.634801364 +0100

@@ -42,7 +42,7 @@

  *		StreamServerPort	- Open postmaster's server port

  *		StreamConnection	- Create new connection with client

  *		StreamClose			- Close a client/backend connection

- *		TouchSocketFile		- Protect socket file against /tmp cleaners

+ *		TouchSocketFiles	- Protect socket files against /tmp cleaners

  *		pq_init			- initialize libpq at backend startup

  *		pq_comm_reset	- reset libpq during error recovery

  *		pq_close		- shutdown libpq at backend exit

@@ -103,8 +103,8 @@ int			Unix_socket_permissions;

 char	   *Unix_socket_group;

-/* Where the Unix socket file is */

-static char sock_path[MAXPGPATH];

+/* Where the Unix socket files are (list of palloc'd strings) */

+static List *sock_paths = NIL;

 /*

@@ -141,8 +141,8 @@ static int	internal_flush(void);

 static void pq_set_nonblocking(bool nonblocking);

 #ifdef HAVE_UNIX_SOCKETS

-static int	Lock_AF_UNIX(unsigned short portNumber, char *unixSocketName);

-static int	Setup_AF_UNIX(void);

+static int	Lock_AF_UNIX(char *unixSocketDir, char *unixSocketPath);

+static int	Setup_AF_UNIX(char *sock_path);

 #endif   /* HAVE_UNIX_SOCKETS */

@@ -236,29 +236,43 @@ pq_close(int code, Datum arg)

 /* StreamDoUnlink()

  * Shutdown routine for backend connection

- * If a Unix socket is used for communication, explicitly close it.

+ * If any Unix sockets are used for communication, explicitly close them.

  */

 #ifdef HAVE_UNIX_SOCKETS

 static void

 StreamDoUnlink(int code, Datum arg)

 {

-	Assert(sock_path[0]);

-	unlink(sock_path);

+	ListCell   *l;

+

+	/* Loop through all created sockets... */

+	foreach(l, sock_paths)

+	{

+		char	   *sock_path = (char *) lfirst(l);

+

+		unlink(sock_path);

+	}

+	/* Since we're about to exit, no need to reclaim storage */

+	sock_paths = NIL;

 }

 #endif   /* HAVE_UNIX_SOCKETS */

 /*

  * StreamServerPort -- open a "listening" port to accept connections.

  *

- * Successfully opened sockets are added to the ListenSocket[] array,

- * at the first position that isn't PGINVALID_SOCKET.

+ * family should be AF_UNIX or AF_UNSPEC; portNumber is the port number.

+ * For AF_UNIX ports, hostName should be NULL and unixSocketDir must be

+ * specified.  For TCP ports, hostName is either NULL for all interfaces or

+ * the interface to listen on, and unixSocketDir is ignored (can be NULL).

+ *

+ * Successfully opened sockets are added to the ListenSocket[] array (of

+ * length MaxListen), at the first position that isn't PGINVALID_SOCKET.

  *

  * RETURNS: STATUS_OK or STATUS_ERROR

  */

 int

 StreamServerPort(int family, char *hostName, unsigned short portNumber,

-				 char *unixSocketName,

+				 char *unixSocketDir,

 				 pgsocket ListenSocket[], int MaxListen)

 {

 	pgsocket	fd;

@@ -275,6 +289,9 @@ StreamServerPort(int family, char *hostN

 	int			listen_index = 0;

 	int			added = 0;

+#ifdef HAVE_UNIX_SOCKETS

+	char		unixSocketPath[MAXPGPATH];

+#endif

 #if !defined(WIN32) || defined(IPV6_V6ONLY)

 	int			one = 1;

 #endif

@@ -288,10 +305,22 @@ StreamServerPort(int family, char *hostN

 #ifdef HAVE_UNIX_SOCKETS

 	if (family == AF_UNIX)

 	{

-		/* Lock_AF_UNIX will also fill in sock_path. */

-		if (Lock_AF_UNIX(portNumber, unixSocketName) != STATUS_OK)

+		/*

+		 * Create unixSocketPath from portNumber and unixSocketDir and lock

+		 * that file path

+		 */

+		UNIXSOCK_PATH(unixSocketPath, portNumber, unixSocketDir);

+		if (strlen(unixSocketPath) >= UNIXSOCK_PATH_BUFLEN)

+		{

+			ereport(LOG,

+					(errmsg("Unix-domain socket path \"%s\" is too long (maximum %d bytes)",

+							unixSocketPath,

+							(int) (UNIXSOCK_PATH_BUFLEN - 1))));

+			return STATUS_ERROR;

+		}

+		if (Lock_AF_UNIX(unixSocketDir, unixSocketPath) != STATUS_OK)

 			return STATUS_ERROR;

-		service = sock_path;

+		service = unixSocketPath;

 	}

 	else

 #endif   /* HAVE_UNIX_SOCKETS */

@@ -434,7 +463,7 @@ StreamServerPort(int family, char *hostN

 					 (IS_AF_UNIX(addr->ai_family)) ?

 				  errhint("Is another postmaster already running on port %d?"

 						  " If not, remove socket file \"%s\" and retry.",

-						  (int) portNumber, sock_path) :

+						  (int) portNumber, service) :

 				  errhint("Is another postmaster already running on port %d?"

 						  " If not, wait a few seconds and retry.",

 						  (int) portNumber)));

@@ -445,7 +474,7 @@ StreamServerPort(int family, char *hostN

 #ifdef HAVE_UNIX_SOCKETS

 		if (addr->ai_family == AF_UNIX)

 		{

-			if (Setup_AF_UNIX() != STATUS_OK)

+			if (Setup_AF_UNIX(service) != STATUS_OK)

 			{

 				closesocket(fd);

 				break;

@@ -492,18 +521,8 @@ StreamServerPort(int family, char *hostN

  * Lock_AF_UNIX -- configure unix socket file path

  */

 static int

-Lock_AF_UNIX(unsigned short portNumber, char *unixSocketName)

+Lock_AF_UNIX(char *unixSocketDir, char *unixSocketPath)

 {

-	UNIXSOCK_PATH(sock_path, portNumber, unixSocketName);

-	if (strlen(sock_path) >= UNIXSOCK_PATH_BUFLEN)

-	{

-		ereport(LOG,

-				(errmsg("Unix-domain socket path \"%s\" is too long (maximum %d bytes)",

-						sock_path,

-						(int) (UNIXSOCK_PATH_BUFLEN - 1))));

-		return STATUS_ERROR;

-	}

-

 	/*

 	 * Grab an interlock file associated with the socket file.

 	 *

@@ -512,13 +531,23 @@ Lock_AF_UNIX(unsigned short portNumber,

 	 * more portable, and second, it lets us remove any pre-existing socket

 	 * file without race conditions.

 	 */

-	CreateSocketLockFile(sock_path, true);

+	CreateSocketLockFile(unixSocketPath, true, unixSocketDir);

 	/*

 	 * Once we have the interlock, we can safely delete any pre-existing

 	 * socket file to avoid failure at bind() time.

 	 */

-	unlink(sock_path);

+	unlink(unixSocketPath);

+

+	/*

+	 * Arrange to unlink the socket file(s) at proc_exit.  If this is the

+	 * first one, set up the on_proc_exit function to do it; then add this

+	 * socket file to the list of files to unlink.

+	 */

+	if (sock_paths == NIL)

+		on_proc_exit(StreamDoUnlink, 0);

+

+	sock_paths = lappend(sock_paths, pstrdup(unixSocketPath));

 	return STATUS_OK;

 }

@@ -528,11 +557,8 @@ Lock_AF_UNIX(unsigned short portNumber,

  * Setup_AF_UNIX -- configure unix socket permissions

  */

 static int

-Setup_AF_UNIX(void)

+Setup_AF_UNIX(char *sock_path)

 {

-	/* Arrange to unlink the socket file at exit */

-	on_proc_exit(StreamDoUnlink, 0);

-

 	/*

 	 * Fix socket ownership/permission if requested.  Note we must do this

 	 * before we listen() to avoid a window where unwanted connections could

@@ -714,20 +740,24 @@ StreamClose(pgsocket sock)

 }

 /*

- * TouchSocketFile -- mark socket file as recently accessed

+ * TouchSocketFiles -- mark socket files as recently accessed

  *

  * This routine should be called every so often to ensure that the socket

- * file has a recent mod date (ordinary operations on sockets usually won't

- * change the mod date).  That saves it from being removed by

+ * files have a recent mod date (ordinary operations on sockets usually won't

+ * change the mod date).  That saves them from being removed by

  * overenthusiastic /tmp-directory-cleaner daemons.  (Another reason we should

  * never have put the socket file in /tmp...)

  */

 void

-TouchSocketFile(void)

+TouchSocketFiles(void)

 {

-	/* Do nothing if we did not create a socket... */

-	if (sock_path[0] != '\0')

+	ListCell   *l;

+

+	/* Loop through all created sockets... */

+	foreach(l, sock_paths)

 	{

+		char	   *sock_path = (char *) lfirst(l);

+

 		/*

 		 * utime() is POSIX standard, utimes() is a common alternative. If we

 		 * have neither, there's no way to affect the mod or access time of

diff -up postgresql-9.2.10/src/backend/postmaster/postmaster.c.orig postgresql-9.2.10/src/backend/postmaster/postmaster.c

--- postgresql-9.2.10/src/backend/postmaster/postmaster.c.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/src/backend/postmaster/postmaster.c	2015-02-26 14:04:26.636801383 +0100

@@ -160,7 +160,9 @@ static Backend *ShmemBackendArray;

 /* The socket number we are listening for connections on */

 int			PostPortNumber;

-char	   *UnixSocketDir;

+/* The directory names for Unix socket(s) */

+char	   *Unix_socket_directories;

+/* The TCP listen address(es) */

 char	   *ListenAddresses;

 /*

@@ -636,7 +638,7 @@ PostmasterMain(int argc, char *argv[])

 				break;

 			case 'k':

-				SetConfigOption("unix_socket_directory", optarg, PGC_POSTMASTER, PGC_S_ARGV);

+				SetConfigOption("unix_socket_directories", optarg, PGC_POSTMASTER, PGC_S_ARGV);

 				break;

 			case 'l':

@@ -880,7 +882,7 @@ PostmasterMain(int argc, char *argv[])

 		/* Need a modifiable copy of ListenAddresses */

 		rawstring = pstrdup(ListenAddresses);

-		/* Parse string into list of identifiers */

+		/* Parse string into list of hostnames */

 		if (!SplitIdentifierString(rawstring, ',', &elemlist))

 		{

 			/* syntax error in list */

@@ -896,12 +898,12 @@ PostmasterMain(int argc, char *argv[])

 			if (strcmp(curhost, "*") == 0)

 				status = StreamServerPort(AF_UNSPEC, NULL,

 										  (unsigned short) PostPortNumber,

-										  UnixSocketDir,

+										  NULL,

 										  ListenSocket, MAXLISTEN);

 			else

 				status = StreamServerPort(AF_UNSPEC, curhost,

 										  (unsigned short) PostPortNumber,

-										  UnixSocketDir,

+										  NULL,

 										  ListenSocket, MAXLISTEN);

 			if (status == STATUS_OK)

@@ -920,7 +922,7 @@ PostmasterMain(int argc, char *argv[])

 								curhost)));

 		}

-		if (!success && list_length(elemlist))

+		if (!success && elemlist != NIL)

 			ereport(FATAL,

 					(errmsg("could not create any TCP/IP sockets")));

@@ -967,13 +969,54 @@ PostmasterMain(int argc, char *argv[])

 #endif

 #ifdef HAVE_UNIX_SOCKETS

-	status = StreamServerPort(AF_UNIX, NULL,

-							  (unsigned short) PostPortNumber,

-							  UnixSocketDir,

-							  ListenSocket, MAXLISTEN);

-	if (status != STATUS_OK)

-		ereport(WARNING,

-				(errmsg("could not create Unix-domain socket")));

+	if (Unix_socket_directories)

+	{

+		char	   *rawstring;

+		List	   *elemlist;

+		ListCell   *l;

+		int			success = 0;

+

+		/* Need a modifiable copy of Unix_socket_directories */

+		rawstring = pstrdup(Unix_socket_directories);

+

+		/* Parse string into list of directories */

+		if (!SplitDirectoriesString(rawstring, ',', &elemlist))

+		{

+			/* syntax error in list */

+			ereport(FATAL,

+					(errcode(ERRCODE_INVALID_PARAMETER_VALUE),

+					 errmsg("invalid list syntax for \"unix_socket_directories\"")));

+		}

+

+		foreach(l, elemlist)

+		{

+			char	   *socketdir = (char *) lfirst(l);

+

+			status = StreamServerPort(AF_UNIX, NULL,

+									  (unsigned short) PostPortNumber,

+									  socketdir,

+									  ListenSocket, MAXLISTEN);

+

+			if (status == STATUS_OK)

+			{

+				success++;

+				/* record the first successful Unix socket in lockfile */

+				if (success == 1)

+					AddToDataDirLockFile(LOCK_FILE_LINE_SOCKET_DIR, socketdir);

+			}

+			else

+				ereport(WARNING,

+						(errmsg("could not create Unix-domain socket in directory \"%s\"",

+								socketdir)));

+		}

+

+		if (!success && elemlist != NIL)

+			ereport(FATAL,

+					(errmsg("could not create any Unix-domain sockets")));

+

+		list_free_deep(elemlist);

+		pfree(rawstring);

+	}

 #endif

 	/*

@@ -1452,15 +1495,15 @@ ServerLoop(void)

 		}

 		/*

-		 * Touch the socket and lock file every 58 minutes, to ensure that

+		 * Touch Unix socket and lock files every 58 minutes, to ensure that

 		 * they are not removed by overzealous /tmp-cleaning tasks.  We assume

 		 * no one runs cleaners with cutoff times of less than an hour ...

 		 */

 		now = time(NULL);

 		if (now - last_touch_time >= 58 * SECS_PER_MINUTE)

 		{

-			TouchSocketFile();

-			TouchSocketLockFile();

+			TouchSocketFiles();

+			TouchSocketLockFiles();

 			last_touch_time = now;

 		}

diff -up postgresql-9.2.10/src/backend/tcop/postgres.c.orig postgresql-9.2.10/src/backend/tcop/postgres.c

--- postgresql-9.2.10/src/backend/tcop/postgres.c.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/src/backend/tcop/postgres.c	2015-02-26 14:04:26.638801403 +0100

@@ -3393,7 +3393,7 @@ process_postgres_switches(int argc, char

 				break;

 			case 'k':

-				SetConfigOption("unix_socket_directory", optarg, ctx, gucsource);

+				SetConfigOption("unix_socket_directories", optarg, ctx, gucsource);

 				break;

 			case 'l':

diff -up postgresql-9.2.10/src/backend/utils/adt/varlena.c.orig postgresql-9.2.10/src/backend/utils/adt/varlena.c

--- postgresql-9.2.10/src/backend/utils/adt/varlena.c.orig	2015-02-02 21:44:39.000000000 +0100

+++ postgresql-9.2.10/src/backend/utils/adt/varlena.c	2015-02-26 14:04:26.639801413 +0100

@@ -2446,6 +2446,119 @@ SplitIdentifierString(char *rawstring, c

 }

+/*

+ * SplitDirectoriesString --- parse a string containing directory names

+ *

+ * This is similar to SplitIdentifierString, except that the parsing

+ * rules are meant to handle pathnames instead of identifiers: there is

+ * no downcasing, embedded spaces are allowed, the max length is MAXPGPATH-1,

+ * and we apply canonicalize_path() to each extracted string.  Because of the

+ * last, the returned strings are separately palloc'd rather than being

+ * pointers into rawstring --- but we still scribble on rawstring.

+ *

+ * Inputs:

+ *	rawstring: the input string; must be modifiable!

+ *	separator: the separator punctuation expected between directories

+ *			   (typically ',' or ';').	Whitespace may also appear around

+ *			   directories.

+ * Outputs:

+ *	namelist: filled with a palloc'd list of directory names.

+ *			  Caller should list_free_deep() this even on error return.

+ *

+ * Returns TRUE if okay, FALSE if there is a syntax error in the string.

+ *

+ * Note that an empty string is considered okay here.

+ */