|
 |
dc3ed5 |
A part of commit 7ecf29a9db86f7161e2ff48e7bb8ea46a90f954f
|
|
|
dc3ed5 |
Author: Miloslav Trmač <mitr@redhat.com>
|
|
|
dc3ed5 |
Date: Wed Feb 8 22:57:21 2017 +0100
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
Fix a memory leak in server_handle_authentication_agent_response{,2}
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
diff --git a/src/polkitbackend/polkitbackendauthority.c b/src/polkitbackend/polkitbackendauthority.c
|
|
|
dc3ed5 |
index 2bcad62..cad3f74 100644
|
|
|
dc3ed5 |
--- a/src/polkitbackend/polkitbackendauthority.c
|
|
|
dc3ed5 |
+++ b/src/polkitbackend/polkitbackendauthority.c
|
|
|
dc3ed5 |
@@ -1054,6 +1054,7 @@ server_handle_authentication_agent_response (Server *server,
|
|
|
dc3ed5 |
g_dbus_method_invocation_return_value (invocation, g_variant_new ("()"));
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
out:
|
|
|
dc3ed5 |
+ g_variant_unref (identity_gvariant);
|
|
|
dc3ed5 |
if (identity != NULL)
|
|
|
dc3ed5 |
g_object_unref (identity);
|
|
|
dc3ed5 |
}
|
|
|
dc3ed5 |
commit d9efd2673d73214e7990e3e67cdddfa77c6a8226
|
|
|
dc3ed5 |
Author: Miloslav Trmač <mitr@redhat.com>
|
|
|
dc3ed5 |
Date: Wed Feb 8 22:55:10 2017 +0100
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
Fix a memory leak in server_handle_unregister_authentication_agent
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
diff --git a/src/polkitbackend/polkitbackendauthority.c b/src/polkitbackend/polkitbackendauthority.c
|
|
|
dc3ed5 |
index 7e08e57..2bcad62 100644
|
|
|
dc3ed5 |
--- a/src/polkitbackend/polkitbackendauthority.c
|
|
|
dc3ed5 |
+++ b/src/polkitbackend/polkitbackendauthority.c
|
|
|
dc3ed5 |
@@ -1003,6 +1003,7 @@ server_handle_unregister_authentication_agent (Server *server,
|
|
|
dc3ed5 |
g_dbus_method_invocation_return_value (invocation, g_variant_new ("()"));
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
out:
|
|
|
dc3ed5 |
+ g_variant_unref (subject_gvariant);
|
|
|
dc3ed5 |
if (subject != NULL)
|
|
|
dc3ed5 |
g_object_unref (subject);
|
|
|
dc3ed5 |
}
|
|
|
dc3ed5 |
commit af4566e1a7e9031b9a05f49c7d27bf379d822016
|
|
|
dc3ed5 |
Author: Miloslav Trmač <mitr@redhat.com>
|
|
|
dc3ed5 |
Date: Thu Feb 9 19:53:54 2017 +0100
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
Fix a memory leak per agent authentication
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
diff --git a/src/polkitbackend/polkitbackendinteractiveauthority.c b/src/polkitbackend/polkitbackendinteractiveauthority.c
|
|
|
dc3ed5 |
index bf0ee48..b8096b3 100644
|
|
|
dc3ed5 |
--- a/src/polkitbackend/polkitbackendinteractiveauthority.c
|
|
|
dc3ed5 |
+++ b/src/polkitbackend/polkitbackendinteractiveauthority.c
|
|
|
dc3ed5 |
@@ -1906,15 +1906,15 @@ authentication_agent_begin_cb (GDBusProxy *proxy,
|
|
|
dc3ed5 |
AuthenticationSession *session = user_data;
|
|
|
dc3ed5 |
gboolean gained_authorization;
|
|
|
dc3ed5 |
gboolean was_dismissed;
|
|
|
dc3ed5 |
+ GVariant *result;
|
|
|
dc3ed5 |
GError *error;
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
was_dismissed = FALSE;
|
|
|
dc3ed5 |
gained_authorization = FALSE;
|
|
|
dc3ed5 |
|
|
|
dc3ed5 |
error = NULL;
|
|
|
dc3ed5 |
- if (!g_dbus_proxy_call_finish (proxy,
|
|
|
dc3ed5 |
- res,
|
|
|
dc3ed5 |
- &error))
|
|
|
dc3ed5 |
+ result = g_dbus_proxy_call_finish (proxy, res, &error);
|
|
|
dc3ed5 |
+ if (result == NULL)
|
|
|
dc3ed5 |
{
|
|
|
dc3ed5 |
g_printerr ("Error performing authentication: %s (%s %d)\n",
|
|
|
dc3ed5 |
error->message,
|
|
|
dc3ed5 |
@@ -1926,6 +1926,7 @@ authentication_agent_begin_cb (GDBusProxy *proxy,
|
|
|
dc3ed5 |
}
|
|
|
dc3ed5 |
else
|
|
|
dc3ed5 |
{
|
|
|
dc3ed5 |
+ g_variant_unref (result);
|
|
|
dc3ed5 |
gained_authorization = session->is_authenticated;
|
|
|
dc3ed5 |
g_debug ("Authentication complete, is_authenticated = %d", session->is_authenticated);
|
|
|
dc3ed5 |
}
|