Blame SOURCES/0028-python-semanage-Improve-handling-of-permissive-state.patch

9bbebd
From 0803fcb2c014b2cedf8f4d92b80fc382916477ee Mon Sep 17 00:00:00 2001
9bbebd
From: Vit Mojzis <vmojzis@redhat.com>
9bbebd
Date: Fri, 27 Sep 2019 16:13:47 +0200
9bbebd
Subject: [PATCH] python/semanage: Improve handling of "permissive" statements
9bbebd
9bbebd
- Add "customized" method to permissiveRecords which is than used for
9bbebd
  "semanage permissive --extract" and "semanage export"
9bbebd
- Enable "semanage permissive --deleteall" (already implemented)
9bbebd
- Add "permissive" to the list of modules exported using
9bbebd
  "semanage export"
9bbebd
- Update "semanage permissive" man page
9bbebd
9bbebd
Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
9bbebd
---
9bbebd
 python/semanage/semanage              | 11 ++++++++---
9bbebd
 python/semanage/semanage-permissive.8 |  8 +++++++-
9bbebd
 python/semanage/seobject.py           |  3 +++
9bbebd
 3 files changed, 18 insertions(+), 4 deletions(-)
9bbebd
9bbebd
diff --git a/python/semanage/semanage b/python/semanage/semanage
9bbebd
index fa78afce..b2bd9df9 100644
9bbebd
--- a/python/semanage/semanage
9bbebd
+++ b/python/semanage/semanage
9bbebd
@@ -722,6 +722,11 @@ def handlePermissive(args):
9bbebd
 
9bbebd
     if args.action == "list":
9bbebd
         OBJECT.list(args.noheading)
9bbebd
+    elif args.action == "deleteall":
9bbebd
+        OBJECT.deleteall()
9bbebd
+    elif args.action == "extract":
9bbebd
+        for i in OBJECT.customized():
9bbebd
+            print("permissive %s" % str(i))
9bbebd
     elif args.type is not None:
9bbebd
         if args.action == "add":
9bbebd
             OBJECT.add(args.type)
9bbebd
@@ -737,9 +742,9 @@ def setupPermissiveParser(subparsers):
9bbebd
     pgroup = permissiveParser.add_mutually_exclusive_group(required=True)
9bbebd
     parser_add_add(pgroup, "permissive")
9bbebd
     parser_add_delete(pgroup, "permissive")
9bbebd
+    parser_add_deleteall(pgroup, "permissive")
9bbebd
+    parser_add_extract(pgroup, "permissive")
9bbebd
     parser_add_list(pgroup, "permissive")
9bbebd
-    #TODO: probably should be also added => need to implement own option handling
9bbebd
-    #parser_add_deleteall(pgroup)
9bbebd
 
9bbebd
     parser_add_noheading(permissiveParser, "permissive")
9bbebd
     parser_add_noreload(permissiveParser, "permissive")
9bbebd
@@ -763,7 +768,7 @@ def setupDontauditParser(subparsers):
9bbebd
 
9bbebd
 
9bbebd
 def handleExport(args):
9bbebd
-    manageditems = ["boolean", "login", "interface", "user", "port", "node", "fcontext", "module", "ibendport", "ibpkey"]
9bbebd
+    manageditems = ["boolean", "login", "interface", "user", "port", "node", "fcontext", "module", "ibendport", "ibpkey", "permissive"]
9bbebd
     for i in manageditems:
9bbebd
         print("%s -D" % i)
9bbebd
     for i in manageditems:
9bbebd
diff --git a/python/semanage/semanage-permissive.8 b/python/semanage/semanage-permissive.8
9bbebd
index 1999a451..5c3364fa 100644
9bbebd
--- a/python/semanage/semanage-permissive.8
9bbebd
+++ b/python/semanage/semanage-permissive.8
9bbebd
@@ -2,7 +2,7 @@
9bbebd
 .SH "NAME"
9bbebd
 .B semanage\-permissive \- SELinux Policy Management permissive mapping tool
9bbebd
 .SH "SYNOPSIS"
9bbebd
-.B semanage permissive [\-h] (\-a | \-d | \-l) [\-n] [\-N] [\-S STORE] [type]
9bbebd
+.B semanage permissive [\-h] [\-n] [\-N] [\-S STORE] (\-\-add TYPE | \-\-delete TYPE | \-\-deleteall | \-\-extract | \-\-list)
9bbebd
 
9bbebd
 .SH "DESCRIPTION"
9bbebd
 semanage is used to configure certain elements of SELinux policy without requiring modification to or recompilation from policy sources.  semanage permissive adds or removes a SELinux Policy permissive module.
9bbebd
@@ -18,9 +18,15 @@ Add a record of the specified object type
9bbebd
 .I   \-d, \-\-delete
9bbebd
 Delete a record of the specified object type
9bbebd
 .TP
9bbebd
+.I   \-D, \-\-deleteall
9bbebd
+Remove all local customizations of permissive domains
9bbebd
+.TP
9bbebd
 .I   \-l, \-\-list
9bbebd
 List records of the specified object type
9bbebd
 .TP
9bbebd
+.I   \-E, \-\-extract
9bbebd
+Extract customizable commands, for use within a transaction
9bbebd
+.TP
9bbebd
 .I   \-n, \-\-noheading
9bbebd
 Do not print heading when listing the specified object type
9bbebd
 .TP
9bbebd
diff --git a/python/semanage/seobject.py b/python/semanage/seobject.py
9bbebd
index 58497e3b..3959abc8 100644
9bbebd
--- a/python/semanage/seobject.py
9bbebd
+++ b/python/semanage/seobject.py
9bbebd
@@ -478,6 +478,9 @@ class permissiveRecords(semanageRecords):
9bbebd
                 l.append(name.split("permissive_")[1])
9bbebd
         return l
9bbebd
 
9bbebd
+    def customized(self):
9bbebd
+        return ["-a %s" % x for x in sorted(self.get_all())]
9bbebd
+
9bbebd
     def list(self, heading=1, locallist=0):
9bbebd
         all = [y["name"] for y in [x for x in sepolicy.info(sepolicy.TYPE) if x["permissive"]]]
9bbebd
         if len(all) == 0:
9bbebd
-- 
9bbebd
2.21.0
9bbebd