Blame SOURCES/0001-Initialize-temporary-buffers-in-general_composite_re.patch
|
 |
3b2bff |
From 6fe0131394fb029d2fccaee6b8edcb108840ad8a Mon Sep 17 00:00:00 2001
|
|
|
3b2bff |
From: Federico Mena Quintero <federico@gnome.org>
|
|
|
3b2bff |
Date: Wed, 18 Mar 2020 18:49:30 -0600
|
|
|
3b2bff |
Subject: [PATCH] Initialize temporary buffers in general_composite_rect()
|
|
|
3b2bff |
|
|
|
3b2bff |
Otherwise, Valgrind shows things like "conditional jump or move
|
|
|
3b2bff |
depends on uninitialised values" errors much later in calling code.
|
|
|
3b2bff |
For example, see https://gitlab.gnome.org/GNOME/librsvg/issues/572
|
|
|
3b2bff |
|
|
|
3b2bff |
Fixes https://gitlab.freedesktop.org/pixman/pixman/issues/9
|
|
|
3b2bff |
---
|
|
|
3b2bff |
pixman/pixman-general.c | 6 ++++++
|
|
|
3b2bff |
1 file changed, 6 insertions(+)
|
|
|
3b2bff |
|
|
|
3b2bff |
diff --git a/pixman/pixman-general.c b/pixman/pixman-general.c
|
|
|
3b2bff |
index 7d74f98..7e5a0d0 100644
|
|
|
3b2bff |
--- a/pixman/pixman-general.c
|
|
|
3b2bff |
+++ b/pixman/pixman-general.c
|
|
|
3b2bff |
@@ -165,6 +165,12 @@ general_composite_rect (pixman_implementation_t *imp,
|
|
|
3b2bff |
|
|
|
3b2bff |
if (!scanline_buffer)
|
|
|
3b2bff |
return;
|
|
|
3b2bff |
+
|
|
|
3b2bff |
+ memset (scanline_buffer, 0, width * Bpp * 3 + 15 * 3);
|
|
|
3b2bff |
+ }
|
|
|
3b2bff |
+ else
|
|
|
3b2bff |
+ {
|
|
|
3b2bff |
+ memset (stack_scanline_buffer, 0, sizeof (stack_scanline_buffer));
|
|
|
3b2bff |
}
|
|
|
3b2bff |
|
|
|
3b2bff |
src_buffer = ALIGN (scanline_buffer);
|
|
|
3b2bff |
--
|
|
|
3b2bff |
2.34.1
|
|
|
3b2bff |
|