|
 |
2067da |
From 58c6a08e00d4a8c99123cfb36f3a399a9b352d24 Mon Sep 17 00:00:00 2001
|
|
|
2067da |
From: Remi Collet <remi@php.net>
|
|
|
2067da |
Date: Tue, 10 Jun 2014 10:28:34 +0200
|
|
|
2067da |
Subject: [PATCH] Fixed bug #67406 built-in web-server segfaults on startup
|
|
|
2067da |
|
|
|
2067da |
Reproduce on aarch64.
|
|
|
2067da |
|
|
|
2067da |
From select man page:
|
|
|
2067da |
"select() may update the timeout argument to indicate how much time was left."
|
|
|
2067da |
So "const" is not ok.
|
|
|
2067da |
---
|
|
|
2067da |
sapi/cli/php_cli_server.c | 6 +++---
|
|
|
2067da |
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
|
2067da |
|
|
|
2067da |
diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
|
|
|
2067da |
index e838d30..3fd24ea 100644
|
|
|
2067da |
--- a/sapi/cli/php_cli_server.c
|
|
|
2067da |
+++ b/sapi/cli/php_cli_server.c
|
|
|
2067da |
@@ -768,11 +768,11 @@ static void php_cli_server_poller_remove(php_cli_server_poller *poller, int mode
|
|
|
2067da |
#endif
|
|
|
2067da |
} /* }}} */
|
|
|
2067da |
|
|
|
2067da |
-static int php_cli_server_poller_poll(php_cli_server_poller *poller, const struct timeval *tv) /* {{{ */
|
|
|
2067da |
+static int php_cli_server_poller_poll(php_cli_server_poller *poller, struct timeval *tv) /* {{{ */
|
|
|
2067da |
{
|
|
|
2067da |
memmove(&poller->active.rfds, &poller->rfds, sizeof(poller->rfds));
|
|
|
2067da |
memmove(&poller->active.wfds, &poller->wfds, sizeof(poller->wfds));
|
|
|
2067da |
- return php_select(poller->max_fd + 1, &poller->active.rfds, &poller->active.wfds, NULL, (struct timeval *)tv);
|
|
|
2067da |
+ return php_select(poller->max_fd + 1, &poller->active.rfds, &poller->active.wfds, NULL, tv);
|
|
|
2067da |
} /* }}} */
|
|
|
2067da |
|
|
|
2067da |
static int php_cli_server_poller_iter_on_active(php_cli_server_poller *poller, void *opaque, int(*callback)(void *, int fd, int events)) /* {{{ */
|
|
|
2067da |
@@ -2349,7 +2349,7 @@ static int php_cli_server_do_event_loop(php_cli_server *server TSRMLS_DC) /* {{{
|
|
|
2067da |
{
|
|
|
2067da |
int retval = SUCCESS;
|
|
|
2067da |
while (server->is_running) {
|
|
|
2067da |
- static const struct timeval tv = { 1, 0 };
|
|
|
2067da |
+ struct timeval tv = { 1, 0 };
|
|
|
2067da |
int n = php_cli_server_poller_poll(&server->poller, &tv;;
|
|
|
2067da |
if (n > 0) {
|
|
|
2067da |
php_cli_server_do_event_for_each_fd(server,
|
|
|
2067da |
--
|
|
|
2067da |
1.9.2
|
|
|
2067da |
|