|
 |
b74969 |
From df78c48354f376cf419d7a97f88ca07d572f00fb Mon Sep 17 00:00:00 2001
|
|
|
b74969 |
From: Xinchen Hui <laruence@php.net>
|
|
|
b74969 |
Date: Wed, 2 Jul 2014 17:45:09 +0800
|
|
|
b74969 |
Subject: [PATCH] Fixed Bug #67538 (SPL Iterators use-after-free)
|
|
|
b74969 |
|
|
|
b74969 |
---
|
|
|
b74969 |
NEWS | 3 +++
|
|
|
b74969 |
ext/spl/spl_dllist.c | 7 +++++--
|
|
|
b74969 |
ext/spl/tests/bug67538.phpt | 17 +++++++++++++++++
|
|
|
b74969 |
3 files changed, 25 insertions(+), 2 deletions(-)
|
|
|
b74969 |
create mode 100644 ext/spl/tests/bug67538.phpt
|
|
|
b74969 |
|
|
|
b74969 |
diff --git a/ext/spl/spl_dllist.c b/ext/spl/spl_dllist.c
|
|
|
b74969 |
index 39a0733..0b44d41 100644
|
|
|
b74969 |
--- a/ext/spl/spl_dllist.c
|
|
|
b74969 |
+++ b/ext/spl/spl_dllist.c
|
|
|
b74969 |
@@ -43,12 +43,10 @@ PHPAPI zend_class_entry *spl_ce_SplStack;
|
|
|
b74969 |
|
|
|
b74969 |
#define SPL_LLIST_DELREF(elem) if(!--(elem)->rc) { \
|
|
|
b74969 |
efree(elem); \
|
|
|
b74969 |
- elem = NULL; \
|
|
|
b74969 |
}
|
|
|
b74969 |
|
|
|
b74969 |
#define SPL_LLIST_CHECK_DELREF(elem) if((elem) && !--(elem)->rc) { \
|
|
|
b74969 |
efree(elem); \
|
|
|
b74969 |
- elem = NULL; \
|
|
|
b74969 |
}
|
|
|
b74969 |
|
|
|
b74969 |
#define SPL_LLIST_ADDREF(elem) (elem)->rc++
|
|
|
b74969 |
@@ -916,6 +914,11 @@ SPL_METHOD(SplDoublyLinkedList, offsetUnset)
|
|
|
b74969 |
llist->dtor(element TSRMLS_CC);
|
|
|
b74969 |
}
|
|
|
b74969 |
|
|
|
b74969 |
+ if (intern->traverse_pointer == element) {
|
|
|
b74969 |
+ SPL_LLIST_DELREF(element);
|
|
|
b74969 |
+ intern->traverse_pointer = NULL;
|
|
|
b74969 |
+ }
|
|
|
b74969 |
+
|
|
|
b74969 |
zval_ptr_dtor((zval **)&element->data);
|
|
|
b74969 |
element->data = NULL;
|
|
|
b74969 |
|
|
|
b74969 |
diff --git a/ext/spl/tests/bug67538.phpt b/ext/spl/tests/bug67538.phpt
|
|
|
b74969 |
new file mode 100644
|
|
|
b74969 |
index 0000000..b6f3848
|
|
|
b74969 |
--- /dev/null
|
|
|
b74969 |
+++ b/ext/spl/tests/bug67538.phpt
|
|
|
b74969 |
@@ -0,0 +1,17 @@
|
|
|
b74969 |
+--TEST--
|
|
|
b74969 |
+Bug #67538 (SPL Iterators use-after-free)
|
|
|
b74969 |
+--FILE--
|
|
|
b74969 |
+
|
|
|
b74969 |
+$list = new SplDoublyLinkedList();
|
|
|
b74969 |
+$list->push('a');
|
|
|
b74969 |
+$list->push('b');
|
|
|
b74969 |
+
|
|
|
b74969 |
+$list->rewind();
|
|
|
b74969 |
+$list->offsetUnset(0);
|
|
|
b74969 |
+$list->push('b');
|
|
|
b74969 |
+$list->offsetUnset(0);
|
|
|
b74969 |
+$list->next();
|
|
|
b74969 |
+echo "okey";
|
|
|
b74969 |
+?>
|
|
|
b74969 |
+--EXPECTF--
|
|
|
b74969 |
+okey
|
|
|
b74969 |
--
|
|
|
b74969 |
1.9.2
|
|
|
b74969 |
|