Blame SOURCES/php-5.4.16-CVE-2014-4049.patch
|
 |
af9dc8 |
From 4f73394fdd95d3165b4391e1b0dedd57fced8c3b Mon Sep 17 00:00:00 2001
|
|
|
af9dc8 |
From: Sara Golemon <pollita@php.net>
|
|
|
af9dc8 |
Date: Tue, 10 Jun 2014 11:18:02 -0700
|
|
|
af9dc8 |
Subject: [PATCH] Fix potential segfault in dns_get_record()
|
|
|
af9dc8 |
|
|
|
af9dc8 |
If the remote sends us a packet with a malformed TXT record,
|
|
|
af9dc8 |
we could end up trying to over-consume the packet and wander
|
|
|
af9dc8 |
off into overruns.
|
|
|
af9dc8 |
---
|
|
|
af9dc8 |
ext/standard/dns.c | 4 ++++
|
|
|
af9dc8 |
1 file changed, 4 insertions(+)
|
|
|
af9dc8 |
|
|
|
af9dc8 |
diff --git a/ext/standard/dns.c b/ext/standard/dns.c
|
|
|
af9dc8 |
index 6a89446..214a7dc 100644
|
|
|
af9dc8 |
--- a/ext/standard/dns.c
|
|
|
af9dc8 |
+++ b/ext/standard/dns.c
|
|
|
af9dc8 |
@@ -517,6 +517,10 @@ static u_char *php_parserr(u_char *cp, querybuf *answer, int type_to_fetch, int
|
|
|
af9dc8 |
|
|
|
af9dc8 |
while (ll < dlen) {
|
|
|
af9dc8 |
n = cp[ll];
|
|
|
af9dc8 |
+ if ((ll + n) >= dlen) {
|
|
|
af9dc8 |
+ // Invalid chunk length, truncate
|
|
|
af9dc8 |
+ n = dlen - (ll + 1);
|
|
|
af9dc8 |
+ }
|
|
|
af9dc8 |
memcpy(tp + ll , cp + ll + 1, n);
|
|
|
af9dc8 |
add_next_index_stringl(entries, cp + ll + 1, n, 1);
|
|
|
af9dc8 |
ll = ll + n + 1;
|
|
|
af9dc8 |
--
|
|
|
af9dc8 |
1.9.3
|
|
|
af9dc8 |
|