|
 |
b74969 |
From 40ef6e07e0b2cdced57c506e08cf18f47122292d Mon Sep 17 00:00:00 2001
|
|
|
b74969 |
From: Remi Collet <remi@php.net>
|
|
|
b74969 |
Date: Tue, 10 Jun 2014 14:22:04 +0200
|
|
|
b74969 |
Subject: [PATCH] Bug #67412 fileinfo: cdf_count_chain insufficient
|
|
|
b74969 |
boundary check
|
|
|
b74969 |
|
|
|
b74969 |
Upstream:
|
|
|
b74969 |
https://github.com/file/file/commit/40bade80cbe2af1d0b2cd0420cebd5d5905a2382
|
|
|
b74969 |
---
|
|
|
b74969 |
ext/fileinfo/libmagic/cdf.c | 7 ++++---
|
|
|
b74969 |
1 file changed, 4 insertions(+), 3 deletions(-)
|
|
|
b74969 |
|
|
|
b74969 |
diff --git a/ext/fileinfo/libmagic/cdf.c b/ext/fileinfo/libmagic/cdf.c
|
|
|
b74969 |
index c9a5d50..ee467a6 100644
|
|
|
b74969 |
--- a/ext/fileinfo/libmagic/cdf.c
|
|
|
b74969 |
+++ b/ext/fileinfo/libmagic/cdf.c
|
|
|
b74969 |
@@ -470,7 +470,8 @@ size_t
|
|
|
b74969 |
cdf_count_chain(const cdf_sat_t *sat, cdf_secid_t sid, size_t size)
|
|
|
b74969 |
{
|
|
|
b74969 |
size_t i, j;
|
|
|
b74969 |
- cdf_secid_t maxsector = (cdf_secid_t)(sat->sat_len * size);
|
|
|
b74969 |
+ cdf_secid_t maxsector = (cdf_secid_t)((sat->sat_len * size)
|
|
|
b74969 |
+ / sizeof(maxsector));
|
|
|
b74969 |
|
|
|
b74969 |
DPRINTF(("Chain:"));
|
|
|
b74969 |
for (j = i = 0; sid >= 0; i++, j++) {
|
|
|
b74969 |
@@ -480,8 +481,8 @@ cdf_count_chain(const cdf_sat_t *sat, cdf_secid_t sid, size_t size)
|
|
|
b74969 |
errno = EFTYPE;
|
|
|
b74969 |
return (size_t)-1;
|
|
|
b74969 |
}
|
|
|
b74969 |
- if (sid > maxsector) {
|
|
|
b74969 |
- DPRINTF(("Sector %d > %d\n", sid, maxsector));
|
|
|
b74969 |
+ if (sid >= maxsector) {
|
|
|
b74969 |
+ DPRINTF(("Sector %d >= %d\n", sid, maxsector));
|
|
|
b74969 |
errno = EFTYPE;
|
|
|
b74969 |
return (size_t)-1;
|
|
|
b74969 |
}
|
|
|
b74969 |
--
|
|
|
b74969 |
1.9.2
|
|
|
b74969 |
|