|
 |
4bf471 |
From c555fd74c009242c3864576bd5f17a1f8f4fdffd Mon Sep 17 00:00:00 2001
|
|
|
4bf471 |
From: Peter Jones <pjones@redhat.com>
|
|
|
4bf471 |
Date: Tue, 18 Feb 2020 16:28:56 -0500
|
|
|
4bf471 |
Subject: [PATCH] pesigcheck: Fix a wrong assignment
|
|
|
4bf471 |
|
|
|
4bf471 |
gcc says:
|
|
|
4bf471 |
|
|
|
4bf471 |
pesigcheck.c: In function 'check_signature':
|
|
|
4bf471 |
pesigcheck.c:321:17: error: implicit conversion from 'enum <anonymous>' to 'enum <anonymous>' [-Werror=enum-conversion]
|
|
|
4bf471 |
321 | reason->type = siBuffer;
|
|
|
4bf471 |
| ^
|
|
|
4bf471 |
pesigcheck.c:333:17: error: implicit conversion from 'enum <anonymous>' to 'enum <anonymous>' [-Werror=enum-conversion]
|
|
|
4bf471 |
333 | reason->type = siBuffer;
|
|
|
4bf471 |
| ^
|
|
|
4bf471 |
cc1: all warnings being treated as errors
|
|
|
4bf471 |
|
|
|
4bf471 |
And indeed, that line of code makes no sense at all - it was supposed to
|
|
|
4bf471 |
be reason->sig.type.
|
|
|
4bf471 |
|
|
|
4bf471 |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
4bf471 |
---
|
|
|
4bf471 |
src/pesigcheck.c | 4 ++--
|
|
|
4bf471 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
4bf471 |
|
|
|
4bf471 |
diff --git a/src/pesigcheck.c b/src/pesigcheck.c
|
|
|
4bf471 |
index 524cce307bf..8fa0f1ad03d 100644
|
|
|
4bf471 |
--- a/src/pesigcheck.c
|
|
|
4bf471 |
+++ b/src/pesigcheck.c
|
|
|
4bf471 |
@@ -318,7 +318,7 @@ check_signature(pesigcheck_context *ctx, int *nreasons,
|
|
|
4bf471 |
reason->type = SIGNATURE;
|
|
|
4bf471 |
reason->sig.data = data;
|
|
|
4bf471 |
reason->sig.len = datalen;
|
|
|
4bf471 |
- reason->type = siBuffer;
|
|
|
4bf471 |
+ reason->sig.type = siBuffer;
|
|
|
4bf471 |
nreason += 1;
|
|
|
4bf471 |
is_invalid = true;
|
|
|
4bf471 |
}
|
|
|
4bf471 |
@@ -330,7 +330,7 @@ check_signature(pesigcheck_context *ctx, int *nreasons,
|
|
|
4bf471 |
reason->type = SIGNATURE;
|
|
|
4bf471 |
reason->sig.data = data;
|
|
|
4bf471 |
reason->sig.len = datalen;
|
|
|
4bf471 |
- reason->type = siBuffer;
|
|
|
4bf471 |
+ reason->sig.type = siBuffer;
|
|
|
4bf471 |
nreason += 1;
|
|
|
4bf471 |
has_valid_cert = true;
|
|
|
4bf471 |
}
|
|
|
4bf471 |
--
|
|
|
4bf471 |
2.24.1
|
|
|
4bf471 |
|