|
 |
4bf471 |
From b535d1ac5cbcdf18a97d97a92581e38080d9e521 Mon Sep 17 00:00:00 2001
|
|
|
4bf471 |
From: Peter Jones <pjones@redhat.com>
|
|
|
4bf471 |
Date: Tue, 14 May 2019 11:28:38 -0400
|
|
|
4bf471 |
Subject: [PATCH] efikeygen: Fix the build with nss 3.44
|
|
|
4bf471 |
|
|
|
4bf471 |
NSS 3.44 adds some certificate types, which changes a type and makes
|
|
|
4bf471 |
some encoding stuff weird. As a result, we get:
|
|
|
4bf471 |
|
|
|
4bf471 |
gcc8 -I/wrkdirs/usr/ports/sysutils/pesign/work/pesign-0.110/include -O2 -pipe -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc8 -isystem /usr/local/include -fno-strict-aliasing -g -O0 -g -O0 -Wall -fshort-wchar -fno-strict-aliasing -fno-merge-constants --std=gnu99 -D_GNU_SOURCE -Wno-unused-result -Wno-unused-function -I../include/ -I/usr/local/include/nss -I/usr/local/include/nss/nss -I/usr/local/include/nspr -Werror -fPIC -isystem /usr/local/include -DCONFIG_amd64 -DCONFIG_amd64 -c efikeygen.c -o efikeygen.o
|
|
|
4bf471 |
In file included from /usr/local/include/nss/nss/cert.h:22,
|
|
|
4bf471 |
from efikeygen.c:39:
|
|
|
4bf471 |
efikeygen.c: In function 'add_cert_type':
|
|
|
4bf471 |
/usr/local/include/nss/nss/certt.h:445:5: error: unsigned conversion from 'int' to 'unsigned char' changes value from '496' to '240' [-Werror=overflow]
|
|
|
4bf471 |
(NS_CERT_TYPE_SSL_CLIENT | NS_CERT_TYPE_SSL_SERVER | NS_CERT_TYPE_EMAIL | \
|
|
|
4bf471 |
^
|
|
|
4bf471 |
efikeygen.c:208:23: note: in expansion of macro 'NS_CERT_TYPE_APP'
|
|
|
4bf471 |
unsigned char type = NS_CERT_TYPE_APP;
|
|
|
4bf471 |
^~~~~~~~~~~~~~~~
|
|
|
4bf471 |
cc1: all warnings being treated as errors
|
|
|
4bf471 |
|
|
|
4bf471 |
This is fixed by just making it an int.
|
|
|
4bf471 |
|
|
|
4bf471 |
Fixes github issue #48.
|
|
|
4bf471 |
|
|
|
4bf471 |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
4bf471 |
---
|
|
|
4bf471 |
src/efikeygen.c | 2 +-
|
|
|
4bf471 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
4bf471 |
|
|
|
4bf471 |
diff --git a/src/efikeygen.c b/src/efikeygen.c
|
|
|
4bf471 |
index ede76ef0b48..2cd953e9781 100644
|
|
|
4bf471 |
--- a/src/efikeygen.c
|
|
|
4bf471 |
+++ b/src/efikeygen.c
|
|
|
4bf471 |
@@ -208,7 +208,7 @@ static int
|
|
|
4bf471 |
add_cert_type(cms_context *cms, void *extHandle, int is_ca)
|
|
|
4bf471 |
{
|
|
|
4bf471 |
SECItem bitStringValue;
|
|
|
4bf471 |
- unsigned char type = NS_CERT_TYPE_APP;
|
|
|
4bf471 |
+ int type = NS_CERT_TYPE_APP;
|
|
|
4bf471 |
|
|
|
4bf471 |
if (is_ca)
|
|
|
4bf471 |
type |= NS_CERT_TYPE_SSL_CA |
|
|
|
4bf471 |
--
|
|
|
4bf471 |
2.23.0
|
|
|
4bf471 |
|