Blame SOURCES/perl-5.17.9-106212-Add-PL_perlio_mutex-to-atfork_lock.patch

9572a7
From 4da80956418bbe1fdc23cad0b1cbb24cd7b87609 Mon Sep 17 00:00:00 2001
9572a7
From: =?UTF-8?q?Patrik=20H=C3=A4gglund?= <patrik.h.hagglund@ericsson.com>
9572a7
Date: Sat, 2 Feb 2013 20:21:05 +0100
9572a7
Subject: [PATCH] PATCH [perl #106212] Add PL_perlio_mutex to
9572a7
 atfork_lock/unlock
9572a7
9572a7
Using threads + fork() on Linux, and IO operations in the threads, the
9572a7
PL_perlio_mutex may be left in a locked state at the call of fork(),
9572a7
potentially leading to deadlock in the child process at subsequent IO
9572a7
operations. (Threads are pre-empted and not continued in the child
9572a7
process after the fork.)
9572a7
9572a7
Therefore, ensure that the PL_perlio_mutex is unlocked in the child
9572a7
process, right after fork(), by using atfork_lock/unlock.
9572a7
9572a7
(The RT text gives ways to reproduce the problem, but are not easily
9572a7
added to Perl's test suite)
9572a7
---
9572a7
 util.c | 6 ++++++
9572a7
 1 file changed, 6 insertions(+)
9572a7
9572a7
diff --git a/util.c b/util.c
9572a7
index 5c695b8..75381f1 100644
9572a7
--- a/util.c
9572a7
+++ b/util.c
9572a7
@@ -2798,6 +2798,9 @@ Perl_atfork_lock(void)
9572a7
    dVAR;
9572a7
 #if defined(USE_ITHREADS)
9572a7
     /* locks must be held in locking order (if any) */
9572a7
+#  ifdef USE_PERLIO
9572a7
+    MUTEX_LOCK(&PL_perlio_mutex);
9572a7
+#  endif
9572a7
 #  ifdef MYMALLOC
9572a7
     MUTEX_LOCK(&PL_malloc_mutex);
9572a7
 #  endif
9572a7
@@ -2812,6 +2815,9 @@ Perl_atfork_unlock(void)
9572a7
     dVAR;
9572a7
 #if defined(USE_ITHREADS)
9572a7
     /* locks must be released in same order as in atfork_lock() */
9572a7
+#  ifdef USE_PERLIO
9572a7
+    MUTEX_UNLOCK(&PL_perlio_mutex);
9572a7
+#  endif
9572a7
 #  ifdef MYMALLOC
9572a7
     MUTEX_UNLOCK(&PL_malloc_mutex);
9572a7
 #  endif
9572a7
-- 
9572a7
1.8.1.4
9572a7