|
 |
9572a7 |
From 78787052b6a68c0f54cfa983a69c44276de9daa4 Mon Sep 17 00:00:00 2001
|
|
|
9572a7 |
From: Jesse Luehrs <doy@tozt.net>
|
|
|
9572a7 |
Date: Tue, 26 Jun 2012 00:13:54 -0500
|
|
|
9572a7 |
Subject: [PATCH] use a less broken test for locale radix in atof [perl #109318]
|
|
|
9572a7 |
|
|
|
9572a7 |
---
|
|
|
9572a7 |
lib/locale.t | 33 +++++++++++++++++++++++++++++++++
|
|
|
9572a7 |
numeric.c | 25 +++++++++++++++----------
|
|
|
9572a7 |
2 files changed, 48 insertions(+), 10 deletions(-)
|
|
|
9572a7 |
|
|
|
9572a7 |
diff --git a/lib/locale.t b/lib/locale.t
|
|
|
9572a7 |
index dfc6d2b..26a7bd4 100644
|
|
|
9572a7 |
--- a/lib/locale.t
|
|
|
9572a7 |
+++ b/lib/locale.t
|
|
|
9572a7 |
@@ -1247,6 +1247,39 @@ foreach $Locale (@Locale) {
|
|
|
9572a7 |
print "# failed $locales_test_number locale '$Locale' characters @f\n"
|
|
|
9572a7 |
}
|
|
|
9572a7 |
}
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ # [perl #109318]
|
|
|
9572a7 |
+ {
|
|
|
9572a7 |
+ my @f = ();
|
|
|
9572a7 |
+ ++$locales_test_number;
|
|
|
9572a7 |
+ $test_names{$locales_test_number} = 'Verify atof with locale radix and negative exponent';
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ my $radix = POSIX::localeconv()->{decimal_point};
|
|
|
9572a7 |
+ my @nums = (
|
|
|
9572a7 |
+ "3.14e+9", "3${radix}14e+9", "3.14e-9", "3${radix}14e-9",
|
|
|
9572a7 |
+ "-3.14e+9", "-3${radix}14e+9", "-3.14e-9", "-3${radix}14e-9",
|
|
|
9572a7 |
+ );
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ if (! $is_utf8_locale) {
|
|
|
9572a7 |
+ use locale;
|
|
|
9572a7 |
+ for my $num (@nums) {
|
|
|
9572a7 |
+ push @f, $num
|
|
|
9572a7 |
+ unless sprintf("%g", $num) =~ /3.+14/;
|
|
|
9572a7 |
+ }
|
|
|
9572a7 |
+ }
|
|
|
9572a7 |
+ else {
|
|
|
9572a7 |
+ use locale ':not_characters';
|
|
|
9572a7 |
+ for my $num (@nums) {
|
|
|
9572a7 |
+ push @f, $num
|
|
|
9572a7 |
+ unless sprintf("%g", $num) =~ /3.+14/;
|
|
|
9572a7 |
+ }
|
|
|
9572a7 |
+ }
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ tryneoalpha($Locale, $locales_test_number, @f == 0);
|
|
|
9572a7 |
+ if (@f) {
|
|
|
9572a7 |
+ print "# failed $locales_test_number locale '$Locale' numbers @f\n"
|
|
|
9572a7 |
+ }
|
|
|
9572a7 |
+ }
|
|
|
9572a7 |
}
|
|
|
9572a7 |
|
|
|
9572a7 |
my $final_locales_test_number = $locales_test_number;
|
|
|
9572a7 |
diff --git a/numeric.c b/numeric.c
|
|
|
9572a7 |
index be86f3a..3eb8a0e 100644
|
|
|
9572a7 |
--- a/numeric.c
|
|
|
9572a7 |
+++ b/numeric.c
|
|
|
9572a7 |
@@ -847,17 +847,22 @@ Perl_my_atof(pTHX_ const char* s)
|
|
|
9572a7 |
|
|
|
9572a7 |
PERL_ARGS_ASSERT_MY_ATOF;
|
|
|
9572a7 |
|
|
|
9572a7 |
- if (PL_numeric_local && IN_SOME_LOCALE_FORM) {
|
|
|
9572a7 |
- NV y;
|
|
|
9572a7 |
+ if (PL_numeric_local && PL_numeric_radix_sv && IN_SOME_LOCALE_FORM) {
|
|
|
9572a7 |
+ char *standard = NULL, *local = NULL;
|
|
|
9572a7 |
+ bool use_standard_radix;
|
|
|
9572a7 |
|
|
|
9572a7 |
- /* Scan the number twice; once using locale and once without;
|
|
|
9572a7 |
- * choose the larger result (in absolute value). */
|
|
|
9572a7 |
- Perl_atof2(s, x);
|
|
|
9572a7 |
- SET_NUMERIC_STANDARD();
|
|
|
9572a7 |
- Perl_atof2(s, y);
|
|
|
9572a7 |
- SET_NUMERIC_LOCAL();
|
|
|
9572a7 |
- if ((y < 0.0 && y < x) || (y > 0.0 && y > x))
|
|
|
9572a7 |
- return y;
|
|
|
9572a7 |
+ standard = strchr(s, '.');
|
|
|
9572a7 |
+ local = strstr(s, SvPV_nolen(PL_numeric_radix_sv));
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ use_standard_radix = standard && (!local || standard < local);
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ if (use_standard_radix)
|
|
|
9572a7 |
+ SET_NUMERIC_STANDARD();
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ Perl_atof2(s, x);
|
|
|
9572a7 |
+
|
|
|
9572a7 |
+ if (use_standard_radix)
|
|
|
9572a7 |
+ SET_NUMERIC_LOCAL();
|
|
|
9572a7 |
}
|
|
|
9572a7 |
else
|
|
|
9572a7 |
Perl_atof2(s, x);
|
|
|
9572a7 |
--
|
|
|
9572a7 |
1.7.4.1
|
|
|
9572a7 |
|