|
 |
3f1b01 |
From e17dadf36f7b4348e59076240c880d0c78b33fa9 Mon Sep 17 00:00:00 2001
|
|
|
3f1b01 |
From: Karl Williamson <khw@cpan.org>
|
|
|
3f1b01 |
Date: Tue, 22 Sep 2020 08:47:52 -0600
|
|
|
3f1b01 |
Subject: [PATCH] sv.h: sv_collxfrm didn't work properly
|
|
|
3f1b01 |
MIME-Version: 1.0
|
|
|
3f1b01 |
Content-Type: text/plain; charset=UTF-8
|
|
|
3f1b01 |
Content-Transfer-Encoding: 8bit
|
|
|
3f1b01 |
|
|
|
3f1b01 |
It is supposed to be a wrapper for sv_collxfrm_flags, but it was just
|
|
|
3f1b01 |
calling sv_cmp_flags instead. The consequences are none except under
|
|
|
3f1b01 |
'use locale' in which case you always got the C locale. I did not add
|
|
|
3f1b01 |
tests, because it is really a pain to write portable locale tests, and
|
|
|
3f1b01 |
this doesn't seem to be much used. In core the '_flags' form was always
|
|
|
3f1b01 |
used.
|
|
|
3f1b01 |
|
|
|
3f1b01 |
Signed-off-by: Petr Písař <ppisar@redhat.com>
|
|
|
3f1b01 |
---
|
|
|
3f1b01 |
sv.h | 2 +-
|
|
|
3f1b01 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
3f1b01 |
|
|
|
3f1b01 |
diff --git a/sv.h b/sv.h
|
|
|
3f1b01 |
index 19ce718ac3..44414b35a9 100644
|
|
|
3f1b01 |
--- a/sv.h
|
|
|
3f1b01 |
+++ b/sv.h
|
|
|
3f1b01 |
@@ -2045,7 +2045,7 @@ Like C<sv_catsv> but doesn't process magic.
|
|
|
3f1b01 |
#define sv_eq(sv1, sv2) sv_eq_flags(sv1, sv2, SV_GMAGIC)
|
|
|
3f1b01 |
#define sv_cmp(sv1, sv2) sv_cmp_flags(sv1, sv2, SV_GMAGIC)
|
|
|
3f1b01 |
#define sv_cmp_locale(sv1, sv2) sv_cmp_locale_flags(sv1, sv2, SV_GMAGIC)
|
|
|
3f1b01 |
-#define sv_collxfrm(sv, nxp) sv_cmp_flags(sv, nxp, SV_GMAGIC)
|
|
|
3f1b01 |
+#define sv_collxfrm(sv, nxp) sv_collxfrm_flags(sv, nxp, SV_GMAGIC)
|
|
|
3f1b01 |
#define sv_2bool(sv) sv_2bool_flags(sv, SV_GMAGIC)
|
|
|
3f1b01 |
#define sv_2bool_nomg(sv) sv_2bool_flags(sv, 0)
|
|
|
3f1b01 |
#define sv_insert(bigstr, offset, len, little, littlelen) \
|
|
|
3f1b01 |
--
|
|
|
3f1b01 |
2.25.4
|
|
|
3f1b01 |
|