7e86df
From 81169c06a76f62ff987ed990ac910c2ae08b3f91 Mon Sep 17 00:00:00 2001
7e86df
From: Karl Williamson <khw@cpan.org>
7e86df
Date: Tue, 10 Mar 2020 15:19:57 -0600
7e86df
Subject: [PATCH] reentr.c: Buffer sizes for asctime_r,ctime_r are small
7e86df
MIME-Version: 1.0
7e86df
Content-Type: text/plain; charset=UTF-8
7e86df
Content-Transfer-Encoding: 8bit
7e86df
7e86df
The needed sizes of these are stated in the man pages, and are much
7e86df
smaller than were being allocated.
7e86df
7e86df
Signed-off-by: Petr Písař <ppisar@redhat.com>
7e86df
---
7e86df
 reentr.c        | 4 ++--
7e86df
 regen/reentr.pl | 5 ++++-
7e86df
 2 files changed, 6 insertions(+), 3 deletions(-)
7e86df
7e86df
diff --git a/reentr.c b/reentr.c
7e86df
index 8ddda7bfc0..8438c8f90f 100644
7e86df
--- a/reentr.c
7e86df
+++ b/reentr.c
7e86df
@@ -52,14 +52,14 @@ Perl_reentrant_size(pTHX) {
7e86df
 #  define REENTRANTUSUALSIZE	4096	/* Make something up. */
7e86df
 
7e86df
 #  ifdef HAS_ASCTIME_R
7e86df
-	PL_reentrant_buffer->_asctime_size = REENTRANTSMALLSIZE;
7e86df
+	PL_reentrant_buffer->_asctime_size = 26;
7e86df
 #  endif /* HAS_ASCTIME_R */
7e86df
 
7e86df
 #  ifdef HAS_CRYPT_R
7e86df
 #  endif /* HAS_CRYPT_R */
7e86df
 
7e86df
 #  ifdef HAS_CTIME_R
7e86df
-	PL_reentrant_buffer->_ctime_size = REENTRANTSMALLSIZE;
7e86df
+	PL_reentrant_buffer->_ctime_size = 26;
7e86df
 #  endif /* HAS_CTIME_R */
7e86df
 
7e86df
 #  ifdef HAS_GETGRNAM_R
7e86df
diff --git a/regen/reentr.pl b/regen/reentr.pl
7e86df
index f5788c7ad9..94721e9dec 100644
7e86df
--- a/regen/reentr.pl
7e86df
+++ b/regen/reentr.pl
7e86df
@@ -495,8 +495,11 @@ for my $func (@seenf) {
7e86df
 	char*	_${func}_buffer;
7e86df
 	size_t	_${func}_size;
7e86df
 EOF
7e86df
+            my $size = ($func =~ /^(asctime|ctime)$/)
7e86df
+                       ? 26
7e86df
+                       : "REENTRANTSMALLSIZE";
7e86df
 	    push @size, <
7e86df
-	PL_reentrant_buffer->_${func}_size = REENTRANTSMALLSIZE;
7e86df
+	PL_reentrant_buffer->_${func}_size = $size;
7e86df
 EOF
7e86df
 	    pushinitfree $func;
7e86df
 	    pushssif $endif;
7e86df
-- 
7e86df
2.25.4
7e86df