|
 |
d35ea2 |
From 8a2562bec7cd9f8eff6812f340f99dddd028bb33 Mon Sep 17 00:00:00 2001
|
|
|
d35ea2 |
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
|
|
|
d35ea2 |
Date: Thu, 6 Aug 2020 10:51:56 +0200
|
|
|
d35ea2 |
Subject: [PATCH] IO::Handle: Fix a spurious error reported for regular file
|
|
|
d35ea2 |
handles
|
|
|
d35ea2 |
MIME-Version: 1.0
|
|
|
d35ea2 |
Content-Type: text/plain; charset=UTF-8
|
|
|
d35ea2 |
Content-Transfer-Encoding: 8bit
|
|
|
d35ea2 |
|
|
|
d35ea2 |
89341f87 fix for GH #6799 introduced a regression when calling error()
|
|
|
d35ea2 |
on an IO::Handle object that was opened for reading a regular file:
|
|
|
d35ea2 |
|
|
|
d35ea2 |
$ perl -e 'open my $f, q{<}, q{/etc/hosts} or die; print qq{error\n} if $f->error'
|
|
|
d35ea2 |
error
|
|
|
d35ea2 |
|
|
|
d35ea2 |
In case of a regular file opened for reading, IoOFP() returns NULL and
|
|
|
d35ea2 |
PerlIO_error(NULL) reports -1. Compare to the case of a file opened
|
|
|
d35ea2 |
for writing when both IoIFP() and IoOFP() return non-NULL, equaled
|
|
|
d35ea2 |
pointer.
|
|
|
d35ea2 |
|
|
|
d35ea2 |
This patch fixes handling the case of the NULL output stream.
|
|
|
d35ea2 |
|
|
|
d35ea2 |
GH #18019
|
|
|
d35ea2 |
|
|
|
d35ea2 |
Signed-off-by: Petr Písař <ppisar@redhat.com>
|
|
|
d35ea2 |
---
|
|
|
d35ea2 |
dist/IO/IO.xs | 4 ++--
|
|
|
d35ea2 |
dist/IO/t/io_xs.t | 10 +++++++++-
|
|
|
d35ea2 |
2 files changed, 11 insertions(+), 3 deletions(-)
|
|
|
d35ea2 |
|
|
|
d35ea2 |
diff --git a/dist/IO/IO.xs b/dist/IO/IO.xs
|
|
|
d35ea2 |
index 9158106416..fb009774c4 100644
|
|
|
d35ea2 |
--- a/dist/IO/IO.xs
|
|
|
d35ea2 |
+++ b/dist/IO/IO.xs
|
|
|
d35ea2 |
@@ -397,9 +397,9 @@ ferror(handle)
|
|
|
d35ea2 |
CODE:
|
|
|
d35ea2 |
if (in)
|
|
|
d35ea2 |
#ifdef PerlIO
|
|
|
d35ea2 |
- RETVAL = PerlIO_error(in) || (in != out && PerlIO_error(out));
|
|
|
d35ea2 |
+ RETVAL = PerlIO_error(in) || (out && in != out && PerlIO_error(out));
|
|
|
d35ea2 |
#else
|
|
|
d35ea2 |
- RETVAL = ferror(in) || (in != out && ferror(out));
|
|
|
d35ea2 |
+ RETVAL = ferror(in) || (out && in != out && ferror(out));
|
|
|
d35ea2 |
#endif
|
|
|
d35ea2 |
else {
|
|
|
d35ea2 |
RETVAL = -1;
|
|
|
d35ea2 |
diff --git a/dist/IO/t/io_xs.t b/dist/IO/t/io_xs.t
|
|
|
d35ea2 |
index a8833b0651..4657088629 100644
|
|
|
d35ea2 |
--- a/dist/IO/t/io_xs.t
|
|
|
d35ea2 |
+++ b/dist/IO/t/io_xs.t
|
|
|
d35ea2 |
@@ -11,7 +11,7 @@ BEGIN {
|
|
|
d35ea2 |
}
|
|
|
d35ea2 |
}
|
|
|
d35ea2 |
|
|
|
d35ea2 |
-use Test::More tests => 8;
|
|
|
d35ea2 |
+use Test::More tests => 10;
|
|
|
d35ea2 |
use IO::File;
|
|
|
d35ea2 |
use IO::Seekable;
|
|
|
d35ea2 |
|
|
|
d35ea2 |
@@ -69,3 +69,11 @@ SKIP: {
|
|
|
d35ea2 |
ok(!$fh->error, "check clearerr removed the error");
|
|
|
d35ea2 |
close $fh; # silently ignore the error
|
|
|
d35ea2 |
}
|
|
|
d35ea2 |
+
|
|
|
d35ea2 |
+{
|
|
|
d35ea2 |
+ # [GH #18019] IO::Handle->error misreported an error after successully
|
|
|
d35ea2 |
+ # opening a regular file for reading. It was a regression in GH #6799 fix.
|
|
|
d35ea2 |
+ ok(open(my $fh, '<', __FILE__), "a regular file opened for reading");
|
|
|
d35ea2 |
+ ok(!$fh->error, "no spurious error reported by error()");
|
|
|
d35ea2 |
+ close $fh;
|
|
|
d35ea2 |
+}
|
|
|
d35ea2 |
--
|
|
|
d35ea2 |
2.25.4
|
|
|
d35ea2 |
|