78f1eb
From a4e94e39cfa6852b1d57e61ee122c8083ab9d82e Mon Sep 17 00:00:00 2001
78f1eb
From: Hauke D <haukex@zero-g.net>
78f1eb
Date: Mon, 20 Nov 2017 15:31:57 +0100
78f1eb
Subject: [PATCH] Tie::StdHandle::BINMODE: handle layer argument
78f1eb
MIME-Version: 1.0
78f1eb
Content-Type: text/plain; charset=UTF-8
78f1eb
Content-Transfer-Encoding: 8bit
78f1eb
78f1eb
Fixes #16262
78f1eb
78f1eb
BINMODE was not handling the LAYER argument.
78f1eb
Also bump the version number.
78f1eb
78f1eb
(cherry picked from commit 479d04b98e5b747e5c9ead7368d3e132f524a2b7)
78f1eb
Signed-off-by: Nicolas R <atoomic@cpan.org>
78f1eb
Signed-off-by: Petr Písař <ppisar@redhat.com>
78f1eb
---
78f1eb
 lib/Tie/Handle/stdhandle.t | 13 ++++++++++++-
78f1eb
 lib/Tie/StdHandle.pm       |  4 ++--
78f1eb
 2 files changed, 14 insertions(+), 3 deletions(-)
78f1eb
78f1eb
diff --git a/lib/Tie/Handle/stdhandle.t b/lib/Tie/Handle/stdhandle.t
78f1eb
index d2f04bcc5c..6c20d90f2b 100644
78f1eb
--- a/lib/Tie/Handle/stdhandle.t
78f1eb
+++ b/lib/Tie/Handle/stdhandle.t
78f1eb
@@ -5,7 +5,7 @@ BEGIN {
78f1eb
     @INC = '../lib';
78f1eb
 }
78f1eb
 
78f1eb
-use Test::More tests => 27;
78f1eb
+use Test::More tests => 29;
78f1eb
 
78f1eb
 use_ok('Tie::StdHandle');
78f1eb
 
78f1eb
@@ -72,6 +72,17 @@ is($b, "rhubarbX\n", "b eq rhubarbX");
78f1eb
 $b = <$f>;
78f1eb
 is($b, "89\n", "b eq 89");
78f1eb
 
78f1eb
+# binmode should pass through layer argument
78f1eb
+
78f1eb
+binmode $f, ':raw';
78f1eb
+ok !grep( $_ eq 'utf8', PerlIO::get_layers(tied(*$f)) ),
78f1eb
+    'no utf8 in layers after binmode :raw';
78f1eb
+binmode $f, ':utf8';
78f1eb
+ok grep( $_ eq 'utf8', PerlIO::get_layers(tied(*$f)) ),
78f1eb
+    'utf8 is in layers after binmode :utf8';
78f1eb
+
78f1eb
+# finish up
78f1eb
+
78f1eb
 ok(eof($f), "eof");
78f1eb
 ok(close($f), "close");
78f1eb
 
78f1eb
diff --git a/lib/Tie/StdHandle.pm b/lib/Tie/StdHandle.pm
78f1eb
index dfb86634f0..fb79a986c6 100644
78f1eb
--- a/lib/Tie/StdHandle.pm
78f1eb
+++ b/lib/Tie/StdHandle.pm
78f1eb
@@ -4,7 +4,7 @@ use strict;
78f1eb
 
78f1eb
 use Tie::Handle;
78f1eb
 our @ISA = 'Tie::Handle';
78f1eb
-our $VERSION = '4.5';
78f1eb
+our $VERSION = '4.6';
78f1eb
 
78f1eb
 =head1 NAME
78f1eb
 
78f1eb
@@ -48,7 +48,7 @@ sub TELL    { tell($_[0]) }
78f1eb
 sub FILENO  { fileno($_[0]) }
78f1eb
 sub SEEK    { seek($_[0],$_[1],$_[2]) }
78f1eb
 sub CLOSE   { close($_[0]) }
78f1eb
-sub BINMODE { binmode($_[0]) }
78f1eb
+sub BINMODE { &CORE::binmode(shift, @_) }
78f1eb
 
78f1eb
 sub OPEN
78f1eb
 {
78f1eb
-- 
78f1eb
2.21.0
78f1eb