From 5a9c0da5c338c8c350049ae2d4652049aeb73f03 Mon Sep 17 00:00:00 2001 From: CentOS Sources Date: Aug 04 2020 18:31:40 +0000 Subject: import perftest-4.4-3.el8 --- diff --git a/SOURCES/0001-Don-t-call-ibv_qp_to_qp_ex-when-hardware-does-not-su.patch b/SOURCES/0001-Don-t-call-ibv_qp_to_qp_ex-when-hardware-does-not-su.patch new file mode 100644 index 0000000..3751384 --- /dev/null +++ b/SOURCES/0001-Don-t-call-ibv_qp_to_qp_ex-when-hardware-does-not-su.patch @@ -0,0 +1,73 @@ +From d30e91efc80d058ddad80913f40dffb1e68c841b Mon Sep 17 00:00:00 2001 +From: Honggang Li +Date: Fri, 24 Jul 2020 09:09:00 +0800 +Subject: [PATCH] Don't call ibv_qp_to_qp_ex when hardware does not support + extended QP + +The sizeof 'struct ibv_qp' allocated by ibv_create_qp is 160. +If the memory holds the 'struct ibv_qp' was allocated at the +upper boundary of a memory page, cast it to 'struct verbs_qp', +whose size is 360, may across the memory page boundary. It will +trigger invalid memory access to the next memory page. + +The issue can be reproduced with OPA and QIB HCA. + +For example run over OPA: + Server Node: $ ib_read_bw -F -N -n 1000 -u 20 -q 257 -s 4194304 + Client Node: $ ib_read_bw -F -N -n 1000 -u 20 -q 257 -s 4194304 + + Program received signal SIGSEGV, Segmentation fault. + ibv_qp_to_qp_ex (qp=0x5555557a5f10) at libibverbs/verbs.c:624 + 624 if (vqp->comp_mask & VERBS_QP_EX) + (gdb) bt + #0 ibv_qp_to_qp_ex (qp=0x5555557a5f10) at libibverbs/verbs.c:624 + #1 0x000055555556af4a in create_reg_qp_main (ctx=ctx@entry=0x7fffffffd500, user_param=user_param@entry=0x7fffffffd670, i=i@entry=21, num_of_qps=num_of_qps@entry=128) at src/perftest_resources.c:1597 + #2 0x000055555556b6d7 in create_qp_main (num_of_qps=, i=21, user_param=0x7fffffffd670, ctx=0x7fffffffd500) at src/perftest_resources.c:1613 + #3 ctx_init (ctx=0x7fffffffd500, user_param=0x7fffffffd670) at src/perftest_resources.c:1552 + #4 0x0000555555558e9c in main (argc=, argv=) at src/read_bw.c:149 + +624 if (vqp->comp_mask & VERBS_QP_EX) +(gdb) p qp +$1 = (struct ibv_qp *) 0x5555557a5f10 +(gdb) p vqp +$2 = (struct verbs_qp *) 0x5555557a5f10 +(gdb) p *qp +$3 = {context = 0x55555578ad00, qp_context = 0x0, .... +(gdb) p *vqp +Cannot access memory at address 0x5555557a6000 + +Signed-off-by: Honggang Li +--- + src/perftest_resources.c | 14 ++++++++------ + 1 file changed, 8 insertions(+), 6 deletions(-) + +diff --git a/src/perftest_resources.c b/src/perftest_resources.c +index 56b78bba2c4b..499820c93185 100755 +--- a/src/perftest_resources.c ++++ b/src/perftest_resources.c +@@ -1649,14 +1649,16 @@ int create_reg_qp_main(struct pingpong_context *ctx, + return FAILURE; + } + #ifdef HAVE_IBV_WR_API +- ctx->qpx[i] = ibv_qp_to_qp_ex(ctx->qp[i]); +- #ifdef HAVE_MLX5DV +- if (user_param->connection_type == DC) +- { +- ctx->dv_qp[i] = mlx5dv_qp_ex_from_ibv_qp_ex(ctx->qpx[i]); ++ if (!user_param->use_old_post_send) { ++ ctx->qpx[i] = ibv_qp_to_qp_ex(ctx->qp[i]); ++ #ifdef HAVE_MLX5DV ++ if (user_param->connection_type == DC) ++ { ++ ctx->dv_qp[i] = mlx5dv_qp_ex_from_ibv_qp_ex(ctx->qpx[i]); ++ } ++ #endif + } + #endif +- #endif + + return SUCCESS; + } +-- +2.25.4 + diff --git a/SPECS/perftest.spec b/SPECS/perftest.spec index bc63360..83ff363 100644 --- a/SPECS/perftest.spec +++ b/SPECS/perftest.spec @@ -3,10 +3,11 @@ Summary: IB Performance Tests Version: 4.4 %define minor_release 0.29 %define git_hash g817ec38 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2 or BSD Source0: https://github.com/linux-rdma/perftest/releases/download/V%{version}-%{minor_release}/perftest-%{version}-%{minor_release}.%{git_hash}.tar.gz Source1: ib_atomic_bw.1 +Patch1: 0001-Don-t-call-ibv_qp_to_qp_ex-when-hardware-does-not-su.patch Url: http://www.openfabrics.org BuildRequires: libibverbs-devel > 1.1.4, librdmacm-devel > 1.0.14 BuildRequires: libibumad-devel > 1.3.6 @@ -21,6 +22,7 @@ RDMA networks. %prep %setup -q +%patch1 -p1 autoreconf --force --install %build @@ -48,6 +50,10 @@ popd %{_mandir}/man1/* %changelog +* Fri Jul 24 2020 Honggang Li - 4.4-3 +- Fix segment fault with large QP numbers +- Resolves: rhbz#1859358 + * Mon May 25 2020 Honggang Li - 4.4-2 - Update to upstream 4.4-0.29.g817ec38 tarball - Resolves: rhbz#1832709