|
 |
9183b6 |
From c51faf31a1abc08e26e5ccb4492c1a46f101a22a Mon Sep 17 00:00:00 2001
|
|
|
9183b6 |
From: Ivan Devat <idevat@redhat.com>
|
|
|
9183b6 |
Date: Tue, 13 Dec 2022 12:58:00 +0100
|
|
|
9183b6 |
Subject: [PATCH] fix agents filter in resource/fence device create
|
|
|
9183b6 |
|
|
|
9183b6 |
---
|
|
|
9183b6 |
.../cluster/fenceDevices/task/create/NameTypeTypeSelect.tsx | 4 ++--
|
|
|
9183b6 |
.../view/cluster/resources/task/create/NameTypeTypeSelect.tsx | 4 ++--
|
|
|
9183b6 |
src/app/view/share/form/Select.tsx | 2 +-
|
|
|
9183b6 |
3 files changed, 5 insertions(+), 5 deletions(-)
|
|
|
9183b6 |
|
|
|
9183b6 |
diff --git a/src/app/view/cluster/fenceDevices/task/create/NameTypeTypeSelect.tsx b/src/app/view/cluster/fenceDevices/task/create/NameTypeTypeSelect.tsx
|
|
|
9183b6 |
index 80327801..8d623e2b 100644
|
|
|
9183b6 |
--- a/src/app/view/cluster/fenceDevices/task/create/NameTypeTypeSelect.tsx
|
|
|
9183b6 |
+++ b/src/app/view/cluster/fenceDevices/task/create/NameTypeTypeSelect.tsx
|
|
|
9183b6 |
@@ -38,13 +38,13 @@ export const NameTypeTypeSelect = ({
|
|
|
9183b6 |
return (
|
|
|
9183b6 |
|
|
|
9183b6 |
variant="typeahead"
|
|
|
9183b6 |
- typeAheadAriaLabel="Select a fence device"
|
|
|
9183b6 |
+ typeAheadAriaLabel="Select a fence device agent"
|
|
|
9183b6 |
+ placeholderText="Select a fence device agent"
|
|
|
9183b6 |
onSelect={onSelect}
|
|
|
9183b6 |
onClear={onClear}
|
|
|
9183b6 |
onFilter={onFilter}
|
|
|
9183b6 |
selections={agentName}
|
|
|
9183b6 |
isGrouped
|
|
|
9183b6 |
- hasInlineFilter
|
|
|
9183b6 |
customBadgeText={agentName.length > 0 ? agentName : undefined}
|
|
|
9183b6 |
optionsValues={filteredFenceAgentList}
|
|
|
9183b6 |
data-test="fence-device-agent"
|
|
|
9183b6 |
diff --git a/src/app/view/cluster/resources/task/create/NameTypeTypeSelect.tsx b/src/app/view/cluster/resources/task/create/NameTypeTypeSelect.tsx
|
|
|
9183b6 |
index bd7807d8..b531e825 100644
|
|
|
9183b6 |
--- a/src/app/view/cluster/resources/task/create/NameTypeTypeSelect.tsx
|
|
|
9183b6 |
+++ b/src/app/view/cluster/resources/task/create/NameTypeTypeSelect.tsx
|
|
|
9183b6 |
@@ -52,13 +52,13 @@ export const NameTypeTypeSelect = ({
|
|
|
9183b6 |
return (
|
|
|
9183b6 |
|
|
|
9183b6 |
variant="typeahead"
|
|
|
9183b6 |
- typeAheadAriaLabel="Select a state"
|
|
|
9183b6 |
+ typeAheadAriaLabel="Select a resource agent"
|
|
|
9183b6 |
+ placeholderText="Select a resource agent"
|
|
|
9183b6 |
onSelect={onSelect}
|
|
|
9183b6 |
onClear={onClear}
|
|
|
9183b6 |
onFilter={onFilter}
|
|
|
9183b6 |
selections={agentName}
|
|
|
9183b6 |
isGrouped
|
|
|
9183b6 |
- hasInlineFilter
|
|
|
9183b6 |
customBadgeText={agentName.length > 0 ? agentName : undefined}
|
|
|
9183b6 |
data-test="resource-agent"
|
|
|
9183b6 |
>
|
|
|
9183b6 |
diff --git a/src/app/view/share/form/Select.tsx b/src/app/view/share/form/Select.tsx
|
|
|
9183b6 |
index d73f126c..e2b81ce2 100644
|
|
|
9183b6 |
--- a/src/app/view/share/form/Select.tsx
|
|
|
9183b6 |
+++ b/src/app/view/share/form/Select.tsx
|
|
|
9183b6 |
@@ -31,7 +31,7 @@ export const Select = (
|
|
|
9183b6 |
const filter = onFilter
|
|
|
9183b6 |
? (_event: React.ChangeEvent<HTMLInputElement> | null, value: string) => {
|
|
|
9183b6 |
onFilter(value);
|
|
|
9183b6 |
- return null as unknown as React.ReactElement[];
|
|
|
9183b6 |
+ return undefined;
|
|
|
9183b6 |
}
|
|
|
9183b6 |
: null;
|
|
|
9183b6 |
|
|
|
9183b6 |
--
|
|
|
9183b6 |
2.39.0
|
|
|
9183b6 |
|