|
 |
003ee8 |
From 953f340c3e24c296e9e73f4a0b45ff6563359592 Mon Sep 17 00:00:00 2001
|
|
|
003ee8 |
From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
|
|
|
003ee8 |
Date: Fri, 5 Feb 2016 14:47:11 +0100
|
|
|
003ee8 |
Subject: [PATCH] fdasd.c: Safeguard against geometry misprobing
|
|
|
003ee8 |
|
|
|
003ee8 |
Fixes an issue with parted print being run against a logical
|
|
|
003ee8 |
volume realised by extents on a physical volume residing on
|
|
|
003ee8 |
a DASD.
|
|
|
003ee8 |
We must make sure that geometry, device blocksize and DASD
|
|
|
003ee8 |
attributes are present before we start format verifications
|
|
|
003ee8 |
If any of it is missing this is not a DASD.
|
|
|
003ee8 |
|
|
|
003ee8 |
Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
|
|
|
003ee8 |
Signed-off-by: Brian C. Lane <bcl@redhat.com>
|
|
|
003ee8 |
---
|
|
|
003ee8 |
libparted/labels/fdasd.c | 11 +++++++++--
|
|
|
003ee8 |
1 file changed, 9 insertions(+), 2 deletions(-)
|
|
|
003ee8 |
|
|
|
003ee8 |
diff --git a/libparted/labels/fdasd.c b/libparted/labels/fdasd.c
|
|
|
003ee8 |
index 7e6a77a..968b332 100644
|
|
|
003ee8 |
--- a/libparted/labels/fdasd.c
|
|
|
003ee8 |
+++ b/libparted/labels/fdasd.c
|
|
|
003ee8 |
@@ -1021,13 +1021,20 @@ fdasd_get_geometry (const PedDevice *dev, fdasd_anchor_t *anc, int f)
|
|
|
003ee8 |
goto error;
|
|
|
003ee8 |
}
|
|
|
003ee8 |
|
|
|
003ee8 |
- if (ioctl(f, HDIO_GETGEO, &anc->geo) != 0)
|
|
|
003ee8 |
+ if (ioctl(f, HDIO_GETGEO, &anc->geo) != 0 ||
|
|
|
003ee8 |
+ anc->geo.heads == 0 ||
|
|
|
003ee8 |
+ anc->geo.sectors == 0 ||
|
|
|
003ee8 |
+ anc->geo.cylinders == 0 ) {
|
|
|
003ee8 |
fdasd_error(anc, unable_to_ioctl,
|
|
|
003ee8 |
_("Could not retrieve disk geometry information."));
|
|
|
003ee8 |
+ goto error;
|
|
|
003ee8 |
+ }
|
|
|
003ee8 |
|
|
|
003ee8 |
- if (ioctl(f, BLKSSZGET, &blksize) != 0)
|
|
|
003ee8 |
+ if (ioctl(f, BLKSSZGET, &blksize) != 0) {
|
|
|
003ee8 |
fdasd_error(anc, unable_to_ioctl,
|
|
|
003ee8 |
_("Could not retrieve blocksize information."));
|
|
|
003ee8 |
+ goto error;
|
|
|
003ee8 |
+ }
|
|
|
003ee8 |
|
|
|
003ee8 |
/* get disk type */
|
|
|
003ee8 |
if (ioctl(f, BIODASDINFO, &dasd_info) != 0) {
|
|
|
003ee8 |
--
|
|
|
003ee8 |
2.5.0
|
|
|
003ee8 |
|