Blame SOURCES/bz1165423-pcmk-coverity.patch
|
 |
1f016a |
diff --git a/lib/common/xml.c b/lib/common/xml.c
|
|
|
1f016a |
index 0effd47..f7779f5 100644
|
|
|
1f016a |
--- a/lib/common/xml.c
|
|
|
1f016a |
+++ b/lib/common/xml.c
|
|
|
1f016a |
@@ -2759,7 +2759,7 @@ create_xml_node(xmlNode * parent, const char *name)
|
|
|
1f016a |
xmlNode *node = NULL;
|
|
|
1f016a |
|
|
|
1f016a |
if (name == NULL || name[0] == 0) {
|
|
|
1f016a |
- CRM_CHECK(name != NULL || name[0] == 0, return NULL);
|
|
|
1f016a |
+ CRM_CHECK(name != NULL && name[0] == 0, return NULL);
|
|
|
1f016a |
return NULL;
|
|
|
1f016a |
}
|
|
|
1f016a |
|
|
|
1f016a |
diff --git a/tools/crm_resource.c b/tools/crm_resource.c
|
|
|
1f016a |
index 236d43c..968683a 100644
|
|
|
1f016a |
--- a/tools/crm_resource.c
|
|
|
1f016a |
+++ b/tools/crm_resource.c
|
|
|
1f016a |
@@ -1430,7 +1430,6 @@ update_dataset(cib_t *cib, pe_working_set_t * data_set, bool simulate)
|
|
|
1f016a |
goto cleanup;
|
|
|
1f016a |
}
|
|
|
1f016a |
|
|
|
1f016a |
- free(pid);
|
|
|
1f016a |
rc = write_xml_file(cib_xml_copy, shadow_file, FALSE);
|
|
|
1f016a |
|
|
|
1f016a |
if (rc < 0) {
|