|
 |
26ad17 |
From b542a8f667002519fbc07693a796553746c43c12 Mon Sep 17 00:00:00 2001
|
|
|
26ad17 |
From: Reid Wahl <nrwahl@protonmail.com>
|
|
|
26ad17 |
Date: Sat, 11 Jul 2020 18:31:55 -0700
|
|
|
26ad17 |
Subject: [PATCH] Log: controld: Show action timer plus cluster-delay in
|
|
|
26ad17 |
action_timer cb
|
|
|
26ad17 |
|
|
|
26ad17 |
`action_timer_callback()` prints a misleading error message. If it
|
|
|
26ad17 |
times out waiting for an action result, the error message prints the
|
|
|
26ad17 |
timeout value followed by "(action timeout plus cluster-delay)".
|
|
|
26ad17 |
However, only the `action->timeout` value is displayed. `cluster-delay`
|
|
|
26ad17 |
is not added in.
|
|
|
26ad17 |
|
|
|
26ad17 |
Resolves: RHBZ#1856035
|
|
|
26ad17 |
---
|
|
|
26ad17 |
daemons/controld/controld_te_callbacks.c | 3 ++-
|
|
|
26ad17 |
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
26ad17 |
|
|
|
26ad17 |
diff --git a/daemons/controld/controld_te_callbacks.c b/daemons/controld/controld_te_callbacks.c
|
|
|
26ad17 |
index 8506f26..6ddaffe 100644
|
|
|
26ad17 |
--- a/daemons/controld/controld_te_callbacks.c
|
|
|
26ad17 |
+++ b/daemons/controld/controld_te_callbacks.c
|
|
|
26ad17 |
@@ -697,7 +697,8 @@ action_timer_callback(gpointer data)
|
|
|
26ad17 |
crm_err("Node %s did not send %s result (via %s) within %dms "
|
|
|
26ad17 |
"(action timeout plus cluster-delay)",
|
|
|
26ad17 |
(on_node? on_node : ""), (task? task : "unknown action"),
|
|
|
26ad17 |
- (via_node? via_node : "controller"), timer->timeout);
|
|
|
26ad17 |
+ (via_node? via_node : "controller"),
|
|
|
26ad17 |
+ timer->timeout + transition_graph->network_delay);
|
|
|
26ad17 |
print_action(LOG_ERR, "Aborting transition, action lost: ", timer->action);
|
|
|
26ad17 |
|
|
|
26ad17 |
timer->action->failed = TRUE;
|
|
|
26ad17 |
--
|
|
|
26ad17 |
1.8.3.1
|
|
|
26ad17 |
|