|
 |
3d71c6 |
From: Andrew Beekhof <andrew@beekhof.net>
|
|
 |
3d71c6 |
Date: Wed, 2 Sep 2015 14:32:40 +1000
|
|
 |
3d71c6 |
Subject: [PATCH] Fix: crmd: Choose more appropriate names for notification
|
|
 |
3d71c6 |
options
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
(cherry picked from commit 8971ef024ffebf3d0240b30e620697a7b58232c4)
|
|
 |
3d71c6 |
---
|
|
 |
3d71c6 |
crmd/control.c | 12 ++++++------
|
|
 |
3d71c6 |
cts/CIB.py | 4 ++--
|
|
 |
3d71c6 |
2 files changed, 8 insertions(+), 8 deletions(-)
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
diff --git a/crmd/control.c b/crmd/control.c
|
|
 |
3d71c6 |
index d92f46b..d1f9acd 100644
|
|
 |
3d71c6 |
--- a/crmd/control.c
|
|
 |
3d71c6 |
+++ b/crmd/control.c
|
|
 |
3d71c6 |
@@ -893,12 +893,12 @@ pe_cluster_option crmd_opts[] = {
|
|
 |
3d71c6 |
" To ensure these changes take effect, we can optionally poll the cluster's status for changes."
|
|
 |
3d71c6 |
},
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
- { "notification-script", NULL, "string", NULL, "/dev/null", &check_script,
|
|
 |
3d71c6 |
- "Notification script to be called after significant cluster events",
|
|
 |
3d71c6 |
- "Full path to a script that will be invoked when resources start/stop/fail, fencing occurs or nodes join/leave the cluster.\n"
|
|
 |
3d71c6 |
+ { "notification-agent", NULL, "string", NULL, "/dev/null", &check_script,
|
|
 |
3d71c6 |
+ "Notification script or tool to be called after significant cluster events",
|
|
 |
3d71c6 |
+ "Full path to a script or binary that will be invoked when resources start/stop/fail, fencing occurs or nodes join/leave the cluster.\n"
|
|
 |
3d71c6 |
"Must exist on all nodes in the cluster."
|
|
 |
3d71c6 |
},
|
|
 |
3d71c6 |
- { "notification-target", NULL, "string", NULL, "", NULL,
|
|
 |
3d71c6 |
+ { "notification-recipient", NULL, "string", NULL, "", NULL,
|
|
 |
3d71c6 |
"Destination for notifications (Optional)",
|
|
 |
3d71c6 |
"Where should the supplied script send notifications to. Useful to avoid hard-coding this in the script."
|
|
 |
3d71c6 |
},
|
|
 |
3d71c6 |
@@ -992,8 +992,8 @@ config_query_callback(xmlNode * msg, int call_id, int rc, xmlNode * output, void
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
verify_crmd_options(config_hash);
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
- script = crmd_pref(config_hash, "notification-script");
|
|
 |
3d71c6 |
- value = crmd_pref(config_hash, "notification-target");
|
|
 |
3d71c6 |
+ script = crmd_pref(config_hash, "notification-agent");
|
|
 |
3d71c6 |
+ value = crmd_pref(config_hash, "notification-recipient");
|
|
 |
3d71c6 |
crmd_enable_notifications(script, value);
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
value = crmd_pref(config_hash, XML_CONFIG_ATTR_DC_DEADTIME);
|
|
 |
3d71c6 |
diff --git a/cts/CIB.py b/cts/CIB.py
|
|
 |
3d71c6 |
index cd3a6a1..0933ccd 100644
|
|
 |
3d71c6 |
--- a/cts/CIB.py
|
|
 |
3d71c6 |
+++ b/cts/CIB.py
|
|
 |
3d71c6 |
@@ -219,8 +219,8 @@ class CIB11(ConfigBase):
|
|
 |
3d71c6 |
o["dc-deadtime"] = "5s"
|
|
 |
3d71c6 |
o["no-quorum-policy"] = no_quorum
|
|
 |
3d71c6 |
o["expected-quorum-votes"] = self.num_nodes
|
|
 |
3d71c6 |
- o["notification-script"] = "/var/lib/pacemaker/notify.sh"
|
|
 |
3d71c6 |
- o["notification-target"] = "/var/lib/pacemaker/notify.log"
|
|
 |
3d71c6 |
+ o["notification-agent"] = "/var/lib/pacemaker/notify.sh"
|
|
 |
3d71c6 |
+ o["notification-recipient"] = "/var/lib/pacemaker/notify.log"
|
|
 |
3d71c6 |
|
|
 |
3d71c6 |
if self.CM.Env["DoBSC"] == 1:
|
|
 |
3d71c6 |
o["ident-string"] = "Linux-HA TEST configuration file - REMOVEME!!"
|