From 06d9464335d81f4b78a4ff8c0daf890b947f571f Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Fri, 20 Nov 2020 01:17:12 +0100 Subject: [PATCH 04/16] test-ovn: Fix expression leak. No need to clone when assigning to the same variable. Fixes: 024500aeab9a ("expr: Evaluate the condition expression in a separate step.") Acked-by: Dumitru Ceara Signed-off-by: Ilya Maximets Signed-off-by: Numan Siddique --- tests/test-ovn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-ovn.c b/tests/test-ovn.c index 6662ced54..471126143 100644 --- a/tests/test-ovn.c +++ b/tests/test-ovn.c @@ -918,7 +918,7 @@ test_tree_shape_exhaustively(struct expr *expr, struct shash *symtab, } else if (operation >= OP_SIMPLIFY) { modified = expr_simplify(expr_clone(expr)); modified = expr_evaluate_condition( - expr_clone(modified), tree_shape_is_chassis_resident_cb, + modified, tree_shape_is_chassis_resident_cb, NULL, NULL); ovs_assert(expr_honors_invariants(modified)); -- 2.28.0