|
 |
773311 |
From 32972260b50f39d493cc42a78d9648ed668c2aec Mon Sep 17 00:00:00 2001
|
|
|
773311 |
Message-Id: <32972260b50f39d493cc42a78d9648ed668c2aec.1590584789.git.lorenzo.bianconi@redhat.com>
|
|
|
773311 |
From: Han Zhou <hzhou@ovn.org>
|
|
|
773311 |
Date: Tue, 5 May 2020 23:16:09 -0700
|
|
|
773311 |
Subject: [PATCH ovn] ovn-northd: Remove useless flow for GW_REDIRECT.
|
|
|
773311 |
|
|
|
773311 |
Remove the flow in lr_in_gw_redirect stage:
|
|
|
773311 |
|
|
|
773311 |
A priority-150 logical flow with match
|
|
|
773311 |
outport == GW &&
|
|
|
773311 |
eth.dst == 00:00:00:00:00:00 has actions
|
|
|
773311 |
outport = CR; next;, where
|
|
|
773311 |
GW is the logical router distributed gateway
|
|
|
773311 |
port and CR is the chassisredirect
|
|
|
773311 |
port representing the instance of the logical router
|
|
|
773311 |
distributed gateway port on the
|
|
|
773311 |
redirect-chassis.
|
|
|
773311 |
|
|
|
773311 |
The commit c0bf32d ("Manage ARP process locally in a DVR scenario") updated
|
|
|
773311 |
the priority-100 flow in this stage to priority 200, which makes this
|
|
|
773311 |
priority-150 flow useless, because whatever packets matching this flow
|
|
|
773311 |
would also match the priority-50 flow.
|
|
|
773311 |
|
|
|
773311 |
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
|
|
|
773311 |
Tested-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
|
|
|
773311 |
Acked-by: Numan Siddique <numans@ovn.org>
|
|
|
773311 |
Signed-off-by: Han Zhou <hzhou@ovn.org>
|
|
|
773311 |
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
|
|
|
773311 |
---
|
|
|
773311 |
northd/ovn-northd.8.xml | 12 ------------
|
|
|
773311 |
northd/ovn-northd.c | 11 -----------
|
|
|
773311 |
2 files changed, 23 deletions(-)
|
|
|
773311 |
|
|
|
773311 |
--- a/northd/ovn-northd.8.xml
|
|
|
773311 |
+++ b/northd/ovn-northd.8.xml
|
|
|
773311 |
@@ -2909,18 +2909,6 @@ icmp4 {
|
|
|
773311 |
|
|
|
773311 |
|
|
|
773311 |
|
|
|
773311 |
- A priority-150 logical flow with match
|
|
|
773311 |
- outport == GW &&
|
|
|
773311 |
- eth.dst == 00:00:00:00:00:00 has actions
|
|
|
773311 |
- outport = CR; next;, where
|
|
|
773311 |
- GW is the logical router distributed gateway
|
|
|
773311 |
- port and CR is the chassisredirect
|
|
|
773311 |
- port representing the instance of the logical router
|
|
|
773311 |
- distributed gateway port on the
|
|
|
773311 |
- redirect-chassis.
|
|
|
773311 |
-
|
|
|
773311 |
-
|
|
|
773311 |
-
|
|
|
773311 |
For each NAT rule in the OVN Northbound database that can
|
|
|
773311 |
be handled in a distributed manner, a priority-200 logical
|
|
|
773311 |
flow with match ip4.src == B &&
|
|
|
773311 |
--- a/northd/ovn-northd.c
|
|
|
773311 |
+++ b/northd/ovn-northd.c
|
|
|
773311 |
@@ -10143,17 +10143,6 @@ build_lrouter_flows(struct hmap *datapat
|
|
|
773311 |
ovn_lflow_add_with_hint(lflows, od, S_ROUTER_IN_GW_REDIRECT, 50,
|
|
|
773311 |
ds_cstr(&match), ds_cstr(&actions),
|
|
|
773311 |
stage_hint);
|
|
|
773311 |
-
|
|
|
773311 |
- /* If the Ethernet destination has not been resolved,
|
|
|
773311 |
- * redirect to the central instance of the l3dgw_port.
|
|
|
773311 |
- * Such traffic will be replaced by an ARP request or ND
|
|
|
773311 |
- * Neighbor Solicitation in the ARP request ingress
|
|
|
773311 |
- * table, before being redirected to the central instance.
|
|
|
773311 |
- */
|
|
|
773311 |
- ds_put_format(&match, " && eth.dst == 00:00:00:00:00:00");
|
|
|
773311 |
- ovn_lflow_add_with_hint(lflows, od, S_ROUTER_IN_GW_REDIRECT, 150,
|
|
|
773311 |
- ds_cstr(&match), ds_cstr(&actions),
|
|
|
773311 |
- stage_hint);
|
|
|
773311 |
}
|
|
|
773311 |
|
|
|
773311 |
/* Packets are allowed by default. */
|