From ecff4b74dc3f5062d7ca9ffebec408e29d15f402 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Thu, 16 Nov 2017 18:04:42 +0100 Subject: [PATCH 01/10] MdeModulePkg/Bds: Remove assertion in BmCharToUint Message-id: <20171116170443.17088-2-lersek@redhat.com> Patchwork-id: 77727 O-Subject: [RHEL-7.5 ovmf PATCH 1/2] MdeModulePkg/Bds: Remove assertion in BmCharToUint Bugzilla: 1513632 Acked-by: Thomas Huth Acked-by: Marcel Apfelbaum Acked-by: Vitaly Kuznetsov From: Ruiyu Ni BmCharToUint() could be called using external data and it already contains logic to return -1 when data is invalid, so removing unnecessary assertion to avoid system hang. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek Reviewed-by: Star Zeng Acked-by: Ard Biesheuvel (cherry picked from commit 618ef6f9bae14e1543d61993ab7ab8992063e4cc) --- MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c index 11ab867..a3fa254 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c @@ -420,7 +420,6 @@ BmCharToUint ( return (Char - L'A' + 0xA); } - ASSERT (FALSE); return (UINTN) -1; } -- 1.8.3.1