*) Disable code workaround for ancient and obsolete Netscape browsers and servers: an attacker can use it in a ciphersuite downgrade attack. Thanks to Martin Rex for discovering this bug. CVE-2010-4180 diff -up openssl-fips-0.9.8e/doc/ssl/SSL_CTX_set_options.pod.disable-nsbug openssl-fips-0.9.8e/doc/ssl/SSL_CTX_set_options.pod --- openssl-fips-0.9.8e/doc/ssl/SSL_CTX_set_options.pod.disable-nsbug 2010-12-07 17:45:32.000000000 +0100 +++ openssl-fips-0.9.8e/doc/ssl/SSL_CTX_set_options.pod 2010-12-07 17:45:33.000000000 +0100 @@ -78,18 +78,7 @@ this breaks this server so 16 bytes is t =item SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG -ssl3.netscape.com:443, first a connection is established with RC4-MD5. -If it is then resumed, we end up using DES-CBC3-SHA. It should be -RC4-MD5 according to 7.6.1.3, 'cipher_suite'. - -Netscape-Enterprise/2.01 (https://merchant.netscape.com) has this bug. -It only really shows up when connecting via SSLv2/v3 then reconnecting -via SSLv3. The cipher list changes.... - -NEW INFORMATION. Try connecting with a cipher list of just -DES-CBC-SHA:RC4-MD5. For some weird reason, each new connection uses -RC4-MD5, but a re-connect tries to use DES-CBC-SHA. So netscape, when -doing a re-connect, always takes the first cipher in the cipher list. +This option has no effect anymore. =item SSL_OP_SSLREF2_REUSE_CERT_TYPE_BUG diff -up openssl-fips-0.9.8e/ssl/ssl.h.disable-nsbug openssl-fips-0.9.8e/ssl/ssl.h --- openssl-fips-0.9.8e/ssl/ssl.h.disable-nsbug 2010-12-07 17:45:32.000000000 +0100 +++ openssl-fips-0.9.8e/ssl/ssl.h 2010-12-07 17:45:33.000000000 +0100 @@ -482,7 +482,7 @@ typedef struct ssl_session_st #define SSL_OP_NETSCAPE_CHALLENGE_BUG 0x00000002L /* Allow initial connection to servers that don't support RI */ #define SSL_OP_LEGACY_SERVER_CONNECT 0x00000004L -#define SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG 0x00000008L /* can break some security expectations */ +#define SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG 0x00000008L /* no effect anymore */ #define SSL_OP_SSLREF2_REUSE_CERT_TYPE_BUG 0x00000010L #define SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER 0x00000020L #define SSL_OP_MSIE_SSLV2_RSA_PADDING 0x00000040L /* no effect since 0.9.7h and 0.9.8b */ diff -up openssl-fips-0.9.8e/ssl/s3_clnt.c.disable-nsbug openssl-fips-0.9.8e/ssl/s3_clnt.c --- openssl-fips-0.9.8e/ssl/s3_clnt.c.disable-nsbug 2010-12-07 17:45:32.000000000 +0100 +++ openssl-fips-0.9.8e/ssl/s3_clnt.c 2010-12-07 17:45:33.000000000 +0100 @@ -752,8 +752,11 @@ int ssl3_get_server_hello(SSL *s) s->session->cipher_id = s->session->cipher->id; if (s->hit && (s->session->cipher_id != c->id)) { +/* Workaround is now obsolete */ +#if 0 if (!(s->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG)) +#endif { al=SSL_AD_ILLEGAL_PARAMETER; SSLerr(SSL_F_SSL3_GET_SERVER_HELLO,SSL_R_OLD_SESSION_CIPHER_NOT_RETURNED); diff -up openssl-fips-0.9.8e/ssl/s3_srvr.c.disable-nsbug openssl-fips-0.9.8e/ssl/s3_srvr.c --- openssl-fips-0.9.8e/ssl/s3_srvr.c.disable-nsbug 2010-12-07 17:46:11.000000000 +0100 +++ openssl-fips-0.9.8e/ssl/s3_srvr.c 2010-12-07 17:46:15.000000000 +0100 @@ -870,12 +870,14 @@ int ssl3_get_client_hello(SSL *s) } if (j == 0) { +#if 0 if ((s->options & SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG) && (sk_SSL_CIPHER_num(ciphers) == 1)) { /* Very bad for multi-threading.... */ s->session->cipher=sk_SSL_CIPHER_value(ciphers, 0); } else +#endif { /* we need to have the cipher in the cipher * list if we are asked to reuse it */