Blame SOURCES/0004-main.c-Remove-NO_EFFECT-code.patch
|
 |
fdfb48 |
From bd289653605c39555cf8deb96b6093ec07b8b0dd Mon Sep 17 00:00:00 2001
|
|
|
fdfb48 |
From: Honggang Li <honli@redhat.com>
|
|
|
fdfb48 |
Date: Tue, 22 Jan 2019 11:06:30 +0800
|
|
|
fdfb48 |
Subject: [PATCH 4/5] main.c: Remove NO_EFFECT code
|
|
|
fdfb48 |
|
|
|
fdfb48 |
Issue was found by Coverity.
|
|
|
fdfb48 |
|
|
|
fdfb48 |
opensm-3.3.21/opensm/main.c:1165: unsigned_compare: This less-than-zero comparison of an unsigned value is never true. "temp < 0U".
|
|
|
fdfb48 |
// 1163| case 15:
|
|
|
fdfb48 |
// 1164| temp = strtoul(optarg, NULL, 0);
|
|
|
fdfb48 |
// 1165|-> if (temp < 0 || temp >= IB_MAX_NUM_VLS) {
|
|
|
fdfb48 |
// 1166| fprintf(stderr,
|
|
|
fdfb48 |
// 1167| "ERROR: maximum #VLs for nue routing must be between 0
|
|
|
fdfb48 |
|
|
|
fdfb48 |
Signed-off-by: Honggang Li <honli@redhat.com>
|
|
|
fdfb48 |
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
|
|
|
fdfb48 |
Signed-off-by: Honggang Li <honli@redhat.com>
|
|
|
fdfb48 |
---
|
|
|
fdfb48 |
opensm/main.c | 2 +-
|
|
|
fdfb48 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
fdfb48 |
|
|
|
fdfb48 |
diff --git a/opensm/main.c b/opensm/main.c
|
|
|
fdfb48 |
index 56bf7d5c588a..9932cd667378 100644
|
|
|
fdfb48 |
--- a/opensm/main.c
|
|
|
fdfb48 |
+++ b/opensm/main.c
|
|
|
fdfb48 |
@@ -1165,7 +1165,7 @@ int main(int argc, char *argv[])
|
|
|
fdfb48 |
break;
|
|
|
fdfb48 |
case 15:
|
|
|
fdfb48 |
temp = strtoul(optarg, NULL, 0);
|
|
|
fdfb48 |
- if (temp < 0 || temp >= IB_MAX_NUM_VLS) {
|
|
|
fdfb48 |
+ if (temp >= IB_MAX_NUM_VLS) {
|
|
|
fdfb48 |
fprintf(stderr,
|
|
|
fdfb48 |
"ERROR: maximum #VLs for nue routing must be between 0 and %d\n",
|
|
|
fdfb48 |
IB_MAX_NUM_VLS);
|
|
|
fdfb48 |
--
|
|
|
fdfb48 |
2.15.0-rc1
|
|
|
fdfb48 |
|