|
 |
fdfb48 |
From 2b9cf6fe72592379e4be1f2129c8031f0c2b5273 Mon Sep 17 00:00:00 2001
|
|
|
fdfb48 |
From: Honggang Li <honli@redhat.com>
|
|
|
fdfb48 |
Date: Fri, 12 Oct 2018 19:54:56 +0800
|
|
|
fdfb48 |
Subject: [PATCH] Use precision specifier for scanf
|
|
|
fdfb48 |
|
|
|
fdfb48 |
If user input a string larger than the length of buffer, the stack memory
|
|
|
fdfb48 |
will be corrupted.
|
|
|
fdfb48 |
|
|
|
fdfb48 |
Signed-off-by: Honggang Li <honli@redhat.com>
|
|
|
fdfb48 |
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
|
|
|
fdfb48 |
---
|
|
|
fdfb48 |
opensm/main.c | 2 +-
|
|
|
fdfb48 |
osmtest/osmtest.c | 2 +-
|
|
|
fdfb48 |
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
fdfb48 |
|
|
|
fdfb48 |
diff --git a/opensm/main.c b/opensm/main.c
|
|
|
fdfb48 |
index 2d23fe2befef..8def799cea0f 100644
|
|
|
fdfb48 |
--- a/opensm/main.c
|
|
|
fdfb48 |
+++ b/opensm/main.c
|
|
|
fdfb48 |
@@ -499,7 +499,7 @@ static ib_net64_t get_port_guid(IN osm_opensm_t * p_osm, uint64_t port_guid)
|
|
|
fdfb48 |
fflush(stdout);
|
|
|
fdfb48 |
if (scanf("%u", &choice) <= 0) {
|
|
|
fdfb48 |
char junk[128];
|
|
|
fdfb48 |
- if (scanf("%s", junk) <= 0)
|
|
|
fdfb48 |
+ if (scanf("%127s", junk) <= 0)
|
|
|
fdfb48 |
printf("\nError: Cannot scan!\n");
|
|
|
fdfb48 |
} else if (choice == 0)
|
|
|
fdfb48 |
return 0;
|
|
|
fdfb48 |
diff --git a/osmtest/osmtest.c b/osmtest/osmtest.c
|
|
|
fdfb48 |
index 281b247a2e69..fa2e0704b8cc 100644
|
|
|
fdfb48 |
--- a/osmtest/osmtest.c
|
|
|
fdfb48 |
+++ b/osmtest/osmtest.c
|
|
|
fdfb48 |
@@ -7352,7 +7352,7 @@ osmtest_get_user_port(IN osmtest_t * const p_osmt,
|
|
|
fdfb48 |
fflush(stdout);
|
|
|
fdfb48 |
if (scanf("%u", &choice) <= 0) {
|
|
|
fdfb48 |
char junk[256];
|
|
|
fdfb48 |
- if (scanf("%s", junk) <= 0)
|
|
|
fdfb48 |
+ if (scanf("%255s", junk) <= 0)
|
|
|
fdfb48 |
printf("\nError: Cannot scan!\n");
|
|
|
fdfb48 |
} else if (choice && choice <= num_ports)
|
|
|
fdfb48 |
break;
|
|
|
fdfb48 |
--
|
|
|
fdfb48 |
2.15.0-rc1
|
|
|
fdfb48 |
|