Honggang Li c03243
From 266189935aef4fce825d0db831b4b53accc62c32 Mon Sep 17 00:00:00 2001
Honggang Li c03243
From: Jeff Squyres <jsquyres@cisco.com>
Honggang Li c03243
Date: Tue, 22 Jun 2021 22:28:37 -0400
Honggang Li c03243
Subject: [PATCH] fbtl-posix: link to common_ompio
Honggang Li c03243
Honggang Li c03243
The posix fbtl calls mca_common_ompio_progress(), which resides in
Honggang Li c03243
common/ompio (i.e., libmca_common_ompio.la).  So add that into
Honggang Li c03243
mca_fbtl_posix_la_LIBADD (like we do in a few other OMPIO-based
Honggang Li c03243
components).  Failure to do this *can* lead to the posix fbtl
Honggang Li c03243
component failing to load (depending on whether other OMPIO-based
Honggang Li c03243
components that pull in libmca_common_ompio were loaded first).
Honggang Li c03243
Honggang Li c03243
Thanks to Honggang Li for raising the issue.
Honggang Li c03243
Honggang Li c03243
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Honggang Li c03243
---
Honggang Li c03243
 ompi/mca/fbtl/posix/Makefile.am | 3 ++-
Honggang Li c03243
 1 file changed, 2 insertions(+), 1 deletion(-)
Honggang Li c03243
Honggang Li c03243
diff --git a/ompi/mca/fbtl/posix/Makefile.am b/ompi/mca/fbtl/posix/Makefile.am
Honggang Li c03243
index a7b0624d3ec..1ce19cb09b7 100644
Honggang Li c03243
--- a/ompi/mca/fbtl/posix/Makefile.am
Honggang Li c03243
+++ b/ompi/mca/fbtl/posix/Makefile.am
Honggang Li c03243
@@ -34,7 +34,8 @@ mcacomponentdir = $(ompilibdir)
Honggang Li c03243
 mcacomponent_LTLIBRARIES = $(component_install)
Honggang Li c03243
 mca_fbtl_posix_la_SOURCES = $(sources)
Honggang Li c03243
 mca_fbtl_posix_la_LDFLAGS = -module -avoid-version
Honggang Li c03243
-mca_fbtl_posix_la_LIBADD = $(top_builddir)/ompi/lib@OMPI_LIBMPI_NAME@.la
Honggang Li c03243
+mca_fbtl_posix_la_LIBADD = $(top_builddir)/ompi/lib@OMPI_LIBMPI_NAME@.la \
Honggang Li c03243
+    $(OMPI_TOP_BUILDDIR)/ompi/mca/common/ompio/libmca_common_ompio.la
Honggang Li c03243
 
Honggang Li c03243
 noinst_LTLIBRARIES = $(component_noinst)
Honggang Li c03243
 libmca_fbtl_posix_la_SOURCES = $(sources)