|
 |
da6d28 |
From 310151f10e024a565c13a2300fbfbd090c40be3d Mon Sep 17 00:00:00 2001
|
|
|
da6d28 |
From: Even Rouault <even.rouault@spatialys.com>
|
|
|
da6d28 |
Date: Thu, 30 Jan 2020 00:59:57 +0100
|
|
|
da6d28 |
Subject: [PATCH] opj_tcd_init_tile(): avoid integer overflow
|
|
|
da6d28 |
|
|
|
da6d28 |
That could lead to later assertion failures.
|
|
|
da6d28 |
|
|
|
da6d28 |
Fixes #1231 / CVE-2020-8112
|
|
|
da6d28 |
---
|
|
|
da6d28 |
src/lib/openjp2/tcd.c | 20 ++++++++++++++++++--
|
|
|
da6d28 |
1 file changed, 18 insertions(+), 2 deletions(-)
|
|
|
da6d28 |
|
|
|
da6d28 |
diff --git a/src/lib/openjp2/tcd.c b/src/lib/openjp2/tcd.c
|
|
|
da6d28 |
index be3b843..647991c 100644
|
|
|
da6d28 |
--- a/src/lib/openjp2/tcd.c
|
|
|
da6d28 |
+++ b/src/lib/openjp2/tcd.c
|
|
|
da6d28 |
@@ -905,8 +905,24 @@ static INLINE OPJ_BOOL opj_tcd_init_tile(opj_tcd_t *p_tcd, OPJ_UINT32 p_tile_no,
|
|
|
da6d28 |
/* p. 64, B.6, ISO/IEC FDIS15444-1 : 2000 (18 august 2000) */
|
|
|
da6d28 |
l_tl_prc_x_start = opj_int_floordivpow2(l_res->x0, (OPJ_INT32)l_pdx) << l_pdx;
|
|
|
da6d28 |
l_tl_prc_y_start = opj_int_floordivpow2(l_res->y0, (OPJ_INT32)l_pdy) << l_pdy;
|
|
|
da6d28 |
- l_br_prc_x_end = opj_int_ceildivpow2(l_res->x1, (OPJ_INT32)l_pdx) << l_pdx;
|
|
|
da6d28 |
- l_br_prc_y_end = opj_int_ceildivpow2(l_res->y1, (OPJ_INT32)l_pdy) << l_pdy;
|
|
|
da6d28 |
+ {
|
|
|
da6d28 |
+ OPJ_UINT32 tmp = ((OPJ_UINT32)opj_int_ceildivpow2(l_res->x1,
|
|
|
da6d28 |
+ (OPJ_INT32)l_pdx)) << l_pdx;
|
|
|
da6d28 |
+ if (tmp > (OPJ_UINT32)INT_MAX) {
|
|
|
da6d28 |
+ opj_event_msg(manager, EVT_ERROR, "Integer overflow\n");
|
|
|
da6d28 |
+ return OPJ_FALSE;
|
|
|
da6d28 |
+ }
|
|
|
da6d28 |
+ l_br_prc_x_end = (OPJ_INT32)tmp;
|
|
|
da6d28 |
+ }
|
|
|
da6d28 |
+ {
|
|
|
da6d28 |
+ OPJ_UINT32 tmp = ((OPJ_UINT32)opj_int_ceildivpow2(l_res->y1,
|
|
|
da6d28 |
+ (OPJ_INT32)l_pdy)) << l_pdy;
|
|
|
da6d28 |
+ if (tmp > (OPJ_UINT32)INT_MAX) {
|
|
|
da6d28 |
+ opj_event_msg(manager, EVT_ERROR, "Integer overflow\n");
|
|
|
da6d28 |
+ return OPJ_FALSE;
|
|
|
da6d28 |
+ }
|
|
|
da6d28 |
+ l_br_prc_y_end = (OPJ_INT32)tmp;
|
|
|
da6d28 |
+ }
|
|
|
da6d28 |
/*fprintf(stderr, "\t\t\tprc_x_start=%d, prc_y_start=%d, br_prc_x_end=%d, br_prc_y_end=%d \n", l_tl_prc_x_start, l_tl_prc_y_start, l_br_prc_x_end ,l_br_prc_y_end );*/
|
|
|
da6d28 |
|
|
|
da6d28 |
l_res->pw = (l_res->x0 == l_res->x1) ? 0U : (OPJ_UINT32)((
|
|
|
da6d28 |
--
|
|
|
da6d28 |
2.21.1
|
|
|
da6d28 |
|