|
 |
253609 |
From 76307be97a42f5a743e7cf0ef75a87dac0c0106f Mon Sep 17 00:00:00 2001
|
|
|
253609 |
From: Ingo Franzki <ifranzki@linux.ibm.com>
|
|
|
253609 |
Date: Wed, 16 Feb 2022 13:04:24 +0100
|
|
|
253609 |
Subject: [PATCH 19/34] COMMON: Dilithium key BER encoding/decoding allow
|
|
|
253609 |
different OIDs
|
|
|
253609 |
|
|
|
253609 |
Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
|
|
|
253609 |
---
|
|
|
253609 |
usr/lib/cca_stdll/cca_stdll.mk | 2 +-
|
|
|
253609 |
usr/lib/common/asn1.c | 143 ++++++++++++++++++++-----------
|
|
|
253609 |
usr/lib/common/globals.c | 8 +-
|
|
|
253609 |
usr/lib/common/h_extern.h | 54 ++++++------
|
|
|
253609 |
usr/lib/common/key.c | 10 ++-
|
|
|
253609 |
usr/lib/common/key_mgr.c | 13 ++-
|
|
|
253609 |
usr/lib/ep11_stdll/ep11_specific.c | 6 +-
|
|
|
253609 |
usr/lib/ep11_stdll/ep11_stdll.mk | 3 +-
|
|
|
253609 |
usr/lib/ica_s390_stdll/ica_s390_stdll.mk | 2 +-
|
|
|
253609 |
usr/lib/icsf_stdll/icsf_stdll.mk | 2 +-
|
|
|
253609 |
usr/lib/soft_stdll/soft_stdll.mk | 2 +-
|
|
|
253609 |
usr/lib/tpm_stdll/tpm_stdll.mk | 2 +-
|
|
|
253609 |
usr/sbin/pkcscca/pkcscca.mk | 2 +-
|
|
|
253609 |
13 files changed, 152 insertions(+), 97 deletions(-)
|
|
|
253609 |
|
|
|
253609 |
diff --git a/usr/lib/cca_stdll/cca_stdll.mk b/usr/lib/cca_stdll/cca_stdll.mk
|
|
|
253609 |
index 9b71085a..5963df59 100644
|
|
|
253609 |
--- a/usr/lib/cca_stdll/cca_stdll.mk
|
|
|
253609 |
+++ b/usr/lib/cca_stdll/cca_stdll.mk
|
|
|
253609 |
@@ -41,7 +41,7 @@ opencryptoki_stdll_libpkcs11_cca_la_SOURCES = usr/lib/common/asn1.c \
|
|
|
253609 |
usr/lib/common/utility_common.c usr/lib/common/ec_supported.c \
|
|
|
253609 |
usr/lib/api/policyhelper.c usr/lib/config/configuration.c \
|
|
|
253609 |
usr/lib/config/cfgparse.y usr/lib/config/cfglex.l \
|
|
|
253609 |
- usr/lib/common/mech_openssl.c
|
|
|
253609 |
+ usr/lib/common/mech_openssl.c usr/lib/common/pqc_supported.c
|
|
|
253609 |
|
|
|
253609 |
if ENABLE_LOCKS
|
|
|
253609 |
opencryptoki_stdll_libpkcs11_cca_la_SOURCES += \
|
|
|
253609 |
diff --git a/usr/lib/common/asn1.c b/usr/lib/common/asn1.c
|
|
|
253609 |
index b3f49c41..884ef489 100644
|
|
|
253609 |
--- a/usr/lib/common/asn1.c
|
|
|
253609 |
+++ b/usr/lib/common/asn1.c
|
|
|
253609 |
@@ -24,6 +24,7 @@
|
|
|
253609 |
#include "host_defs.h"
|
|
|
253609 |
#include "h_extern.h"
|
|
|
253609 |
#include "trace.h"
|
|
|
253609 |
+#include "pqc_defs.h"
|
|
|
253609 |
|
|
|
253609 |
|
|
|
253609 |
//
|
|
|
253609 |
@@ -3616,7 +3617,7 @@ cleanup:
|
|
|
253609 |
*
|
|
|
253609 |
* SEQUENCE (2 elem)
|
|
|
253609 |
* SEQUENCE (2 elem)
|
|
|
253609 |
- * OBJECT IDENTIFIER 1.3.6.1.4.1.2.267.1.6.5
|
|
|
253609 |
+ * OBJECT IDENTIFIER 1.3.6.1.4.1.2.267.xxx
|
|
|
253609 |
* NULL
|
|
|
253609 |
* BIT STRING (1 elem)
|
|
|
253609 |
* SEQUENCE (2 elem)
|
|
|
253609 |
@@ -3624,20 +3625,26 @@ cleanup:
|
|
|
253609 |
* BIT STRING (13824 bit) = 1728 bytes
|
|
|
253609 |
*/
|
|
|
253609 |
CK_RV ber_encode_IBM_DilithiumPublicKey(CK_BBOOL length_only,
|
|
|
253609 |
- CK_BYTE **data, CK_ULONG *data_len,
|
|
|
253609 |
- CK_ATTRIBUTE *rho, CK_ATTRIBUTE *t1)
|
|
|
253609 |
+ CK_BYTE **data, CK_ULONG *data_len,
|
|
|
253609 |
+ const CK_BYTE *oid, CK_ULONG oid_len,
|
|
|
253609 |
+ CK_ATTRIBUTE *rho, CK_ATTRIBUTE *t1)
|
|
|
253609 |
{
|
|
|
253609 |
CK_BYTE *buf = NULL, *buf2 = NULL, *buf3 = NULL, *buf4 = NULL;
|
|
|
253609 |
- CK_ULONG len = 0, len4, offset, total, total_len;
|
|
|
253609 |
+ CK_BYTE *buf5 = NULL, *algid = NULL;
|
|
|
253609 |
+ CK_ULONG len = 0, len4, offset, total, total_len, algid_len;
|
|
|
253609 |
CK_RV rc;
|
|
|
253609 |
|
|
|
253609 |
UNUSED(length_only);
|
|
|
253609 |
|
|
|
253609 |
offset = 0;
|
|
|
253609 |
rc = 0;
|
|
|
253609 |
- total_len = ber_AlgIdDilithiumLen;
|
|
|
253609 |
+ total_len = 0;
|
|
|
253609 |
total = 0;
|
|
|
253609 |
|
|
|
253609 |
+ /* Calculate storage for AlgID sequence */
|
|
|
253609 |
+ rc |= ber_encode_SEQUENCE(TRUE, NULL, &total_len, NULL,
|
|
|
253609 |
+ oid_len + ber_NULLLen);
|
|
|
253609 |
+
|
|
|
253609 |
/* Calculate storage for inner sequence */
|
|
|
253609 |
rc |= ber_encode_INTEGER(TRUE, NULL, &len, NULL, rho->ulValueLen);
|
|
|
253609 |
offset += len;
|
|
|
253609 |
@@ -3709,12 +3716,30 @@ CK_RV ber_encode_IBM_DilithiumPublicKey(CK_BBOOL length_only,
|
|
|
253609 |
|
|
|
253609 |
/*
|
|
|
253609 |
* SEQUENCE (2 elem)
|
|
|
253609 |
- * OBJECT IDENTIFIER 1.3.6.1.4.1.2.267.1.6.5
|
|
|
253609 |
+ * OBJECT IDENTIFIER 1.3.6.1.4.1.2.267.xxx
|
|
|
253609 |
* NULL <- no parms for this oid
|
|
|
253609 |
*/
|
|
|
253609 |
- total_len = 0;
|
|
|
253609 |
- memcpy(buf3 + total_len, ber_AlgIdDilithium, ber_AlgIdDilithiumLen);
|
|
|
253609 |
- total_len += ber_AlgIdDilithiumLen;
|
|
|
253609 |
+ buf5 = (CK_BYTE *) malloc(oid_len + ber_NULLLen);
|
|
|
253609 |
+ if (!buf5) {
|
|
|
253609 |
+ TRACE_ERROR("%s Memory allocation failed\n", __func__);
|
|
|
253609 |
+ rc = CKR_HOST_MEMORY;
|
|
|
253609 |
+ goto error;
|
|
|
253609 |
+ }
|
|
|
253609 |
+ memcpy(buf5, oid, oid_len);
|
|
|
253609 |
+ memcpy(buf5 + oid_len, ber_NULL, ber_NULLLen);
|
|
|
253609 |
+
|
|
|
253609 |
+ rc = ber_encode_SEQUENCE(FALSE, &algid, &algid_len, buf5,
|
|
|
253609 |
+ oid_len + ber_NULLLen);
|
|
|
253609 |
+ free(buf5);
|
|
|
253609 |
+ if (rc != CKR_OK) {
|
|
|
253609 |
+ TRACE_ERROR("%s ber_encode_SEQUENCE failed with rc=0x%lx\n", __func__, rc);
|
|
|
253609 |
+ goto error;
|
|
|
253609 |
+ }
|
|
|
253609 |
+
|
|
|
253609 |
+ total_len = algid_len;
|
|
|
253609 |
+ memcpy(buf3, algid, algid_len);
|
|
|
253609 |
+ free(algid);
|
|
|
253609 |
+ algid = NULL;
|
|
|
253609 |
|
|
|
253609 |
/*
|
|
|
253609 |
* BIT STRING (1 elem)
|
|
|
253609 |
@@ -3760,16 +3785,15 @@ error:
|
|
|
253609 |
|
|
|
253609 |
|
|
|
253609 |
CK_RV ber_decode_IBM_DilithiumPublicKey(CK_BYTE *data,
|
|
|
253609 |
- CK_ULONG data_len,
|
|
|
253609 |
- CK_ATTRIBUTE **rho_attr,
|
|
|
253609 |
- CK_ATTRIBUTE **t1_attr)
|
|
|
253609 |
+ CK_ULONG data_len,
|
|
|
253609 |
+ CK_ATTRIBUTE **rho_attr,
|
|
|
253609 |
+ CK_ATTRIBUTE **t1_attr)
|
|
|
253609 |
{
|
|
|
253609 |
CK_ATTRIBUTE *rho_attr_temp = NULL;
|
|
|
253609 |
CK_ATTRIBUTE *t1_attr_temp = NULL;
|
|
|
253609 |
|
|
|
253609 |
- CK_BYTE *algid_DilithiumBase = NULL;
|
|
|
253609 |
- CK_BYTE *algid = NULL;
|
|
|
253609 |
- CK_ULONG algid_len;
|
|
|
253609 |
+ CK_BYTE *algoid = NULL;
|
|
|
253609 |
+ CK_ULONG algoid_len;
|
|
|
253609 |
CK_BYTE *param = NULL;
|
|
|
253609 |
CK_ULONG param_len;
|
|
|
253609 |
CK_BYTE *val = NULL;
|
|
|
253609 |
@@ -3780,26 +3804,20 @@ CK_RV ber_decode_IBM_DilithiumPublicKey(CK_BYTE *data,
|
|
|
253609 |
CK_ULONG rho_len;
|
|
|
253609 |
CK_BYTE *t1;
|
|
|
253609 |
CK_ULONG t1_len;
|
|
|
253609 |
- CK_ULONG field_len, offset, len;
|
|
|
253609 |
+ CK_ULONG field_len, offset;
|
|
|
253609 |
CK_RV rc;
|
|
|
253609 |
|
|
|
253609 |
UNUSED(data_len); // XXX can this parameter be removed ?
|
|
|
253609 |
|
|
|
253609 |
- rc = ber_decode_SPKI(data, &algid, &algid_len, ¶m, ¶m_len,
|
|
|
253609 |
+ rc = ber_decode_SPKI(data, &algoid, &algoid_len, ¶m, ¶m_len,
|
|
|
253609 |
&val, &val_len);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_DEVEL("ber_decode_SPKI failed\n");
|
|
|
253609 |
return rc;
|
|
|
253609 |
}
|
|
|
253609 |
|
|
|
253609 |
- /* Make sure we're dealing with a Dilithium key */
|
|
|
253609 |
- rc = ber_decode_SEQUENCE((CK_BYTE *)ber_AlgIdDilithium, &algid_DilithiumBase, &len,
|
|
|
253609 |
- &field_len);
|
|
|
253609 |
- if (rc != CKR_OK) {
|
|
|
253609 |
- TRACE_DEVEL("ber_decode_SEQUENCE failed\n");
|
|
|
253609 |
- return rc;
|
|
|
253609 |
- }
|
|
|
253609 |
- if (memcmp(algid, algid_DilithiumBase, len) != 0) {
|
|
|
253609 |
+ if (algoid_len != dilithium_r2_65_len ||
|
|
|
253609 |
+ memcmp(algoid, dilithium_r2_65, dilithium_r2_65_len) != 0) {
|
|
|
253609 |
TRACE_ERROR("%s\n", ock_err(ERR_FUNCTION_FAILED));
|
|
|
253609 |
return CKR_FUNCTION_FAILED;
|
|
|
253609 |
}
|
|
|
253609 |
@@ -3879,18 +3897,20 @@ cleanup:
|
|
|
253609 |
* }
|
|
|
253609 |
*/
|
|
|
253609 |
CK_RV ber_encode_IBM_DilithiumPrivateKey(CK_BBOOL length_only,
|
|
|
253609 |
- CK_BYTE **data,
|
|
|
253609 |
- CK_ULONG *data_len,
|
|
|
253609 |
- CK_ATTRIBUTE *rho,
|
|
|
253609 |
- CK_ATTRIBUTE *seed,
|
|
|
253609 |
- CK_ATTRIBUTE *tr,
|
|
|
253609 |
- CK_ATTRIBUTE *s1,
|
|
|
253609 |
- CK_ATTRIBUTE *s2,
|
|
|
253609 |
- CK_ATTRIBUTE *t0,
|
|
|
253609 |
- CK_ATTRIBUTE *t1)
|
|
|
253609 |
+ CK_BYTE **data,
|
|
|
253609 |
+ CK_ULONG *data_len,
|
|
|
253609 |
+ const CK_BYTE *oid, CK_ULONG oid_len,
|
|
|
253609 |
+ CK_ATTRIBUTE *rho,
|
|
|
253609 |
+ CK_ATTRIBUTE *seed,
|
|
|
253609 |
+ CK_ATTRIBUTE *tr,
|
|
|
253609 |
+ CK_ATTRIBUTE *s1,
|
|
|
253609 |
+ CK_ATTRIBUTE *s2,
|
|
|
253609 |
+ CK_ATTRIBUTE *t0,
|
|
|
253609 |
+ CK_ATTRIBUTE *t1)
|
|
|
253609 |
{
|
|
|
253609 |
CK_BYTE *buf = NULL, *buf2 = NULL, *buf3 = NULL;
|
|
|
253609 |
- CK_ULONG len, len2 = 0, offset;
|
|
|
253609 |
+ CK_BYTE *algid = NULL, *algid_buf = NULL;
|
|
|
253609 |
+ CK_ULONG len, len2 = 0, offset, algid_len = 0;
|
|
|
253609 |
CK_BYTE version[] = { 0 };
|
|
|
253609 |
CK_RV rc;
|
|
|
253609 |
|
|
|
253609 |
@@ -3898,6 +3918,9 @@ CK_RV ber_encode_IBM_DilithiumPrivateKey(CK_BBOOL length_only,
|
|
|
253609 |
offset = 0;
|
|
|
253609 |
rc = 0;
|
|
|
253609 |
|
|
|
253609 |
+ rc |= ber_encode_SEQUENCE(TRUE, NULL, &algid_len, NULL,
|
|
|
253609 |
+ oid_len + ber_NULLLen);
|
|
|
253609 |
+
|
|
|
253609 |
rc |= ber_encode_INTEGER(TRUE, NULL, &len, NULL, sizeof(version));
|
|
|
253609 |
offset += len;
|
|
|
253609 |
rc |= ber_encode_BIT_STRING(TRUE, NULL, &len, NULL, rho->ulValueLen, 0);
|
|
|
253609 |
@@ -3931,7 +3954,7 @@ CK_RV ber_encode_IBM_DilithiumPrivateKey(CK_BBOOL length_only,
|
|
|
253609 |
}
|
|
|
253609 |
rc = ber_encode_PrivateKeyInfo(TRUE,
|
|
|
253609 |
NULL, data_len,
|
|
|
253609 |
- NULL, ber_AlgIdDilithiumLen,
|
|
|
253609 |
+ NULL, algid_len,
|
|
|
253609 |
NULL, len);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_DEVEL("ber_encode_PrivateKeyInfo failed\n");
|
|
|
253609 |
@@ -4051,10 +4074,28 @@ CK_RV ber_encode_IBM_DilithiumPrivateKey(CK_BBOOL length_only,
|
|
|
253609 |
TRACE_ERROR("ber_encode_SEQUENCE failed\n");
|
|
|
253609 |
goto error;
|
|
|
253609 |
}
|
|
|
253609 |
+
|
|
|
253609 |
+ algid_buf = (CK_BYTE *) malloc(oid_len + ber_NULLLen);
|
|
|
253609 |
+ if (!algid_buf) {
|
|
|
253609 |
+ TRACE_ERROR("%s Memory allocation failed\n", __func__);
|
|
|
253609 |
+ rc = CKR_HOST_MEMORY;
|
|
|
253609 |
+ goto error;
|
|
|
253609 |
+ }
|
|
|
253609 |
+ memcpy(algid_buf, oid, oid_len);
|
|
|
253609 |
+ memcpy(algid_buf + oid_len, ber_NULL, ber_NULLLen);
|
|
|
253609 |
+
|
|
|
253609 |
+ rc = ber_encode_SEQUENCE(FALSE, &algid, &algid_len, algid_buf,
|
|
|
253609 |
+ oid_len + ber_NULLLen);
|
|
|
253609 |
+ free(algid_buf);
|
|
|
253609 |
+ if (rc != CKR_OK) {
|
|
|
253609 |
+ TRACE_ERROR("%s ber_encode_SEQUENCE failed with rc=0x%lx\n", __func__, rc);
|
|
|
253609 |
+ goto error;
|
|
|
253609 |
+ }
|
|
|
253609 |
+
|
|
|
253609 |
rc = ber_encode_PrivateKeyInfo(FALSE,
|
|
|
253609 |
data, data_len,
|
|
|
253609 |
- ber_AlgIdDilithium,
|
|
|
253609 |
- ber_AlgIdDilithiumLen, buf2, len);
|
|
|
253609 |
+ algid, algid_len,
|
|
|
253609 |
+ buf2, len);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_ERROR("ber_encode_PrivateKeyInfo failed\n");
|
|
|
253609 |
}
|
|
|
253609 |
@@ -4066,6 +4107,8 @@ error:
|
|
|
253609 |
free(buf2);
|
|
|
253609 |
if (buf)
|
|
|
253609 |
free(buf);
|
|
|
253609 |
+ if (algid)
|
|
|
253609 |
+ free(algid);
|
|
|
253609 |
|
|
|
253609 |
return rc;
|
|
|
253609 |
}
|
|
|
253609 |
@@ -4087,19 +4130,19 @@ error:
|
|
|
253609 |
* }
|
|
|
253609 |
*/
|
|
|
253609 |
CK_RV ber_decode_IBM_DilithiumPrivateKey(CK_BYTE *data,
|
|
|
253609 |
- CK_ULONG data_len,
|
|
|
253609 |
- CK_ATTRIBUTE **rho,
|
|
|
253609 |
- CK_ATTRIBUTE **seed,
|
|
|
253609 |
- CK_ATTRIBUTE **tr,
|
|
|
253609 |
- CK_ATTRIBUTE **s1,
|
|
|
253609 |
- CK_ATTRIBUTE **s2,
|
|
|
253609 |
- CK_ATTRIBUTE **t0,
|
|
|
253609 |
- CK_ATTRIBUTE **t1)
|
|
|
253609 |
+ CK_ULONG data_len,
|
|
|
253609 |
+ CK_ATTRIBUTE **rho,
|
|
|
253609 |
+ CK_ATTRIBUTE **seed,
|
|
|
253609 |
+ CK_ATTRIBUTE **tr,
|
|
|
253609 |
+ CK_ATTRIBUTE **s1,
|
|
|
253609 |
+ CK_ATTRIBUTE **s2,
|
|
|
253609 |
+ CK_ATTRIBUTE **t0,
|
|
|
253609 |
+ CK_ATTRIBUTE **t1)
|
|
|
253609 |
{
|
|
|
253609 |
CK_ATTRIBUTE *rho_attr = NULL, *seed_attr = NULL;
|
|
|
253609 |
CK_ATTRIBUTE *tr_attr = NULL, *s1_attr = NULL, *s2_attr = NULL;
|
|
|
253609 |
CK_ATTRIBUTE *t0_attr = NULL, *t1_attr = NULL;
|
|
|
253609 |
- CK_BYTE *alg = NULL;
|
|
|
253609 |
+ CK_BYTE *algoid = NULL;
|
|
|
253609 |
CK_BYTE *dilithium_priv_key = NULL;
|
|
|
253609 |
CK_BYTE *buf = NULL;
|
|
|
253609 |
CK_BYTE *tmp = NULL;
|
|
|
253609 |
@@ -4107,15 +4150,15 @@ CK_RV ber_decode_IBM_DilithiumPrivateKey(CK_BYTE *data,
|
|
|
253609 |
CK_RV rc;
|
|
|
253609 |
|
|
|
253609 |
/* Check if this is a Dilithium private key */
|
|
|
253609 |
- rc = ber_decode_PrivateKeyInfo(data, data_len, &alg, &len,
|
|
|
253609 |
+ rc = ber_decode_PrivateKeyInfo(data, data_len, &algoid, &len,
|
|
|
253609 |
&dilithium_priv_key);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_DEVEL("ber_decode_PrivateKeyInfo failed\n");
|
|
|
253609 |
return rc;
|
|
|
253609 |
}
|
|
|
253609 |
|
|
|
253609 |
- if (memcmp(alg, ber_AlgIdDilithium, ber_AlgIdDilithiumLen) != 0) {
|
|
|
253609 |
- // probably ought to use a different error
|
|
|
253609 |
+ if (len != dilithium_r2_65_len + ber_NULLLen ||
|
|
|
253609 |
+ memcmp(algoid, dilithium_r2_65, dilithium_r2_65_len) != 0) {
|
|
|
253609 |
TRACE_ERROR("%s\n", ock_err(ERR_FUNCTION_FAILED));
|
|
|
253609 |
return CKR_FUNCTION_FAILED;
|
|
|
253609 |
}
|
|
|
253609 |
diff --git a/usr/lib/common/globals.c b/usr/lib/common/globals.c
|
|
|
253609 |
index 5b79e785..a7197ec6 100644
|
|
|
253609 |
--- a/usr/lib/common/globals.c
|
|
|
253609 |
+++ b/usr/lib/common/globals.c
|
|
|
253609 |
@@ -105,11 +105,7 @@ const CK_BYTE ber_AlgIdRSAEncryption[] = {
|
|
|
253609 |
const CK_BYTE der_AlgIdECBase[] =
|
|
|
253609 |
{ 0x30, 0x09, 0x06, 0x07, 0x2A, 0x86, 0x48, 0xCE, 0x3D, 0x02, 0x01 };
|
|
|
253609 |
|
|
|
253609 |
-const CK_BYTE ber_AlgIdDilithium[] =
|
|
|
253609 |
- { 0x30, 0x0F, 0x06, 0x0B, 0x2B, 0x06, 0x01,
|
|
|
253609 |
- 0x04, 0x01, 0x02, 0x82, 0x0B, 0x01, 0x06,
|
|
|
253609 |
- 0x05, 0x05, 0x00
|
|
|
253609 |
-};
|
|
|
253609 |
+const CK_BYTE ber_NULL[] = { 0x05, 0x00 };
|
|
|
253609 |
|
|
|
253609 |
// ID Lengths
|
|
|
253609 |
//
|
|
|
253609 |
@@ -135,7 +131,7 @@ const CK_ULONG ber_AlgSha384Len = sizeof(ber_AlgSha384);
|
|
|
253609 |
const CK_ULONG ber_AlgSha512Len = sizeof(ber_AlgSha512);
|
|
|
253609 |
const CK_ULONG ber_AlgIdRSAEncryptionLen = sizeof(ber_AlgIdRSAEncryption);
|
|
|
253609 |
const CK_ULONG der_AlgIdECBaseLen = sizeof(der_AlgIdECBase);
|
|
|
253609 |
-const CK_ULONG ber_AlgIdDilithiumLen = sizeof(ber_AlgIdDilithium);
|
|
|
253609 |
+const CK_ULONG ber_NULLLen = sizeof(ber_NULL);
|
|
|
253609 |
|
|
|
253609 |
const CK_ULONG des_weak_count = 4;
|
|
|
253609 |
const CK_ULONG des_semi_weak_count = 12;
|
|
|
253609 |
diff --git a/usr/lib/common/h_extern.h b/usr/lib/common/h_extern.h
|
|
|
253609 |
index 340ab88d..41ca12df 100644
|
|
|
253609 |
--- a/usr/lib/common/h_extern.h
|
|
|
253609 |
+++ b/usr/lib/common/h_extern.h
|
|
|
253609 |
@@ -56,16 +56,14 @@ extern const CK_BYTE ber_rsaEncryption[];
|
|
|
253609 |
extern const CK_ULONG ber_rsaEncryptionLen;
|
|
|
253609 |
extern const CK_BYTE der_AlgIdECBase[];
|
|
|
253609 |
extern const CK_ULONG der_AlgIdECBaseLen;
|
|
|
253609 |
-extern const CK_BYTE ber_AlgIdDilithium[];
|
|
|
253609 |
-extern const CK_ULONG ber_AlgIdDilithiumLen;
|
|
|
253609 |
extern const CK_BYTE ber_idDSA[];
|
|
|
253609 |
extern const CK_ULONG ber_idDSALen;
|
|
|
253609 |
extern const CK_BYTE ber_idDH[];
|
|
|
253609 |
extern const CK_ULONG ber_idDHLen;
|
|
|
253609 |
extern const CK_BYTE ber_idEC[];
|
|
|
253609 |
extern const CK_ULONG ber_idECLen;
|
|
|
253609 |
-extern const CK_BYTE ber_idDilithium[];
|
|
|
253609 |
-extern const CK_ULONG ber_idDilithiumLen;
|
|
|
253609 |
+extern const CK_BYTE ber_NULL[];
|
|
|
253609 |
+extern const CK_ULONG ber_NULLLen;
|
|
|
253609 |
|
|
|
253609 |
#if !(NOMD2)
|
|
|
253609 |
extern const CK_BYTE ber_md2WithRSAEncryption[];
|
|
|
253609 |
@@ -2742,35 +2740,37 @@ CK_RV ber_decode_ECDHPrivateKey(CK_BYTE *data,
|
|
|
253609 |
CK_ATTRIBUTE **pub_key,
|
|
|
253609 |
CK_ATTRIBUTE **priv_key);
|
|
|
253609 |
|
|
|
253609 |
-CK_RV ber_encode_IBM_DilithiumPublicKey(CK_BBOOL length_only, CK_BYTE **data,
|
|
|
253609 |
- CK_ULONG *data_len, CK_ATTRIBUTE *rho,
|
|
|
253609 |
- CK_ATTRIBUTE *t1);
|
|
|
253609 |
+CK_RV ber_encode_IBM_DilithiumPublicKey(CK_BBOOL length_only,
|
|
|
253609 |
+ CK_BYTE **data, CK_ULONG *data_len,
|
|
|
253609 |
+ const CK_BYTE *oid, CK_ULONG oid_len,
|
|
|
253609 |
+ CK_ATTRIBUTE *rho, CK_ATTRIBUTE *t1);
|
|
|
253609 |
|
|
|
253609 |
CK_RV ber_decode_IBM_DilithiumPublicKey(CK_BYTE *data,
|
|
|
253609 |
- CK_ULONG data_len,
|
|
|
253609 |
- CK_ATTRIBUTE **rho_attr,
|
|
|
253609 |
- CK_ATTRIBUTE **t1_attr);
|
|
|
253609 |
+ CK_ULONG data_len,
|
|
|
253609 |
+ CK_ATTRIBUTE **rho_attr,
|
|
|
253609 |
+ CK_ATTRIBUTE **t1_attr);
|
|
|
253609 |
|
|
|
253609 |
CK_RV ber_encode_IBM_DilithiumPrivateKey(CK_BBOOL length_only,
|
|
|
253609 |
- CK_BYTE **data,
|
|
|
253609 |
- CK_ULONG *data_len,
|
|
|
253609 |
- CK_ATTRIBUTE *rho,
|
|
|
253609 |
- CK_ATTRIBUTE *seed,
|
|
|
253609 |
- CK_ATTRIBUTE *tr,
|
|
|
253609 |
- CK_ATTRIBUTE *s1,
|
|
|
253609 |
- CK_ATTRIBUTE *s2,
|
|
|
253609 |
- CK_ATTRIBUTE *t0,
|
|
|
253609 |
- CK_ATTRIBUTE *t1);
|
|
|
253609 |
+ CK_BYTE **data,
|
|
|
253609 |
+ CK_ULONG *data_len,
|
|
|
253609 |
+ const CK_BYTE *oid, CK_ULONG oid_len,
|
|
|
253609 |
+ CK_ATTRIBUTE *rho,
|
|
|
253609 |
+ CK_ATTRIBUTE *seed,
|
|
|
253609 |
+ CK_ATTRIBUTE *tr,
|
|
|
253609 |
+ CK_ATTRIBUTE *s1,
|
|
|
253609 |
+ CK_ATTRIBUTE *s2,
|
|
|
253609 |
+ CK_ATTRIBUTE *t0,
|
|
|
253609 |
+ CK_ATTRIBUTE *t1);
|
|
|
253609 |
|
|
|
253609 |
CK_RV ber_decode_IBM_DilithiumPrivateKey(CK_BYTE *data,
|
|
|
253609 |
- CK_ULONG data_len,
|
|
|
253609 |
- CK_ATTRIBUTE **rho,
|
|
|
253609 |
- CK_ATTRIBUTE **seed,
|
|
|
253609 |
- CK_ATTRIBUTE **tr,
|
|
|
253609 |
- CK_ATTRIBUTE **s1,
|
|
|
253609 |
- CK_ATTRIBUTE **s2,
|
|
|
253609 |
- CK_ATTRIBUTE **t0,
|
|
|
253609 |
- CK_ATTRIBUTE **t1);
|
|
|
253609 |
+ CK_ULONG data_len,
|
|
|
253609 |
+ CK_ATTRIBUTE **rho,
|
|
|
253609 |
+ CK_ATTRIBUTE **seed,
|
|
|
253609 |
+ CK_ATTRIBUTE **tr,
|
|
|
253609 |
+ CK_ATTRIBUTE **s1,
|
|
|
253609 |
+ CK_ATTRIBUTE **s2,
|
|
|
253609 |
+ CK_ATTRIBUTE **t0,
|
|
|
253609 |
+ CK_ATTRIBUTE **t1);
|
|
|
253609 |
|
|
|
253609 |
typedef CK_RV (*t_rsa_encrypt)(STDLL_TokData_t *, CK_BYTE *in_data,
|
|
|
253609 |
CK_ULONG in_data_len, CK_BYTE *out_data,
|
|
|
253609 |
diff --git a/usr/lib/common/key.c b/usr/lib/common/key.c
|
|
|
253609 |
index 6e9a839a..41857b97 100644
|
|
|
253609 |
--- a/usr/lib/common/key.c
|
|
|
253609 |
+++ b/usr/lib/common/key.c
|
|
|
253609 |
@@ -81,6 +81,7 @@
|
|
|
253609 |
#include "h_extern.h"
|
|
|
253609 |
#include "attributes.h"
|
|
|
253609 |
#include "trace.h"
|
|
|
253609 |
+#include "pqc_defs.h"
|
|
|
253609 |
|
|
|
253609 |
#include "tok_spec_struct.h"
|
|
|
253609 |
|
|
|
253609 |
@@ -2688,7 +2689,10 @@ CK_RV ibm_dilithium_publ_get_spki(TEMPLATE *tmpl, CK_BBOOL length_only,
|
|
|
253609 |
return rc;
|
|
|
253609 |
}
|
|
|
253609 |
|
|
|
253609 |
- rc = ber_encode_IBM_DilithiumPublicKey(length_only, data,data_len, rho, t1);
|
|
|
253609 |
+ rc = ber_encode_IBM_DilithiumPublicKey(length_only, data, data_len,
|
|
|
253609 |
+ dilithium_r2_65,
|
|
|
253609 |
+ dilithium_r2_65_len,
|
|
|
253609 |
+ rho, t1);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_ERROR("ber_encode_IBM_DilithiumPublicKey failed.\n");
|
|
|
253609 |
return rc;
|
|
|
253609 |
@@ -2766,7 +2770,9 @@ CK_RV ibm_dilithium_priv_wrap_get_data(TEMPLATE *tmpl,
|
|
|
253609 |
}
|
|
|
253609 |
|
|
|
253609 |
rc = ber_encode_IBM_DilithiumPrivateKey(length_only, data, data_len,
|
|
|
253609 |
- rho, seed, tr, s1, s2, t0, t1);
|
|
|
253609 |
+ dilithium_r2_65,
|
|
|
253609 |
+ dilithium_r2_65_len,
|
|
|
253609 |
+ rho, seed, tr, s1, s2, t0, t1);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_DEVEL("ber_encode_IBM_DilithiumPrivateKey failed\n");
|
|
|
253609 |
}
|
|
|
253609 |
diff --git a/usr/lib/common/key_mgr.c b/usr/lib/common/key_mgr.c
|
|
|
253609 |
index 99f2a72e..01103dc2 100644
|
|
|
253609 |
--- a/usr/lib/common/key_mgr.c
|
|
|
253609 |
+++ b/usr/lib/common/key_mgr.c
|
|
|
253609 |
@@ -35,6 +35,7 @@
|
|
|
253609 |
#include "attributes.h"
|
|
|
253609 |
#include "tok_spec_struct.h"
|
|
|
253609 |
#include "trace.h"
|
|
|
253609 |
+#include "pqc_defs.h"
|
|
|
253609 |
|
|
|
253609 |
#include "../api/policy.h"
|
|
|
253609 |
#include "../api/statistics.h"
|
|
|
253609 |
@@ -1368,7 +1369,7 @@ CK_RV key_mgr_get_private_key_type(CK_BYTE *keydata,
|
|
|
253609 |
{
|
|
|
253609 |
CK_BYTE *alg = NULL;
|
|
|
253609 |
CK_BYTE *priv_key = NULL;
|
|
|
253609 |
- CK_ULONG alg_len;
|
|
|
253609 |
+ CK_ULONG alg_len, i;
|
|
|
253609 |
CK_RV rc;
|
|
|
253609 |
|
|
|
253609 |
rc = ber_decode_PrivateKeyInfo(keydata, keylen, &alg, &alg_len, &priv_key);
|
|
|
253609 |
@@ -1408,10 +1409,14 @@ CK_RV key_mgr_get_private_key_type(CK_BYTE *keydata,
|
|
|
253609 |
return CKR_OK;
|
|
|
253609 |
}
|
|
|
253609 |
}
|
|
|
253609 |
- // Check only the OBJECT IDENTIFIER for DILITHIUM
|
|
|
253609 |
+ // Check only the OBJECT IDENTIFIERs for DILITHIUM
|
|
|
253609 |
//
|
|
|
253609 |
- if (alg_len >= ber_idDilithiumLen) {
|
|
|
253609 |
- if (memcmp(alg, ber_idDilithium, ber_idDilithiumLen) == 0) {
|
|
|
253609 |
+ for (i = 0; dilithium_oids[i].oid != NULL; i++) {
|
|
|
253609 |
+ if (alg_len == dilithium_oids[i].oid_len + ber_NULLLen &&
|
|
|
253609 |
+ memcmp(alg, dilithium_oids[i].oid,
|
|
|
253609 |
+ dilithium_oids[i].oid_len) == 0 &&
|
|
|
253609 |
+ memcmp(alg + dilithium_oids[i].oid_len,
|
|
|
253609 |
+ ber_NULL, ber_NULLLen) == 0) {
|
|
|
253609 |
*keytype = CKK_IBM_PQC_DILITHIUM;
|
|
|
253609 |
return CKR_OK;
|
|
|
253609 |
}
|
|
|
253609 |
diff --git a/usr/lib/ep11_stdll/ep11_specific.c b/usr/lib/ep11_stdll/ep11_specific.c
|
|
|
253609 |
index e3451163..45069ae8 100644
|
|
|
253609 |
--- a/usr/lib/ep11_stdll/ep11_specific.c
|
|
|
253609 |
+++ b/usr/lib/ep11_stdll/ep11_specific.c
|
|
|
253609 |
@@ -37,6 +37,7 @@
|
|
|
253609 |
#include "trace.h"
|
|
|
253609 |
#include "ock_syslog.h"
|
|
|
253609 |
#include "ec_defs.h"
|
|
|
253609 |
+#include "pqc_defs.h"
|
|
|
253609 |
#include "p11util.h"
|
|
|
253609 |
#include "events.h"
|
|
|
253609 |
#include "cfgparser.h"
|
|
|
253609 |
@@ -3645,7 +3646,10 @@ static CK_RV import_IBM_Dilithium_key(STDLL_TokData_t *tokdata, SESSION *sess,
|
|
|
253609 |
}
|
|
|
253609 |
|
|
|
253609 |
/* Encode the public key */
|
|
|
253609 |
- rc = ber_encode_IBM_DilithiumPublicKey(0, &data, &data_len, rho, t1);
|
|
|
253609 |
+ rc = ber_encode_IBM_DilithiumPublicKey(FALSE, &data, &data_len,
|
|
|
253609 |
+ dilithium_r2_65,
|
|
|
253609 |
+ dilithium_r2_65_len,
|
|
|
253609 |
+ rho, t1);
|
|
|
253609 |
if (rc != CKR_OK) {
|
|
|
253609 |
TRACE_ERROR("%s public key import class=0x%lx rc=0x%lx "
|
|
|
253609 |
"data_len=0x%lx\n", __func__, class, rc, data_len);
|
|
|
253609 |
diff --git a/usr/lib/ep11_stdll/ep11_stdll.mk b/usr/lib/ep11_stdll/ep11_stdll.mk
|
|
|
253609 |
index 9a8aa76a..11061f76 100644
|
|
|
253609 |
--- a/usr/lib/ep11_stdll/ep11_stdll.mk
|
|
|
253609 |
+++ b/usr/lib/ep11_stdll/ep11_stdll.mk
|
|
|
253609 |
@@ -43,7 +43,8 @@ opencryptoki_stdll_libpkcs11_ep11_la_SOURCES = usr/lib/common/asn1.c \
|
|
|
253609 |
usr/lib/ep11_stdll/ep11_specific.c \
|
|
|
253609 |
usr/lib/common/utility_common.c usr/lib/common/ec_supported.c \
|
|
|
253609 |
usr/lib/api/policyhelper.c usr/lib/config/configuration.c \
|
|
|
253609 |
- usr/lib/config/cfgparse.y usr/lib/config/cfglex.l
|
|
|
253609 |
+ usr/lib/config/cfgparse.y usr/lib/config/cfglex.l \
|
|
|
253609 |
+ usr/lib/common/pqc_supported.c
|
|
|
253609 |
|
|
|
253609 |
if ENABLE_LOCKS
|
|
|
253609 |
opencryptoki_stdll_libpkcs11_ep11_la_SOURCES += \
|
|
|
253609 |
diff --git a/usr/lib/ica_s390_stdll/ica_s390_stdll.mk b/usr/lib/ica_s390_stdll/ica_s390_stdll.mk
|
|
|
253609 |
index cb9d898f..f89cd343 100644
|
|
|
253609 |
--- a/usr/lib/ica_s390_stdll/ica_s390_stdll.mk
|
|
|
253609 |
+++ b/usr/lib/ica_s390_stdll/ica_s390_stdll.mk
|
|
|
253609 |
@@ -38,7 +38,7 @@ opencryptoki_stdll_libpkcs11_ica_la_SOURCES = \
|
|
|
253609 |
usr/lib/ica_s390_stdll/ica_specific.c usr/lib/common/dlist.c \
|
|
|
253609 |
usr/lib/common/mech_openssl.c \
|
|
|
253609 |
usr/lib/common/utility_common.c usr/lib/common/ec_supported.c \
|
|
|
253609 |
- usr/lib/api/policyhelper.c
|
|
|
253609 |
+ usr/lib/api/policyhelper.c usr/lib/common/pqc_supported.c
|
|
|
253609 |
|
|
|
253609 |
if ENABLE_LOCKS
|
|
|
253609 |
opencryptoki_stdll_libpkcs11_ica_la_SOURCES += \
|
|
|
253609 |
diff --git a/usr/lib/icsf_stdll/icsf_stdll.mk b/usr/lib/icsf_stdll/icsf_stdll.mk
|
|
|
253609 |
index ee83f674..ebf24290 100644
|
|
|
253609 |
--- a/usr/lib/icsf_stdll/icsf_stdll.mk
|
|
|
253609 |
+++ b/usr/lib/icsf_stdll/icsf_stdll.mk
|
|
|
253609 |
@@ -43,7 +43,7 @@ opencryptoki_stdll_libpkcs11_icsf_la_SOURCES = usr/lib/common/asn1.c \
|
|
|
253609 |
usr/lib/icsf_stdll/icsf_specific.c \
|
|
|
253609 |
usr/lib/icsf_stdll/icsf.c usr/lib/common/utility_common.c \
|
|
|
253609 |
usr/lib/common/ec_supported.c usr/lib/api/policyhelper.c \
|
|
|
253609 |
- usr/lib/config/configuration.c \
|
|
|
253609 |
+ usr/lib/config/configuration.c usr/lib/common/pqc_supported.c \
|
|
|
253609 |
usr/lib/config/cfgparse.y usr/lib/config/cfglex.l \
|
|
|
253609 |
usr/lib/common/mech_openssl.c
|
|
|
253609 |
|
|
|
253609 |
diff --git a/usr/lib/soft_stdll/soft_stdll.mk b/usr/lib/soft_stdll/soft_stdll.mk
|
|
|
253609 |
index 6cdf82b8..7a842ddc 100644
|
|
|
253609 |
--- a/usr/lib/soft_stdll/soft_stdll.mk
|
|
|
253609 |
+++ b/usr/lib/soft_stdll/soft_stdll.mk
|
|
|
253609 |
@@ -36,7 +36,7 @@ opencryptoki_stdll_libpkcs11_sw_la_SOURCES = \
|
|
|
253609 |
usr/lib/soft_stdll/soft_specific.c usr/lib/common/attributes.c \
|
|
|
253609 |
usr/lib/common/dlist.c usr/lib/common/mech_openssl.c \
|
|
|
253609 |
usr/lib/common/utility_common.c usr/lib/common/ec_supported.c \
|
|
|
253609 |
- usr/lib/api/policyhelper.c
|
|
|
253609 |
+ usr/lib/api/policyhelper.c usr/lib/common/pqc_supported.c
|
|
|
253609 |
|
|
|
253609 |
if ENABLE_LOCKS
|
|
|
253609 |
opencryptoki_stdll_libpkcs11_sw_la_SOURCES += \
|
|
|
253609 |
diff --git a/usr/lib/tpm_stdll/tpm_stdll.mk b/usr/lib/tpm_stdll/tpm_stdll.mk
|
|
|
253609 |
index 54551c1f..7fa18121 100644
|
|
|
253609 |
--- a/usr/lib/tpm_stdll/tpm_stdll.mk
|
|
|
253609 |
+++ b/usr/lib/tpm_stdll/tpm_stdll.mk
|
|
|
253609 |
@@ -38,7 +38,7 @@ opencryptoki_stdll_libpkcs11_tpm_la_SOURCES = \
|
|
|
253609 |
usr/lib/tpm_stdll/tpm_openssl.c usr/lib/tpm_stdll/tpm_util.c \
|
|
|
253609 |
usr/lib/common/dlist.c usr/lib/common/mech_openssl.c \
|
|
|
253609 |
usr/lib/common/utility_common.c usr/lib/common/ec_supported.c \
|
|
|
253609 |
- usr/lib/api/policyhelper.c
|
|
|
253609 |
+ usr/lib/api/policyhelper.c usr/lib/common/pqc_supported.c
|
|
|
253609 |
|
|
|
253609 |
if ENABLE_LOCKS
|
|
|
253609 |
opencryptoki_stdll_libpkcs11_tpm_la_SOURCES += \
|
|
|
253609 |
diff --git a/usr/sbin/pkcscca/pkcscca.mk b/usr/sbin/pkcscca/pkcscca.mk
|
|
|
253609 |
index 187a93f2..59300ef5 100644
|
|
|
253609 |
--- a/usr/sbin/pkcscca/pkcscca.mk
|
|
|
253609 |
+++ b/usr/sbin/pkcscca/pkcscca.mk
|
|
|
253609 |
@@ -41,7 +41,7 @@ usr_sbin_pkcscca_pkcscca_SOURCES = usr/lib/common/asn1.c \
|
|
|
253609 |
usr/lib/common/dlist.c usr/sbin/pkcscca/pkcscca.c \
|
|
|
253609 |
usr/lib/common/utility_common.c usr/lib/common/ec_supported.c \
|
|
|
253609 |
usr/lib/common/pin_prompt.c usr/lib/common/mech_openssl.c \
|
|
|
253609 |
- usr/lib/api/policyhelper.c
|
|
|
253609 |
+ usr/lib/api/policyhelper.c usr/lib/common/pqc_supported.c
|
|
|
253609 |
|
|
|
253609 |
nodist_usr_sbin_pkcscca_pkcscca_SOURCES = usr/lib/api/mechtable.c
|
|
|
253609 |
|
|
|
253609 |
--
|
|
|
253609 |
2.16.2.windows.1
|
|
|
253609 |
|