diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..f86a512 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +SOURCES/open-vm-tools-11.0.0-14549434.tar.gz diff --git a/.open-vm-tools.metadata b/.open-vm-tools.metadata new file mode 100644 index 0000000..c4987fa --- /dev/null +++ b/.open-vm-tools.metadata @@ -0,0 +1 @@ +c4b7df8636a02195151a51b46d1af2690cca7e78 SOURCES/open-vm-tools-11.0.0-14549434.tar.gz diff --git a/SOURCES/0002-Fix-leaks-in-ListAliases-and-ListMappedAliases.patch b/SOURCES/0002-Fix-leaks-in-ListAliases-and-ListMappedAliases.patch new file mode 100644 index 0000000..c9dd35b --- /dev/null +++ b/SOURCES/0002-Fix-leaks-in-ListAliases-and-ListMappedAliases.patch @@ -0,0 +1,69 @@ +From 1128cfce9031891ff0da50131b75771582756ca1 Mon Sep 17 00:00:00 2001 +From: Oliver Kurth +Date: Wed, 2 Oct 2019 17:48:35 -0700 +Subject: Fix leaks in ListAliases and ListMappedAliases. + +The 'record' for each alias was being leaked. +--- + open-vm-tools/services/plugins/vix/vixTools.c | 10 ++++++++-- + 1 file changed, 8 insertions(+), 2 deletions(-) + +diff --git a/open-vm-tools/services/plugins/vix/vixTools.c b/open-vm-tools/services/plugins/vix/vixTools.c +index 44bca5c..c40ad15 100644 +--- a/open-vm-tools/services/plugins/vix/vixTools.c ++++ b/open-vm-tools/services/plugins/vix/vixTools.c +@@ -9762,7 +9762,6 @@ VixToolsListAuthAliases(VixCommandRequestHeader *requestMsg, // IN + char *destPtr; + char *endDestPtr; + char *tmpBuf = NULL; +- char *recordBuf; + size_t recordSize; + char *escapedStr = NULL; + char *escapedStr2 = NULL; +@@ -9822,6 +9821,8 @@ VixToolsListAuthAliases(VixCommandRequestHeader *requestMsg, // IN + destPtr += Str_Sprintf(destPtr, endDestPtr - destPtr, "%s", + VIX_XML_ESCAPED_TAG); + for (i = 0; i < num; i++) { ++ char *recordBuf = NULL; ++ + escapedStr = VixToolsEscapeXMLString(uaList[i].pemCert); + if (escapedStr == NULL) { + err = VIX_E_OUT_OF_MEMORY; +@@ -9895,6 +9896,8 @@ VixToolsListAuthAliases(VixCommandRequestHeader *requestMsg, // IN + Log("%s: ListAuth list results too large, truncating", __FUNCTION__); + goto abort; + } ++ free(recordBuf); ++ recordBuf = NULL; + } + + *result = resultBuffer; +@@ -9960,7 +9963,6 @@ VixToolsListMappedAliases(VixCommandRequestHeader *requestMsg, // IN + char *destPtr; + char *endDestPtr; + char *tmpBuf = NULL; +- char *recordBuf; + char *escapedStr = NULL; + char *escapedStr2 = NULL; + size_t recordSize; +@@ -10014,6 +10016,8 @@ VixToolsListMappedAliases(VixCommandRequestHeader *requestMsg, // IN + destPtr += Str_Sprintf(destPtr, endDestPtr - destPtr, "%s", + VIX_XML_ESCAPED_TAG); + for (i = 0; i < num; i++) { ++ char *recordBuf = NULL; ++ + escapedStr = VixToolsEscapeXMLString(maList[i].pemCert); + if (escapedStr == NULL) { + err = VIX_E_OUT_OF_MEMORY; +@@ -10085,6 +10089,8 @@ VixToolsListMappedAliases(VixCommandRequestHeader *requestMsg, // IN + Log("%s: ListMapped results too large, truncating", __FUNCTION__); + goto abort; + } ++ free(recordBuf); ++ recordBuf = NULL; + } + + *result = resultBuffer; +-- +1.8.3.1 + diff --git a/SOURCES/ovt-Address-Coverity-issues-reported-in-bora-lib-file-fi.patch b/SOURCES/ovt-Address-Coverity-issues-reported-in-bora-lib-file-fi.patch new file mode 100644 index 0000000..dc62ab6 --- /dev/null +++ b/SOURCES/ovt-Address-Coverity-issues-reported-in-bora-lib-file-fi.patch @@ -0,0 +1,63 @@ +From d01520e206cc1e3ae658e8fb168ff3b4494fc1ef Mon Sep 17 00:00:00 2001 +From: Cathy Avery +Date: Tue, 3 Dec 2019 14:30:47 +0100 +Subject: [PATCH 1/4] Address Coverity issues reported in bora/lib/file/file.c. + +RH-Author: Cathy Avery +Message-id: <20191203143050.23065-2-cavery@redhat.com> +Patchwork-id: 92833 +O-Subject: [RHEL8.2 open-vm-tools PATCH 1/4] Address Coverity issues reported in bora/lib/file/file.c. +Bugzilla: 1769881 +RH-Acked-by: Vitaly Kuznetsov +RH-Acked-by: Miroslav Rezanina + +commit 5ca2850b60de0f27c3f8c565d7b7e553acc2921f +Author: Oliver Kurth +Date: Tue Aug 27 12:55:37 2019 -0700 + + Address Coverity issues reported in bora/lib/file/file.c. + + Fix a minor memory leak in the function File_ExpandAndCheckDir. + Also add annotations for unchecked return values in functions + GetOldMachineID and File_MoveTree, so that Coverity scans of + open-vm-tools will automatically classify these issues as + "Intentional". These annotations are useful both for internal + use as well as for partners who run Coverity scans on open-vm-tools. + +Signed-off-by: Cathy Avery +Signed-off-by: Miroslav Rezanina +--- + open-vm-tools/lib/file/file.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/open-vm-tools/lib/file/file.c b/open-vm-tools/lib/file/file.c +index 7dae12c..774ec41 100644 +--- a/open-vm-tools/lib/file/file.c ++++ b/open-vm-tools/lib/file/file.c +@@ -558,6 +558,7 @@ GetOldMachineID(void) + sizeof hardwareID); + + /* Base 64 encode the binary data to obtain printable characters */ ++ /* coverity[check_return] */ + Base64_Encode(rawMachineID, sizeof rawMachineID, encodedMachineID, + sizeof encodedMachineID, NULL); + +@@ -1437,6 +1438,7 @@ File_MoveTree(const char *srcName, // IN: + * Only clean up if we created the directory. Not attempting to + * clean up partial failures. + */ ++ /* coverity[check_return] */ + File_DeleteDirectoryTree(dstName); + } + } +@@ -2186,6 +2188,7 @@ File_ExpandAndCheckDir(const char *dirName) // IN: + + return edirName; + } ++ free(edirName); + } + + return NULL; +-- +1.8.3.1 + diff --git a/SOURCES/ovt-Address-two-Coverity-reported-issues-in-hostinfoPosi.patch b/SOURCES/ovt-Address-two-Coverity-reported-issues-in-hostinfoPosi.patch new file mode 100644 index 0000000..8735ee3 --- /dev/null +++ b/SOURCES/ovt-Address-two-Coverity-reported-issues-in-hostinfoPosi.patch @@ -0,0 +1,61 @@ +From 805d013a5604b124177149be4d10384f58eff74b Mon Sep 17 00:00:00 2001 +From: Cathy Avery +Date: Tue, 3 Dec 2019 14:30:49 +0100 +Subject: [PATCH 3/4] Address two Coverity-reported issues in hostinfoPosix.c. + +RH-Author: Cathy Avery +Message-id: <20191203143050.23065-4-cavery@redhat.com> +Patchwork-id: 92834 +O-Subject: [RHEL8.2 open-vm-tools PATCH 3/4] Address two Coverity-reported issues in hostinfoPosix.c. +Bugzilla: 1769881 +RH-Acked-by: Vitaly Kuznetsov +RH-Acked-by: Miroslav Rezanina + +commit 8a01c912927b5bb8cdbfa57f5e8c92e8cf792bef +Author: Oliver Kurth +Date: Fri Nov 22 14:52:35 2019 -0800 + + Address two Coverity-reported issues in hostinfoPosix.c. + + Rework some code with the intent of making it more straightfoward, + which also eliminates a false positive. + + Check the return value from PosixUnlink and log a warning on error. + +Signed-off-by: Cathy Avery +Signed-off-by: Miroslav Rezanina +--- + open-vm-tools/lib/misc/hostinfoPosix.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/open-vm-tools/lib/misc/hostinfoPosix.c b/open-vm-tools/lib/misc/hostinfoPosix.c +index 348a67e..302452e 100644 +--- a/open-vm-tools/lib/misc/hostinfoPosix.c ++++ b/open-vm-tools/lib/misc/hostinfoPosix.c +@@ -1127,10 +1127,7 @@ out: + if (success) { + result[nArgs - 1] = DynBuf_Detach(&b); + } else { +- if (nArgs != 0) { +- Util_FreeStringList(result, nArgs); +- } +- ++ Util_FreeStringList(result, nArgs); + result = NULL; + } + +@@ -2884,7 +2881,10 @@ Hostinfo_Daemonize(const char *path, // IN: NUL-terminated UTF-8 + * with another process attempting to daemonize and unlinking the + * file it created instead. + */ +- Posix_Unlink(pidPath); ++ if (Posix_Unlink(pidPath) != 0) { ++ Warning("%s: Unable to unlink %s: %u\n", ++ __FUNCTION__, pidPath, errno); ++ } + } + + errno = err; +-- +1.8.3.1 + diff --git a/SOURCES/ovt-Fix-a-potential-NULL-pointer-dereference-in-the-vmba.patch b/SOURCES/ovt-Fix-a-potential-NULL-pointer-dereference-in-the-vmba.patch new file mode 100644 index 0000000..95e514c --- /dev/null +++ b/SOURCES/ovt-Fix-a-potential-NULL-pointer-dereference-in-the-vmba.patch @@ -0,0 +1,54 @@ +From 6c6daa468c9a1ad1ad4d5bf727008d029d009a50 Mon Sep 17 00:00:00 2001 +From: Cathy Avery +Date: Tue, 3 Dec 2019 14:30:48 +0100 +Subject: [PATCH 2/4] Fix a potential NULL pointer dereference in the vmbackup + plugin. + +RH-Author: Cathy Avery +Message-id: <20191203143050.23065-3-cavery@redhat.com> +Patchwork-id: 92836 +O-Subject: [RHEL8.2 open-vm-tools PATCH 2/4] Fix a potential NULL pointer dereference in the vmbackup plugin. +Bugzilla: 1769881 +RH-Acked-by: Vitaly Kuznetsov +RH-Acked-by: Miroslav Rezanina + +commit 0bb6cf83fb6b1f80c99beb11cd47e0db02e252ff +Author: Oliver Kurth +Date: Fri Nov 22 14:52:35 2019 -0800 + + Fix a potential NULL pointer dereference in the vmbackup plugin. + + In some circumtances, VmBackupAsyncCallback might dereference + gBackupState after calling VmBackupDoAbort even though the + latter function can potentially set gBackupState to NULL. Add + a check to prevent the potential NULL pointer dereference. + +Signed-off-by: Cathy Avery +Signed-off-by: Miroslav Rezanina +--- + open-vm-tools/services/plugins/vmbackup/stateMachine.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/open-vm-tools/services/plugins/vmbackup/stateMachine.c b/open-vm-tools/services/plugins/vmbackup/stateMachine.c +index 6b42286..5c01a7b 100644 +--- a/open-vm-tools/services/plugins/vmbackup/stateMachine.c ++++ b/open-vm-tools/services/plugins/vmbackup/stateMachine.c +@@ -675,6 +675,15 @@ VmBackupAsyncCallback(void *clientData) + if (gBackupState->rpcState == VMBACKUP_RPC_STATE_ERROR) { + g_warning("Aborting backup operation due to RPC errors."); + VmBackupDoAbort(); ++ ++ /* ++ * Check gBackupState, since the abort could cause a transition to ++ * VMBACKUP_MSTATE_IDLE, in which case the VmBackupState structure ++ * would be freed and gBackupState would be NULL. ++ */ ++ if (gBackupState == NULL) { ++ return FALSE; ++ } + goto exit; + } + } +-- +1.8.3.1 + diff --git a/SOURCES/ovt-Fix-a-resource-leak-issue-in-deployPkg.patch b/SOURCES/ovt-Fix-a-resource-leak-issue-in-deployPkg.patch new file mode 100644 index 0000000..0cfccf0 --- /dev/null +++ b/SOURCES/ovt-Fix-a-resource-leak-issue-in-deployPkg.patch @@ -0,0 +1,90 @@ +From acf9aa0dce71106f3603398a7b6984ff91dd0eda Mon Sep 17 00:00:00 2001 +From: Cathy Avery +Date: Tue, 3 Dec 2019 14:30:50 +0100 +Subject: [PATCH 4/4] Fix a resource leak issue in deployPkg + +RH-Author: Cathy Avery +Message-id: <20191203143050.23065-5-cavery@redhat.com> +Patchwork-id: 92837 +O-Subject: [RHEL8.2 open-vm-tools PATCH 4/4] Fix a resource leak issue in deployPkg +Bugzilla: 1769881 +RH-Acked-by: Vitaly Kuznetsov +RH-Acked-by: Miroslav Rezanina + +commit 2ffd2913088505d8249fa342b0ee8e5002a69108 +Author: Oliver Kurth +Date: Fri Nov 22 14:52:35 2019 -0800 + + Fix a resource leak issue in deployPkg + + Variable file going out of scope in error path leaks the storage it + points to. Added fclose before return when malloc failed. + +Signed-off-by: Cathy Avery +Signed-off-by: Miroslav Rezanina +--- + open-vm-tools/libDeployPkg/linuxDeployment.c | 23 ++++++++++++++--------- + 1 file changed, 14 insertions(+), 9 deletions(-) + +diff --git a/open-vm-tools/libDeployPkg/linuxDeployment.c b/open-vm-tools/libDeployPkg/linuxDeployment.c +index 1af0893..4f36a00 100644 +--- a/open-vm-tools/libDeployPkg/linuxDeployment.c ++++ b/open-vm-tools/libDeployPkg/linuxDeployment.c +@@ -824,17 +824,18 @@ TransitionState(const char* stateFrom, const char* stateTo) + * + *----------------------------------------------------------------------------- + */ +-static char* +-GetNicsToEnable(const char* dir) ++ ++static char * ++GetNicsToEnable(const char *dir) + { + /* +- * The file nics.txt will list ordinal number of all nics to enable separated by +- * a ",". In current architecture we can have max 4 nics. So we just have to read +- * maximum of 7 characters. This code uses 1024 chars to make sure any future +- * needs are accomodated. ++ * The file nics.txt will list ordinal number of all nics to enable separated ++ * by a ",". In current architecture we can have max 4 nics. So we just have ++ * to read maximum of 7 characters. This code uses 1024 chars to make sure ++ * any future needs are accomodated. + */ + static const unsigned int NICS_SIZE = 1024; +- static const char* nicFile = "/nics.txt"; ++ static const char *nicFile = "/nics.txt"; + + FILE *file; + +@@ -852,7 +853,9 @@ GetNicsToEnable(const char* dir) + if (file) { + ret = malloc(NICS_SIZE); + if (ret == NULL) { +- SetDeployError("Error allocating memory to read nic file '%s'", fileName); ++ SetDeployError("Error allocating memory to read nic file '%s'", ++ fileName); ++ fclose(file); + free(fileName); + return ret; + } +@@ -862,7 +865,8 @@ GetNicsToEnable(const char* dir) + + // Check various error condition + if (ferror(file)) { +- SetDeployError("Error reading nic file '%s'.(%s)", fileName, strerror(errno)); ++ SetDeployError("Error reading nic file '%s'.(%s)", fileName, ++ strerror(errno)); + free(ret); + ret = NULL; + } +@@ -880,6 +884,7 @@ GetNicsToEnable(const char* dir) + return ret; + } + ++ + /** + *------------------------------------------------------------------------------ + * +-- +1.8.3.1 + diff --git a/SOURCES/ovt-Rectify-a-log-spew-in-vmsvc-logging-vmware-vmsvc-roo.patch b/SOURCES/ovt-Rectify-a-log-spew-in-vmsvc-logging-vmware-vmsvc-roo.patch new file mode 100644 index 0000000..a32ee73 --- /dev/null +++ b/SOURCES/ovt-Rectify-a-log-spew-in-vmsvc-logging-vmware-vmsvc-roo.patch @@ -0,0 +1,60 @@ +From 6536375aa0f30fe9226ec687d7854d5c2aef5a7d Mon Sep 17 00:00:00 2001 +From: Cathy Avery +Date: Fri, 14 Feb 2020 12:23:09 +0100 +Subject: [PATCH] Rectify a log spew in vmsvc logging (vmware-vmsvc-root.log ) + +RH-Author: Cathy Avery +Message-id: <20200214122309.5769-1-cavery@redhat.com> +Patchwork-id: 93876 +O-Subject: [RHEL8.2 open-vm-tools PATCH] Rectify a log spew in vmsvc logging (vmware-vmsvc-root.log ) +Bugzilla: 1800812 +RH-Acked-by: Eduardo Otubo +RH-Acked-by: Mohammed Gamal + +Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1800812 +Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=26372468 +Branch: rhel8/master-11.0.0 +Tested: By QE +Upstream Status: stable-11.0.5-suse-bug-1162435 targeted for 11.1.0 + +commit 4ee0bd3c8ead89541ab7d196fb54e940e397420d +Author: Oliver Kurth +Date: Fri, 7 Feb 2020 10:39:38 -0800 + + Rectify a log spew in vmsvc logging (vmware-vmsvc-root.log ) + + When a LSI Logic Parallel SCSI controller sits in PCI bus 0 + (SCSI controller 0), the Linux disk device enumeration does not provide + a "label" file with the controller name. This results in messages like + + "GuestInfoGetDiskDevice: Missing disk device name; VMDK mapping unavailable for "/var/log", fsName: "/dev/sda2" + + repeatedly appearing in the vmsvc logging. The patch converts what previously + was a warning message to a debug message and thus avoids the log spew. + +Signed-off-by: Cathy Avery +Signed-off-by: Miroslav Rezanina +--- + open-vm-tools/services/plugins/guestInfo/diskInfo.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/open-vm-tools/services/plugins/guestInfo/diskInfo.c b/open-vm-tools/services/plugins/guestInfo/diskInfo.c +index a8234a4..c974dbd 100644 +--- a/open-vm-tools/services/plugins/guestInfo/diskInfo.c ++++ b/open-vm-tools/services/plugins/guestInfo/diskInfo.c +@@ -837,9 +837,9 @@ GuestInfoGetDiskDevice(const char *fsName, + */ + for (indx = 0; indx < partEntry->diskDevCnt; indx++) { + if (partEntry->diskDevNames[indx][0] == '\0') { +- g_warning("%s: Missing disk device name; VMDK mapping unavailable " +- "for \"%s\", fsName: \"%s\"\n", __FUNCTION__, +- partEntry->name, fsName); ++ g_debug("%s: Missing disk device name; VMDK mapping unavailable " ++ "for \"%s\", fsName: \"%s\"\n", __FUNCTION__, ++ partEntry->name, fsName); + partEntry->diskDevCnt = 0; + free(partEntry->diskDevNames); + partEntry->diskDevNames = NULL; +-- +1.8.3.1 + diff --git a/SOURCES/vgauthd.service b/SOURCES/vgauthd.service new file mode 100644 index 0000000..d5fef2c --- /dev/null +++ b/SOURCES/vgauthd.service @@ -0,0 +1,12 @@ +[Unit] +Description=VGAuth Service for open-vm-tools +Documentation=http://github.com/vmware/open-vm-tools +ConditionVirtualization=vmware +PartOf=vmtoolsd.service + +[Service] +ExecStart=/usr/bin/VGAuthService -s +TimeoutStopSec=5 + +[Install] +RequiredBy=vmtoolsd.service diff --git a/SOURCES/vmtoolsd.service b/SOURCES/vmtoolsd.service new file mode 100644 index 0000000..773040d --- /dev/null +++ b/SOURCES/vmtoolsd.service @@ -0,0 +1,16 @@ +[Unit] +Description=Service for virtual machines hosted on VMware +Documentation=http://github.com/vmware/open-vm-tools +ConditionVirtualization=vmware +Requires=vgauthd.service +After=vgauthd.service +DefaultDependencies=no +Before=cloud-init-local.service + +[Service] +ExecStart=/usr/bin/vmtoolsd +TimeoutStopSec=5 + +[Install] +WantedBy=multi-user.target +Also=vgauthd.service diff --git a/SPECS/open-vm-tools.spec b/SPECS/open-vm-tools.spec new file mode 100644 index 0000000..379ecbd --- /dev/null +++ b/SPECS/open-vm-tools.spec @@ -0,0 +1,716 @@ +################################################################################ +### Copyright 2013-18 VMware, Inc. All rights reserved. +### +### RPM SPEC file for building open-vm-tools packages. +### +### +### This program is free software; you can redistribute it and/or modify +### it under the terms of version 2 of the GNU General Public License as +### published by the Free Software Foundation. +### +### This program is distributed in the hope that it will be useful, +### but WITHOUT ANY WARRANTY; without even the implied warranty of +### MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +### GNU General Public License for more details. +### +### You should have received a copy of the GNU General Public License +### along with this program; if not, write to the Free Software +### Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +################################################################################ + +%global _hardened_build 1 +%global majorversion 11.0 +%global minorversion 0 +%global toolsbuild 14549434 +%global toolsversion %{majorversion}.%{minorversion} +%global toolsdaemon vmtoolsd +%global vgauthdaemon vgauthd + +Name: open-vm-tools +Version: %{toolsversion} +Release: 4%{?dist} +Summary: Open Virtual Machine Tools for virtual machines hosted on VMware +Group: Applications/System +License: GPLv2 +URL: https://github.com/vmware/%{name} +Source0: https://github.com/vmware/%{name}/releases/download/stable-%{version}/%{name}-%{version}-%{toolsbuild}.tar.gz +Source1: %{toolsdaemon}.service +Source2: %{vgauthdaemon}.service +ExclusiveArch: x86_64 + +Patch0002: 0002-Fix-leaks-in-ListAliases-and-ListMappedAliases.patch +# For bz#1769881 - [ESXi][RHEL8.2]Important issues found by covscan in "open-vm-tools-11.0.0-2.el8" package +Patch3: ovt-Address-Coverity-issues-reported-in-bora-lib-file-fi.patch +# For bz#1769881 - [ESXi][RHEL8.2]Important issues found by covscan in "open-vm-tools-11.0.0-2.el8" package +Patch4: ovt-Fix-a-potential-NULL-pointer-dereference-in-the-vmba.patch +# For bz#1769881 - [ESXi][RHEL8.2]Important issues found by covscan in "open-vm-tools-11.0.0-2.el8" package +Patch5: ovt-Address-two-Coverity-reported-issues-in-hostinfoPosi.patch +# For bz#1769881 - [ESXi][RHEL8.2]Important issues found by covscan in "open-vm-tools-11.0.0-2.el8" package +Patch6: ovt-Fix-a-resource-leak-issue-in-deployPkg.patch +# For bz#1800812 - [ESXi][RHEL8]Log spew "[ warning] [guestinfo] GuestInfoGetDiskDevice: Missing disk device name +Patch7: ovt-Rectify-a-log-spew-in-vmsvc-logging-vmware-vmsvc-roo.patch + +BuildRequires: autoconf +BuildRequires: automake +BuildRequires: libtool +BuildRequires: gcc-c++ +BuildRequires: doxygen +# Fuse is optional and enables vmblock-fuse +BuildRequires: fuse-devel +BuildRequires: glib2-devel >= 2.14.0 +BuildRequires: gdk-pixbuf2-xlib-devel +BuildRequires: gtk3-devel >= 3.10.0 +BuildRequires: gtkmm30-devel >= 3.10.0 +BuildRequires: libdnet-devel +BuildRequires: libicu-devel +BuildRequires: libmspack-devel +# Unfortunately, xmlsec1-openssl does not add libtool-ltdl +# dependency, so we need to add it ourselves. +BuildRequires: libtool-ltdl-devel +BuildRequires: libX11-devel +BuildRequires: libXext-devel +BuildRequires: libXi-devel +BuildRequires: libXinerama-devel +BuildRequires: libXrandr-devel +BuildRequires: libXrender-devel +BuildRequires: libXtst-devel +BuildRequires: openssl-devel +BuildRequires: pam-devel +BuildRequires: procps-devel +BuildRequires: rpcgen +BuildRequires: systemd +BuildRequires: libtirpc-devel +BuildRequires: xmlsec1-openssl-devel + +Requires: coreutils +Requires: fuse +Requires: libdrm +Requires: iproute +Requires: grep +Requires: pciutils +Requires: sed +Requires: systemd +Requires: systemd-libs +Requires: tar +Requires: which +# xmlsec1-openssl needs to be added explicitly +Requires: xmlsec1-openssl + +# open-vm-tools >= 10.0.0 do not require open-vm-tools-deploypkg +# provided by VMware. That functionality is now available as part +# of open-vm-tools package itself. +Obsoletes: open-vm-tools-deploypkg <= 10.0.5 + +%description +The %{name} project is an open source implementation of VMware Tools. It +is a suite of open source virtualization utilities and drivers to improve the +functionality, user experience and administration of VMware virtual machines. +This package contains only the core user-space programs and libraries of +%{name}. + +%package desktop +Summary: User experience components for Open Virtual Machine Tools +Group: System Environment/Libraries +Requires: %{name}%{?_isa} = %{version}-%{release} + +%description desktop +This package contains only the user-space programs and libraries of +%{name} that are essential for improved user experience of VMware virtual +machines. + +%package devel +Summary: Development libraries for Open Virtual Machine Tools +Group: Development/Libraries +Requires: %{name}%{?_isa} = %{version}-%{release} + +%description devel +This package contains only the user-space programs and libraries of +%{name} that are essential for developing customized applications for +VMware virtual machines. + +%package test +Summary: Test utilities for Open Virtual Machine Tools +Group: Development/Libraries +Requires: %{name}%{?_isa} = %{version}-%{release} + +%description test +This package contains only the test utilities for %{name} that are +useful for verifying the functioning of %{name} in VMware virtual +machines. + +%prep +%autosetup -p2 -n %{name}-%{version}-%{toolsbuild} + +%build +# Required for regenerating configure script when +# configure.ac get modified +autoreconf -vif + +%global usetirpc with-tirpc + +%configure \ + --without-kernel-modules \ + --enable-xmlsec1 \ + --enable-resolutionkms \ + --%{usetirpc} \ + --disable-static + +sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool +%make_build + +%install +export DONT_STRIP=1 +%make_install + +# Remove exec bit from config files +chmod a-x %{buildroot}%{_sysconfdir}/pam.d/* +chmod a-x %{buildroot}%{_sysconfdir}/vmware-tools/*.conf +chmod a-x %{buildroot}%{_sysconfdir}/vmware-tools/vgauth/schemas/* + +# Remove exec bit on udev rules. +chmod a-x %{buildroot}%{_udevrulesdir}/99-vmware-scsi-udev.rules + +# Remove the DOS line endings +sed -i "s|\r||g" README + +# Remove "Encoding" key from the "Desktop Entry" +sed -i "s|^Encoding.*$||g" %{buildroot}%{_sysconfdir}/xdg/autostart/vmware-user.desktop + +# Remove unnecessary files from packaging +find %{buildroot}%{_libdir} -name '*.la' -delete +rm -fr %{buildroot}%{_defaultdocdir} +rm -f docs/api/build/html/FreeSans.ttf + +# Remove mount.vmhgfs & symlink +rm -fr %{buildroot}%{_sbindir} %{buildroot}/sbin/mount.vmhgfs + +# Move vm-support to /usr/bin +mv %{buildroot}%{_sysconfdir}/vmware-tools/vm-support %{buildroot}%{_bindir} + +# Systemd unit files +install -p -m 644 -D %{SOURCE1} %{buildroot}%{_unitdir}/%{toolsdaemon}.service +install -p -m 644 -D %{SOURCE2} %{buildroot}%{_unitdir}/%{vgauthdaemon}.service + +# 'make check' in open-vm-tools rebuilds docs and ends up regenerating +# the font file. We can add %%check secion once 'make check' is fixed +# upstream + +%post +%{?ldconfig} +# Setup mount point for Shared Folders +# NOTE: Use systemd-detect-virt to detect VMware platform because +# vmware-checkvm might misbehave on non-VMware platforms. +if [ -f %{_bindir}/vmware-checkvm -a \ + -f %{_bindir}/vmhgfs-fuse ] && \ + %{_bindir}/systemd-detect-virt | grep -iq VMware && \ + %{_bindir}/vmware-checkvm &> /dev/null && \ + %{_bindir}/vmware-checkvm -p | grep -q Workstation && \ + %{_bindir}/vmhgfs-fuse -e &> /dev/null; then + mkdir -p /mnt/hgfs +fi + +if [ "$1" = "2" ]; then + # Cleanup GuestProxy certs, relevant for upgrades only + if [ -f %{_bindir}/vmware-guestproxycerttool ]; then + %{_bindir}/vmware-guestproxycerttool -e &> /dev/null || /bin/true + fi + if [ -d /etc/vmware-tools/GuestProxyData ]; then + rm -rf /etc/vmware-tools/GuestProxyData &> /dev/null || /bin/true + fi + + # Cleanup vmtoolsd-init.service in case of upgrades + %{_bindir}/systemctl disable %{toolsdaemon}-init.service &> /dev/null || /bin/true +fi + + +%systemd_post %{vgauthdaemon}.service +%systemd_post %{toolsdaemon}.service + +%preun +%systemd_preun %{toolsdaemon}.service +%systemd_preun %{vgauthdaemon}.service + +if [ "$1" = "0" -a \ + -f %{_bindir}/vmware-checkvm ] && \ + %{_bindir}/systemd-detect-virt | grep -iq VMware && \ + %{_bindir}/vmware-checkvm &> /dev/null; then + + # Tell VMware that open-vm-tools is being uninstalled + if [ -f %{_bindir}/vmware-rpctool ]; then + %{_bindir}/vmware-rpctool 'tools.set.version 0' &> /dev/null || /bin/true + fi + + # Teardown mount point for Shared Folders + if [ -d /mnt/hgfs ] && \ + %{_bindir}/vmware-checkvm -p | grep -q Workstation; then + umount /mnt/hgfs &> /dev/null || /bin/true + rmdir /mnt/hgfs &> /dev/null || /bin/true + fi +fi + +%postun +%{?ldconfig} +%systemd_postun_with_restart %{toolsdaemon}.service +%systemd_postun_with_restart %{vgauthdaemon}.service + +%files +%license COPYING +%doc AUTHORS ChangeLog NEWS README +%config(noreplace) %{_sysconfdir}/pam.d/* +%dir %{_sysconfdir}/vmware-tools/ +%dir %{_sysconfdir}/vmware-tools/vgauth +%dir %{_sysconfdir}/vmware-tools/vgauth/schemas +%config(noreplace) %{_sysconfdir}/vmware-tools/*.conf +# Don't expect users to modify example tools.conf file +%config %{_sysconfdir}/vmware-tools/tools.conf.example +# Don't expect users to modify VGAuth schema files +%config %{_sysconfdir}/vmware-tools/vgauth/schemas/* +%{_sysconfdir}/vmware-tools/*-vm-default +%{_sysconfdir}/vmware-tools/scripts +%{_sysconfdir}/vmware-tools/statechange.subr +%{_bindir}/VGAuthService +%{_bindir}/vm-support +%{_bindir}/vmhgfs-fuse +%{_bindir}/vmtoolsd +%{_bindir}/vmware-checkvm +%{_bindir}/vmware-hgfsclient +%{_bindir}/vmware-namespace-cmd +%{_bindir}/vmware-rpctool +%{_bindir}/vmware-toolbox-cmd +%{_bindir}/vmware-vgauth-cmd +%{_bindir}/vmware-xferlogs +%{_libdir}/libDeployPkg.so.* +%{_libdir}/libguestlib.so.* +%{_libdir}/libhgfs.so.* +%{_libdir}/libvgauth.so.* +%{_libdir}/libvmtools.so.* +%dir %{_libdir}/%{name}/ +%dir %{_libdir}/%{name}/plugins +%dir %{_libdir}/%{name}/plugins/common +%{_libdir}/%{name}/plugins/common/*.so +%dir %{_libdir}/%{name}/plugins/vmsvc +%{_libdir}/%{name}/plugins/vmsvc/*.so +%{_datadir}/%{name}/ +%{_udevrulesdir}/99-vmware-scsi-udev.rules +%{_unitdir}/%{toolsdaemon}.service +%{_unitdir}/%{vgauthdaemon}.service + +%files desktop +%{_sysconfdir}/xdg/autostart/*.desktop +%{_bindir}/vmware-user +%{_bindir}/vmware-user-suid-wrapper +%{_bindir}/vmware-vmblock-fuse +%{_libdir}/%{name}/plugins/vmusr/ + +%files devel +%doc docs/api/build/* +%exclude %{_includedir}/libDeployPkg/ +%{_includedir}/vmGuestLib/ +%{_libdir}/pkgconfig/*.pc +%{_libdir}/libDeployPkg.so +%{_libdir}/libguestlib.so +%{_libdir}/libhgfs.so +%{_libdir}/libvgauth.so +%{_libdir}/libvmtools.so + +%files test +%{_bindir}/vmware-vgauth-smoketest + +%changelog +* Tue Feb 18 2020 Miroslav Rezanina - 11.0.0-4.el8 +- ovt-Rectify-a-log-spew-in-vmsvc-logging-vmware-vmsvc-roo.patch [bz#1800812] +- Resolves: bz#1800812 + ([ESXi][RHEL8]Log spew "[ warning] [guestinfo] GuestInfoGetDiskDevice: Missing disk device name) + +* Thu Dec 05 2019 Miroslav Rezanina - 11.0.0-3.el8 +- ovt-Address-Coverity-issues-reported-in-bora-lib-file-fi.patch [bz#1769881] +- ovt-Fix-a-potential-NULL-pointer-dereference-in-the-vmba.patch [bz#1769881] +- ovt-Address-two-Coverity-reported-issues-in-hostinfoPosi.patch [bz#1769881] +- ovt-Fix-a-resource-leak-issue-in-deployPkg.patch [bz#1769881] +- Resolves: bz#1769881 + ([ESXi][RHEL8.2]Important issues found by covscan in "open-vm-tools-11.0.0-2.el8" package) + +* Tue Oct 15 2019 Miroslav Rezanina - 11.0.0-2.el8 +- Add missing gating tests + +* Mon Oct 14 2019 Miroslav Rezanina - 11.0.0-1.el8 +- Rebase to 11.0.0 [bz#1754658] +- Resolves: bz#1754658 + (Rebase open-vm-tools to 11.0 for 8.2.0) +- Resolves: bz#1760891 + (Need to backport some severe memory leak fixes from upstream) + +* Thu Aug 01 2019 Miroslav Rezanina - 10.3.10-3.el8 +- ovt-End-VGAuth-impersonation-in-the-case-of-error.patch [bz#1602648] +- ovt-Fix-memory-leak-in-GetFormattedCommandLine-function-.patch [bz#1602648] +- ovt-Fix-a-leak-if-VGAuth-setup-fails.-Coverity-issue.patch [bz#1602648] +- ovt-Fix-minor-leak-in-FileRotateByRenumber-Coverity-scan.patch [bz#1602648] +- ovt-Fix-memory-leak-in-SNEBuildHash-function.patch [bz#1602648] +- ovt-Fix-Coverity-reported-issues-in-i18n.c-code-VMTools-.patch [bz#1602648] +- ovt-Fix-a-memory-leak-in-the-unicode-library.patch [bz#1602648] +- ovt-Fix-a-trivial-Coverity-reported-memory-leak-in-vgaut.patch [bz#1602648] +- ovt-Fixes-for-few-leaks-and-improved-error-handling.patch [bz#1602648] +- ovt-Fix-Coverity-reported-double-memory-free-errors.patch [bz#1602648] +- ovt-Fix-a-trivial-Coverity-reported-memory-leak.patch [bz#1602648] +- ovt-Fix-RH-Covscan-Coverity-reported-memory-leaks-in-too.patch [bz#1602648] +- ovt-Fix-Using-uninitialized-value-issue-reported-by-Cove.patch [bz#1602648] +- ovt-copyPasteCompatX11.c-code-generating-unnecessary-Cov.patch [bz#1602648] +- ovt-Fix-a-Coverity-issue-reported-in-vgauth-serviceImpl-.patch [bz#1602648] +- ovt-Fix-two-coverity-issues-reported-by-a-customer.patch [bz#1602648] +- Resolves: bz#1602648 + ([ESXi][RHEL8]Please review important issues found by covscan in "open-vm-tools-10.2.5-2.el8+7" package) + +* Tue Jun 04 2019 Miroslav Rezanina - 10.3.10-2 +- Rebase to 10.3.10 [bz#1702784] +- Resolves: bz#1702784 + (Rebase open-vm-tools to 10.3.10) + +* Tue Jan 08 2019 Miroslav Rezanina - 10.3.0-2.el8 +- ovt-Enable-cloud-init-by-default-to-change-the-systemd-u.patch [bz#1660713] +- Resolves: bz#1660713 + ([ESXi][RHEL8.0]Enable cloud-init by default to change the systemd unit file vmtoolsd.service) + +* Tue Oct 16 2018 Miroslav Rezanina - 10.3.0-1 +- Rebase to 10.3.0 [bz#1626578] +- Resolves: bz#1626578 + ([ESXi][RHEL8]Rebase open-vm-tools to 10.3.0) + +* Mon May 14 2018 Miroslav Rezanina - 10.2.5-2 +- Updated RHEL version +- Resolves: bz#1527233 + ([ESXi][RHEL7.5]Rebase open-vm-tools to 10.2.5) + +* Wed May 09 2018 Ravindra Kumar - 10.2.5-2 +- Use tirpc for Fedora 28 onwards. + +* Wed May 09 2018 Ravindra Kumar - 10.2.5-1 +- Package new upstream version open-vm-tools-10.2.5-8068406 (RHBZ#1431376). +- Added use-tirpc.patch to use libtirpc instead of deprecated Sun RPC. +- Removed wayland-crash.patch which is no longer needed. + +* Mon Apr 30 2018 Pete Walter - 10.2.0-5 +- Rebuild for ICU 61.1 + +* Thu Feb 08 2018 Fedora Release Engineering - 10.2.0-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Fri Dec 29 2017 Ravindra Kumar - 10.2.0-3 +- Patch for a Wayland related crash in the desktopEvents plugin (RHBZ#1526952). +- gdk_set_allowed_backends() is available in version 3.10 and later only. + +* Mon Dec 18 2017 Ravindra Kumar - 10.2.0-2 +- Build with gtk3 only on newer distros. + +* Fri Dec 15 2017 Ravindra Kumar - 10.2.0-1 +- Package new upstream version open-vm-tools-10.2.0-7253323. +- Remove the patches that are no longer needed. +- New version builds with gtk3 by default. +- Package vmware-user symlink in desktop. +- Add a new test package for test utilities. +- Pick a fix to a conditional from Miroslav Vadkerti . + +* Thu Nov 30 2017 Pete Walter - 10.1.10-4 +- Rebuild for ICU 60.1 + +* Thu Sep 28 2017 Ravindra Kumar - 10.1.10-3 +- Replaced 'net-tools' dependency with 'iproute' (RHBZ#1496134). +- Added resolutionKMS-wayland-2.patch with some new fixes. + +* Fri Aug 11 2017 Kalev Lember - 10.1.10-2 +- Bump and rebuild for an rpm signing issue + +* Thu Aug 10 2017 Ravindra Kumar - 10.1.10-1 +- Package new upstream version open-vm-tools-10.1.10-6082533. +- Remove the patches that are no longer needed. + +* Thu Aug 03 2017 Fedora Release Engineering - 10.1.5-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild + +* Thu Jul 27 2017 Fedora Release Engineering - 10.1.5-6 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild + +* Tue Jul 25 2017 Richard W.M. Jones - 10.1.5-5 +- Fix /tmp race conditions in libDeployPkg (CVE-2015-5191). + +* Sun Apr 02 2017 Ravindra Kumar - 10.1.5-4 +- ResolutionKMS patch for Wayland (RHBZ#1292234). + +* Thu Mar 16 2017 Ravindra Kumar - 10.1.5-3 +- Need to add xmlsec1-openssl dependency explicitly. + +* Tue Feb 28 2017 Richard W.M. Jones - 10.1.5-2 +- Use 0644 permissions for udev rules file. + +* Fri Feb 24 2017 Ravindra Kumar - 10.1.5-1 +- Package new upstream version open-vm-tools-10.1.5-5055683 (RHBZ#1408959). + +* Fri Feb 17 2017 Ravindra Kumar - 10.1.0-1 +- Package new upstream version open-vm-tools-10.1.0-4449150 (RHBZ#1408959). +- Remove patches that are no longer needed. +- Build with --enable-xmlsec1 to avoid dependency on xerces-c and xml-security-c. +- Replace _prefix/lib/udev/rules.d/ with _udevrulesdir macro. + +* Thu Feb 16 2017 Ravindra Kumar - 10.0.5-10 +- sysmacros patch for glibc-2.25 (RHBZ#1411807). +- vgauth patch for openssl-1.1.0. + +* Thu Feb 16 2017 Ravindra Kumar - 10.0.5-9 +- udev rules patch for longer SCSI timeouts (RHBZ#1214347). + +* Sat Feb 11 2017 Fedora Release Engineering - 10.0.5-8 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild + +* Wed Oct 26 2016 Richard W.M. Jones - 10.0.5-5 +- vm-support script needs lspci from pciutils (RHBZ#1388766). + +* Wed Sep 14 2016 Ravindra Kumar - 10.0.5-4 +- Patch for HGFS stale caching issues (RHBZ#1342181). + +* Mon Jun 20 2016 Ravindra Kumar - 10.0.5-3 +- Use systemd-detect-virt to detect VMware platform (RHBZ#1251656). + +* Wed May 25 2016 Ravindra Kumar - 10.0.5-2 +- Obsolete open-vm-tools-deploypkg because its not needed for v10.x. + +* Wed May 25 2016 Ravindra Kumar - 10.0.5-1 +- Package new upstream version open-vm-tools-10.0.5-3227872. +- Add a patch for fixing GCC 6 build issue (RHBZ#1305108). +- Replace kill-werror.patch with no-unused-const.patch. + +* Wed May 25 2016 Richard W.M. Jones - 10.0.0-12 +- Bump and rebuild. + +* Sat Apr 23 2016 Richard W.M. Jones - 10.0.0-11 +- Kill -Werror with fire (RHBZ#1305108). + +* Fri Apr 15 2016 David Tardon - 10.0.0-10 +- rebuild for ICU 57.1 + +* Thu Feb 04 2016 Fedora Release Engineering - 10.0.0-9 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild + +* Wed Oct 28 2015 David Tardon - 10.0.0-8 +- rebuild for ICU 56.1 + +* Thu Oct 01 2015 Ravindra Kumar - 10.0.0-7 +- Added a missing output redirection + +* Thu Oct 01 2015 Ravindra Kumar - 10.0.0-6 +- Setup Shared Folders mount point when 'vmhgf-fuse -e' is success + +* Thu Oct 01 2015 Ravindra Kumar - 10.0.0-5 +- Setup and teardown Shared Folders mount point on VMs running + on VMware Workstation or VMware Fusion. + +* Wed Sep 30 2015 Ravindra Kumar - 10.0.0-4 +- vmhgfs-fuse needs 'fusermount' from 'fuse' + +* Wed Sep 30 2015 Ravindra Kumar - 10.0.0-3 +- Replace -std=c++11 with -std=gnu++11 to get "linux" definitions work + in order to fix the build issue, + https://kojipkgs.fedoraproject.org//work/tasks/4823/11274823/build.log +- Removed unused definitions for CFLAGS and CXXFLAGS + +* Wed Sep 30 2015 Ravindra Kumar - 10.0.0-2 +- Add -std=c++11 to CXXFLAGS for fixing the build issue, + https://kojipkgs.fedoraproject.org//work/tasks/3685/11273685/build.log + +* Tue Sep 29 2015 Ravindra Kumar - 10.0.0-1 +- Package new upstream version open-vm-tools-10.0.0-3000743 + +* Wed Aug 26 2015 Simone Caronni - 9.10.2-2 +- Add license macro. +- Remove initscripts requirement (#1226369). +- Delete mount.vmhgfs instead of excluding from packaging, so the debug + information is not included in the package (#1190540). +- Be more explicit with configuration files, newer mock complains of files being + listed twice. + +* Tue Jul 07 2015 Ravindra Kumar - 9.10.2-1 +- Package new upstream version open-vm-tools-9.10.2-2822639 +- Removed the patches that are no longer needed + +* Wed Jun 17 2015 Fedora Release Engineering - 9.10.0-5 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild + +* Wed May 20 2015 Ravindra Kumar - 9.10.0-4 +- Claim ownership for /etc/vmware-tools directory + +* Fri May 15 2015 Ravindra Kumar - 9.10.0-3 +- Put Fedora 23 specific fix under a conditional, so that the change + can be backported to other branches easily if required. + +* Fri May 08 2015 Ravindra Kumar - 9.10.0-2 +- F23 has split gdk-pixbuf2-devel >= 2.31.3-5 into 3 packages, gdk-pixbuf2-devel, + gdk-pixbuf2-modules-devel, and gdk-pixbuf2-xlib-devel. gtk2-devel does not depend + on gdk-pixbuf2-xlib-devel. Therefore, we need to pull in gdk-pixbuf2-xlib-devel + dependency ourselves. + +* Thu Apr 30 2015 Ravindra Kumar - 9.10.0-1 +- Package new upstream version open-vm-tools-9.10.0-2476743 +- New version requires adding a new service vgauthd +- Removed old patches that are no longer needed +- Fix (asm_x86.patch) for correct GCC version check +- Fix (strerror_r.patch) for picking GNU signature of strerror_r +- Fix (toolboxcmd.patch) for compiling toolboxcmd-shrink.c with gcc 5.0.1 + +* Wed Feb 04 2015 Ravindra Kumar - 9.4.6-6 +- Added a patch for missing NetIpRouteConfigInfo (BZ#1189295) + +* Mon Jan 26 2015 David Tardon - 9.4.6-5 +- rebuild for ICU 54.1 + +* Wed Sep 24 2014 Simone Caronni - 9.4.6-4 +- Rebuild for new procps-ng version. + +* Tue Aug 26 2014 David Tardon - 9.4.6-3 +- rebuild for ICU 53.1 + +* Sun Aug 17 2014 Fedora Release Engineering - 9.4.6-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild + +* Wed Jul 16 2014 Ravindra Kumar - 9.4.6-1 +- Package new upstream version open-vm-tools-9.4.6-1770165 +- Added "autoreconf -i" and its build dependencies (autoconf, automake and libtool) + to generate configure script, this is required for version 9.4.6 as it does not + have configure script bundled in the tar +- Fix (sizeof_argument.patch) for bad sizeof argument error + +* Sat Jun 07 2014 Fedora Release Engineering - 9.4.0-10 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild + +* Wed Apr 23 2014 Ravindra Kumar - 9.4.0-9 +- Removed unnecessary package dependency on 'dbus' +- Moved 'vm-support' script to /usr/bin +- Added a call to 'tools.set.version' RPC to inform VMware + platform when open-vm-tools has been uninstalled + +* Wed Mar 26 2014 Ravindra Kumar - 9.4.0-8 +- Add missing package dependency on 'which' (BZ#1045709) + +* Tue Mar 25 2014 Ravindra Kumar - 9.4.0-7 +- Add -D_DEFAULT_SOURCE to suppress warning as suggested in + https://sourceware.org/bugzilla/show_bug.cgi?id=16632 + +* Fri Mar 21 2014 Ravindra Kumar - 9.4.0-6 +- Add missing package dependencies (BZ#1045709, BZ#1077320) + +* Tue Feb 18 2014 Igor Gnatenko - 9.4.0-5 +- Fix FTBFS g_info redefine (RHBZ #1063847) + +* Fri Feb 14 2014 David Tardon - 9.4.0-4 +- rebuild for new ICU + +* Tue Feb 11 2014 Richard W.M. Jones - 9.4.0-3 +- Only build on x86-64 for RHEL 7 (RHBZ#1054608). + +* Wed Dec 04 2013 Richard W.M. Jones - 9.4.0-2 +- Rebuild for procps SONAME bump. + +* Wed Nov 06 2013 Ravindra Kumar - 9.4.0-1 +- Package new upstream version open-vm-tools-9.4.0-1280544. +- Added CUSTOM_PROCPS_NAME=procps and -Wno-deprecated-declarations + for version 9.4.0. + +* Thu Aug 22 2013 Ravindra Kumar - 9.2.3-11 +- Added copyright and license text. +- Corrected summary for all packages. + +* Thu Aug 08 2013 Ravindra Kumar - 9.2.3-10 +- Added options for hardening build (bug 990549). +- Excluded unwanted file mount.vmhgfs from packaging (bug 990547). +- Removed deprecated key "Encoding" from "Desktop Entry" (bug 990552). + +* Sat Aug 03 2013 Fedora Release Engineering - 9.2.3-9 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild + +* Tue Jun 4 2013 Richard W.M. Jones - 9.2.3-8 +- RHEL 7 now includes libdnet, so re-enable it. + +* Fri May 24 2013 Richard W.M. Jones - 9.2.3-6 +- +BR gcc-c++. If this is missing it fails to build. +- On RHEL, disable libdnet. + +* Mon May 06 2013 Ravindra Kumar - 9.2.3-5 +- Renamed source file open-vm-tools.service -> vmtoolsd.service + to match it with the service name. + +* Wed May 01 2013 Ravindra Kumar - 9.2.3-4 +- Bumped the release to pick the new service definition with + no restart directive. + +* Mon Apr 29 2013 Ravindra Kumar - 9.2.3-3 +- open-vm-tools-9.2.3 require glib-2.14.0. + +* Mon Apr 29 2013 Ravindra Kumar - 9.2.3-2 +- Bumped the release to pick the new service definition. + +* Thu Apr 25 2013 Ravindra Kumar - 9.2.3-1 +- Package new upstream version open-vm-tools-9.2.3-1031360. +- Removed configure options CUSTOM_PROCPS_NAME (for libproc) and + -Wno-deprecated-declarations as these have been addressed in + open-vm-tools-9.2.3-1031360. + +* Wed Apr 24 2013 Ravindra Kumar - 9.2.2-12 +- Removed %%defattr and BuildRoot. +- Added ExclusiveArch. +- Replaced /usr/sbin/ldconfig with /sbin/ldconfig. + +* Mon Apr 22 2013 Ravindra Kumar - 9.2.2-11 +- Removed the conditional steps for old versions of Fedora and RHEL. + +* Thu Apr 18 2013 Ravindra Kumar - 9.2.2-10 +- Addressed formal review comments from Simone Caronni. +- Removed %%check section because 'make check' brings font file back. + +* Wed Apr 17 2013 Simone Caronni - 9.2.2-9 +- Removed rm command in %%check section. +- Remove blank character at the beginning of each changelog line. + +* Mon Apr 15 2013 Ravindra Kumar - 9.2.2-8 +- Removed FreeSans.ttf font file from packaging. +- Added 'rm' command to remove font file in %%check section because + 'make check' adds it back. +- Added doxygen dependency back. + +* Thu Apr 11 2013 Ravindra Kumar - 9.2.2-7 +- Applied patch from Simone for removal of --docdir option from configure. +- Removed unnecessary --enable-docs option from configure. +- Removed doxygen dependency. + +* Thu Apr 11 2013 Ravindra Kumar - 9.2.2-6 +- Replaced vmtoolsd with a variable. +- Changed summary for subpackages to be more specific. +- Removed drivers.txt file as we don't really need it. +- Fixed vmGuestLib ownership for devel package. +- Removed systemd-sysv from Requires for Fedora 18+ and RHEL 7+. +- Made all "if" conditions consistent. + +* Wed Apr 10 2013 Simone Caronni - 9.2.2-5 +- Added RHEL 5/6 init script. +- Renamed SysV init script / systemd service file to vmtoolsd. +- Fixed ownership of files from review. +- Moved api documentation in devel subpackage. +- Removed static libraries. + +* Tue Apr 09 2013 Ravindra Kumar - 9.2.2-4 +- Applied part of review fixes patch from Simone Caronni for systemd setup. +- Replaced tabs with spaces all over. + +* Tue Apr 09 2013 Ravindra Kumar - 9.2.2-3 +- Applied review fixes patch from Simone Caronni. +- Added missing *.a and *.so files for devel package. +- Removed unnecessary *.la plugin files from base package. + +* Mon Apr 08 2013 Ravindra Kumar - 9.2.2-2 +- Modified SPEC to follow the conventions and guidelines. +- Addressed review comments from Mohamed El Morabity. +- Added systemd script. +- Verified and built the RPMS for Fedora 18. +- Fixed rpmlint warnings. +- Split the UX components in a separate package for desktops. +- Split the help files in a separate package for help. +- Split the guestlib headers in a separate devel package. + +* Mon Jan 28 2013 Sankar Tanguturi - 9.2.2-1 +- Initial SPEC file to build open-vm-tools for Fedora 17.