Blame SOURCES/ovt-Fix-a-trivial-Coverity-reported-memory-leak.patch

604589
From 98345ad1ae6960263f1e0c76cda6a45a2313d7e1 Mon Sep 17 00:00:00 2001
604589
From: Cathy Avery <cavery@redhat.com>
604589
Date: Thu, 25 Jul 2019 12:32:34 +0200
604589
Subject: [PATCH 11/16] Fix a trivial Coverity-reported memory leak.
604589
604589
RH-Author: Cathy Avery <cavery@redhat.com>
604589
Message-id: <20190725123239.18274-12-cavery@redhat.com>
604589
Patchwork-id: 89722
604589
O-Subject: [RHEL8.1 open-vm-tools PATCH 11/16] Fix a trivial Coverity-reported memory leak.
604589
Bugzilla: 1602648
604589
RH-Acked-by: Vitaly Kuznetsov <vkuznets@redhat.com>
604589
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
604589
604589
commit a5823224051da0318facf10e0732baa9f55334fc
604589
Author: Oliver Kurth <okurth@vmware.com>
604589
Date:   Wed May 8 15:27:19 2019 -0700
604589
604589
    Fix a trivial Coverity-reported memory leak.
604589
604589
    If AuthLoadPAM doesn't find all the needed symbols from the pam
604589
    library, then dlclose the library, as is already done for
604589
    the same-named funtion in bora/lib/auth/authPosix.c.
604589
604589
Signed-off-by: Cathy Avery <cavery@redhat.com>
604589
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
604589
---
604589
 open-vm-tools/vgauth/lib/authPosix.c | 4 ++--
604589
 1 file changed, 2 insertions(+), 2 deletions(-)
604589
604589
diff --git a/vgauth/lib/authPosix.c b/vgauth/lib/authPosix.c
604589
index dfaeb92..151e595 100644
604589
--- a/vgauth/lib/authPosix.c
604589
+++ b/vgauth/lib/authPosix.c
604589
@@ -1,5 +1,5 @@
604589
 /*********************************************************
604589
- * Copyright (C) 2011-2017 VMware, Inc. All rights reserved.
604589
+ * Copyright (C) 2011-2017,2019 VMware, Inc. All rights reserved.
604589
  *
604589
  * This program is free software; you can redistribute it and/or modify it
604589
  * under the terms of the GNU Lesser General Public License as published
604589
@@ -128,7 +128,7 @@ AuthLoadPAM(void)
604589
       if (!symbol) {
604589
          Warning("PAM library does not contain required function: %s\n",
604589
                  dlerror());
604589
-
604589
+         dlclose(pam_library);
604589
          return FALSE;
604589
       }
604589
 
604589
-- 
604589
1.8.3.1
604589