commit 57315578d9e500dae5143dbda607dcadc933c545 Author: James Smart Date: Tue Jan 7 10:02:57 2020 -0700 Fix systemd service script use of CONNECT_ARGS env var In testing, some environments are not properly expanding CONNECT_ARGS. Change systemd service file use of CONNECT_ARGS to be encapsulated by apostrophes and parens. Signed-off-by: James Smart Signed-off-by: Keith Busch diff --git a/nvmf-autoconnect/systemd/nvmf-connect@.service b/nvmf-autoconnect/systemd/nvmf-connect@.service index 10fb3aa..c60f146 100644 --- a/nvmf-autoconnect/systemd/nvmf-connect@.service +++ b/nvmf-autoconnect/systemd/nvmf-connect@.service @@ -11,4 +11,4 @@ Requires=nvmf-connect.target [Service] Type=simple Environment="CONNECT_ARGS=%i" -ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e $CONNECT_ARGS`" +ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e '${CONNECT_ARGS}'`"