|
 |
bf2469 |
commit 0451499b82813b6aefa30519bdd26459a6dd7c58
|
|
|
bf2469 |
Author: Sagi Grimberg <sagi@grimberg.me>
|
|
|
bf2469 |
Date: Thu Aug 22 15:09:37 2019 -0700
|
|
|
bf2469 |
|
|
|
bf2469 |
systemd: fix echo call with absolute path
|
|
|
bf2469 |
|
|
|
bf2469 |
Without placing the absolute path when formatting the
|
|
|
bf2469 |
nvme connect-all args we can get the following error:
|
|
|
bf2469 |
--
|
|
|
bf2469 |
connect-all: unrecognized option '-e'
|
|
|
bf2469 |
Discover NVMeoF subsystems and connect to them [ --transport=<LIST>, -t <LIST> ] --- transport type
|
|
|
bf2469 |
[ --traddr=<LIST>, -a <LIST> ] --- transport address
|
|
|
bf2469 |
[ --trsvcid=<LIST>, -s <LIST> ] --- transport service id (e.g. IP
|
|
|
bf2469 |
port)
|
|
|
bf2469 |
[ --host-traddr=<LIST>, -w <LIST> ] --- host traddr (e.g. FC WWN's)
|
|
|
bf2469 |
[ --hostnqn=<LIST>, -q <LIST> ] --- user-defined hostnqn (if default
|
|
|
bf2469 |
not used)
|
|
|
bf2469 |
[ --hostid=<LIST>, -I <LIST> ] --- user-defined hostid (if default
|
|
|
bf2469 |
not used)
|
|
|
bf2469 |
[ --raw=<LIST>, -r <LIST> ] --- raw output file
|
|
|
bf2469 |
[ --device=<LIST>, -d <LIST> ] --- use existing discovery controller
|
|
|
bf2469 |
device
|
|
|
bf2469 |
[ --keep-alive-tmo=<LIST>, -k <LIST> ] --- keep alive timeout period in
|
|
|
bf2469 |
seconds
|
|
|
bf2469 |
[ --reconnect-delay=<LIST>, -c <LIST> ] --- reconnect timeout period in
|
|
|
bf2469 |
seconds
|
|
|
bf2469 |
[ --ctrl-loss-tmo=<LIST>, -l <LIST> ] --- controller loss timeout period in
|
|
|
bf2469 |
seconds
|
|
|
bf2469 |
[ --hdr_digest, -g ] --- enable transport protocol header
|
|
|
bf2469 |
digest (TCP transport)
|
|
|
bf2469 |
[ --data_digest, -G ] --- enable transport protocol data
|
|
|
bf2469 |
digest (TCP transport)
|
|
|
bf2469 |
[ --nr-io-queues=<LIST>, -i <LIST> ] --- number of io queues to use
|
|
|
bf2469 |
(default is core count)
|
|
|
bf2469 |
[ --nr-write-queues=<LIST>, -W <LIST> ] --- number of write queues to use
|
|
|
bf2469 |
(default 0)
|
|
|
bf2469 |
[ --nr-poll-queues=<LIST>, -P <LIST> ] --- number of poll queues to use
|
|
|
bf2469 |
(default 0)
|
|
|
bf2469 |
[ --queue-size=<LIST>, -Q <LIST> ] --- number of io queue elements to
|
|
|
bf2469 |
use (default 128)
|
|
|
bf2469 |
[ --persistent, -p ] --- persistent discovery connection
|
|
|
bf2469 |
[ --quiet, -Q ] --- suppress already connected errors
|
|
|
bf2469 |
Usage: nvme connect-all <device> [OPTIONS]
|
|
|
bf2469 |
Options:
|
|
|
bf2469 |
: nvmf-connect@--device\x3dnvme0\t--transport\x3dtcp\t--traddr\x3d192.168.123.1\t--trsvcid\x3d8009\t--host-traddr\x3dnone.service: Main process exited, code=exited, status=70/n/a
|
|
|
bf2469 |
: nvmf-connect@--device\x3dnvme0\t--transport\x3dtcp\t--traddr\x3d192.168.123.1\t--trsvcid\x3d8009\t--host-traddr\x3dnone.service: Failed with result 'exit-code'.
|
|
|
bf2469 |
|
|
|
bf2469 |
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
|
|
|
bf2469 |
|
|
|
bf2469 |
diff --git a/nvmf-autoconnect/systemd/nvmf-connect@.service b/nvmf-autoconnect/systemd/nvmf-connect@.service
|
|
|
bf2469 |
index 25dca0e..10fb3aa 100644
|
|
|
bf2469 |
--- a/nvmf-autoconnect/systemd/nvmf-connect@.service
|
|
|
bf2469 |
+++ b/nvmf-autoconnect/systemd/nvmf-connect@.service
|
|
|
bf2469 |
@@ -11,4 +11,4 @@ Requires=nvmf-connect.target
|
|
|
bf2469 |
[Service]
|
|
|
bf2469 |
Type=simple
|
|
|
bf2469 |
Environment="CONNECT_ARGS=%i"
|
|
|
bf2469 |
-ExecStart=/bin/sh -c "nvme connect-all --quiet `echo -e $CONNECT_ARGS`"
|
|
|
bf2469 |
+ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e $CONNECT_ARGS`"
|