Blame SOURCES/nss-3.67-fix-sdb-timeout.patch

c2a015
diff --git a/lib/softoken/sdb.c b/lib/softoken/sdb.c
c2a015
--- a/lib/softoken/sdb.c
c2a015
+++ b/lib/softoken/sdb.c
c2a015
@@ -1519,16 +1519,18 @@ sdb_Begin(SDB *sdb)
c2a015
 
c2a015
     sqlerr = sqlite3_prepare_v2(sqlDB, BEGIN_CMD, -1, &stmt, NULL);
c2a015
 
c2a015
     do {
c2a015
         sqlerr = sqlite3_step(stmt);
c2a015
         if (sqlerr == SQLITE_BUSY) {
c2a015
             PR_Sleep(SDB_BUSY_RETRY_TIME);
c2a015
         }
c2a015
+        /* don't retry BEGIN transaction*/
c2a015
+        retry = 0;
c2a015
     } while (!sdb_done(sqlerr, &retry));
c2a015
 
c2a015
     if (stmt) {
c2a015
         sqlite3_reset(stmt);
c2a015
         sqlite3_finalize(stmt);
c2a015
     }
c2a015
 
c2a015
 loser:
c2a015
diff --git a/lib/softoken/sftkdb.c b/lib/softoken/sftkdb.c
c2a015
--- a/lib/softoken/sftkdb.c
c2a015
+++ b/lib/softoken/sftkdb.c
c2a015
@@ -1521,17 +1521,17 @@ sftkdb_DestroyObject(SFTKDBHandle *handl
c2a015
     if (handle == NULL) {
c2a015
         return CKR_TOKEN_WRITE_PROTECTED;
c2a015
     }
c2a015
     db = SFTK_GET_SDB(handle);
c2a015
     objectID &= SFTK_OBJ_ID_MASK;
c2a015
 
c2a015
     crv = (*db->sdb_Begin)(db);
c2a015
     if (crv != CKR_OK) {
c2a015
-        goto loser;
c2a015
+        return crv;
c2a015
     }
c2a015
     crv = (*db->sdb_DestroyObject)(db, objectID);
c2a015
     if (crv != CKR_OK) {
c2a015
         goto loser;
c2a015
     }
c2a015
     /* if the database supports meta data, delete any old signatures
c2a015
      * that we may have added */
c2a015
     if ((db->sdb_flags & SDB_HAS_META) == SDB_HAS_META) {
c2a015
@@ -2456,17 +2456,17 @@ sftkdb_Update(SFTKDBHandle *handle, SECI
c2a015
         return CKR_OK;
c2a015
     }
c2a015
     /*
c2a015
      * put the whole update under a transaction. This allows us to handle
c2a015
      * any possible race conditions between with the updateID check.
c2a015
      */
c2a015
     crv = (*handle->db->sdb_Begin)(handle->db);
c2a015
     if (crv != CKR_OK) {
c2a015
-        goto loser;
c2a015
+        return crv;
c2a015
     }
c2a015
     inTransaction = PR_TRUE;
c2a015
 
c2a015
     /* some one else has already updated this db */
c2a015
     if (sftkdb_hasUpdate(sftkdb_TypeString(handle),
c2a015
                          handle->db, handle->updateID)) {
c2a015
         crv = CKR_OK;
c2a015
         goto done;