Blame SOURCES/nmap-safe_fd_functions.patch

2b076f
diff --git a/ncat/ncat_core.c b/ncat/ncat_core.c
2b076f
index 649e478..21eca9e 100644
2b076f
--- a/ncat/ncat_core.c
2b076f
+++ b/ncat/ncat_core.c
2b076f
@@ -458,7 +458,7 @@ int ncat_broadcast(fd_set *fds, const fd_list_t *fdlist, const char *msg, size_t
2b076f
 
2b076f
     ret = 0;
2b076f
     for (i = 0; i <= fdlist->fdmax; i++) {
2b076f
-        if (!FD_ISSET(i, fds))
2b076f
+        if (!checked_fd_isset(i, fds))
2b076f
             continue;
2b076f
 
2b076f
         fdn = get_fdinfo(fdlist, i);
2b076f
diff --git a/ncat/ncat_listen.c b/ncat/ncat_listen.c
2b076f
index 5c4bb33..bb779cf 100644
2b076f
--- a/ncat/ncat_listen.c
2b076f
+++ b/ncat/ncat_listen.c
2b076f
@@ -312,10 +312,10 @@ static int ncat_listen_stream(int proto)
2b076f
         unblock_socket(listen_socket[num_sockets]);
2b076f
 
2b076f
         /* setup select sets and max fd */
2b076f
-        FD_SET(listen_socket[num_sockets], &master_readfds);
2b076f
+        checked_fd_set(listen_socket[num_sockets], &master_readfds);
2b076f
         add_fd(&client_fdlist, listen_socket[num_sockets]);
2b076f
 
2b076f
-        FD_SET(listen_socket[num_sockets], &listen_fds);
2b076f
+        checked_fd_set(listen_socket[num_sockets], &listen_fds);
2b076f
 
2b076f
         num_sockets++;
2b076f
     }
2b076f
@@ -368,7 +368,7 @@ static int ncat_listen_stream(int proto)
2b076f
          */
2b076f
         for (i = 0; i <= client_fdlist.fdmax && fds_ready > 0; i++) {
2b076f
             /* Loop through descriptors until there's something to read */
2b076f
-            if (!FD_ISSET(i, &readfds) && !FD_ISSET(i, &writefds))
2b076f
+            if (!checked_fd_isset(i, &readfds) && !checked_fd_isset(i, &writefds))
2b076f
                 continue;
2b076f
 
2b076f
             if (o.debug > 1)
2b076f
@@ -376,30 +376,30 @@ static int ncat_listen_stream(int proto)
2b076f
 
2b076f
 #ifdef HAVE_OPENSSL
2b076f
             /* Is this an ssl socket pending a handshake? If so handle it. */
2b076f
-            if (o.ssl && FD_ISSET(i, &sslpending_fds)) {
2b076f
+            if (o.ssl && checked_fd_isset(i, &sslpending_fds)) {
2b076f
                 struct fdinfo *fdi = NULL;
2b076f
-                FD_CLR(i, &master_readfds);
2b076f
-                FD_CLR(i, &master_writefds);
2b076f
+                checked_fd_clr(i, &master_readfds);
2b076f
+                checked_fd_clr(i, &master_writefds);
2b076f
                 fdi = get_fdinfo(&client_fdlist, i);
2b076f
                 ncat_assert(fdi != NULL);
2b076f
                 switch (ssl_handshake(fdi)) {
2b076f
                 case NCAT_SSL_HANDSHAKE_COMPLETED:
2b076f
                     /* Clear from sslpending_fds once ssl is established */
2b076f
-                    FD_CLR(i, &sslpending_fds);
2b076f
+                    checked_fd_clr(i, &sslpending_fds);
2b076f
                     post_handle_connection(*fdi);
2b076f
                     break;
2b076f
                 case NCAT_SSL_HANDSHAKE_PENDING_WRITE:
2b076f
-                    FD_SET(i, &master_writefds);
2b076f
+                    checked_fd_set(i, &master_writefds);
2b076f
                     break;
2b076f
                 case NCAT_SSL_HANDSHAKE_PENDING_READ:
2b076f
-                    FD_SET(i, &master_readfds);
2b076f
+                    checked_fd_set(i, &master_readfds);
2b076f
                     break;
2b076f
                 case NCAT_SSL_HANDSHAKE_FAILED:
2b076f
                 default:
2b076f
                     SSL_free(fdi->ssl);
2b076f
                     Close(fdi->fd);
2b076f
-                    FD_CLR(i, &sslpending_fds);
2b076f
-                    FD_CLR(i, &master_readfds);
2b076f
+                    checked_fd_clr(i, &sslpending_fds);
2b076f
+                    checked_fd_clr(i, &master_readfds);
2b076f
                     rm_fd(&client_fdlist, i);
2b076f
                     /* Are we in single listening mode(without -k)? If so
2b076f
                        then we should quit also. */
2b076f
@@ -410,7 +410,7 @@ static int ncat_listen_stream(int proto)
2b076f
                 }
2b076f
             } else
2b076f
 #endif
2b076f
-            if (FD_ISSET(i, &listen_fds)) {
2b076f
+            if (checked_fd_isset(i, &listen_fds)) {
2b076f
                 /* we have a new connection request */
2b076f
                 handle_connection(i);
2b076f
             } else if (i == STDIN_FILENO) {
2b076f
@@ -490,7 +490,7 @@ static void handle_connection(int socket_accept)
2b076f
         int i;
2b076f
         for (i = 0; i < num_listenaddrs; i++) {
2b076f
             Close(listen_socket[i]);
2b076f
-            FD_CLR(listen_socket[i], &master_readfds);
2b076f
+            checked_fd_clr(listen_socket[i], &master_readfds);
2b076f
             rm_fd(&client_fdlist, listen_socket[i]);
2b076f
         }
2b076f
     }
2b076f
@@ -528,9 +528,9 @@ static void handle_connection(int socket_accept)
2b076f
 #ifdef HAVE_OPENSSL
2b076f
     if (o.ssl) {
2b076f
         /* Add the socket to the necessary descriptor lists. */
2b076f
-        FD_SET(s.fd, &sslpending_fds);
2b076f
-        FD_SET(s.fd, &master_readfds);
2b076f
-        FD_SET(s.fd, &master_writefds);
2b076f
+        checked_fd_set(s.fd, &sslpending_fds);
2b076f
+        checked_fd_set(s.fd, &master_readfds);
2b076f
+        checked_fd_set(s.fd, &master_writefds);
2b076f
         /* Add it to our list of fds too for maintaining maxfd. */
2b076f
         if (add_fdinfo(&client_fdlist, &s) < 0)
2b076f
             bye("add_fdinfo() failed.");
2b076f
@@ -563,10 +563,10 @@ static void post_handle_connection(struct fdinfo sinfo)
2b076f
     } else {
2b076f
         /* Now that a client is connected, pay attention to stdin. */
2b076f
         if (!stdin_eof)
2b076f
-            FD_SET(STDIN_FILENO, &master_readfds);
2b076f
+            checked_fd_set(STDIN_FILENO, &master_readfds);
2b076f
         if (!o.sendonly) {
2b076f
             /* add to our lists */
2b076f
-            FD_SET(sinfo.fd, &master_readfds);
2b076f
+            checked_fd_set(sinfo.fd, &master_readfds);
2b076f
             /* add it to our list of fds for maintaining maxfd */
2b076f
 #ifdef HAVE_OPENSSL
2b076f
             /* Don't add it twice (see handle_connection above) */
2b076f
@@ -578,7 +578,7 @@ static void post_handle_connection(struct fdinfo sinfo)
2b076f
             }
2b076f
 #endif
2b076f
         }
2b076f
-        FD_SET(sinfo.fd, &master_broadcastfds);
2b076f
+        checked_fd_set(sinfo.fd, &master_broadcastfds);
2b076f
         if (add_fdinfo(&broadcast_fdlist, &sinfo) < 0)
2b076f
             bye("add_fdinfo() failed.");
2b076f
 
2b076f
@@ -603,7 +603,7 @@ int read_stdin(void)
2b076f
             logdebug("EOF on stdin\n");
2b076f
 
2b076f
         /* Don't close the file because that allows a socket to be fd 0. */
2b076f
-        FD_CLR(STDIN_FILENO, &master_readfds);
2b076f
+        checked_fd_clr(STDIN_FILENO, &master_readfds);
2b076f
         /* Buf mark that we've seen EOF so it doesn't get re-added to the
2b076f
            select list. */
2b076f
         stdin_eof = 1;
2b076f
@@ -656,14 +656,14 @@ int read_socket(int recv_fd)
2b076f
             }
2b076f
 #endif
2b076f
             close(recv_fd);
2b076f
-            FD_CLR(recv_fd, &master_readfds);
2b076f
+            checked_fd_clr(recv_fd, &master_readfds);
2b076f
             rm_fd(&client_fdlist, recv_fd);
2b076f
-            FD_CLR(recv_fd, &master_broadcastfds);
2b076f
+            checked_fd_clr(recv_fd, &master_broadcastfds);
2b076f
             rm_fd(&broadcast_fdlist, recv_fd);
2b076f
 
2b076f
             conn_inc--;
2b076f
             if (get_conn_count() == 0)
2b076f
-                FD_CLR(STDIN_FILENO, &master_readfds);
2b076f
+                checked_fd_clr(STDIN_FILENO, &master_readfds);
2b076f
 
2b076f
             return n;
2b076f
         }
2b076f
@@ -753,7 +753,7 @@ static int ncat_listen_dgram(int proto)
2b076f
                 logdebug("do_listen(\"%s\"): %s\n", inet_ntop_ez(&listenaddrs[i].storage, sizeof(listenaddrs[i].storage)), socket_strerror(socket_errno()));
2b076f
             continue;
2b076f
         }
2b076f
-        FD_SET(sockfd[num_sockets].fd, &listen_fds);
2b076f
+        checked_fd_set(sockfd[num_sockets].fd, &listen_fds);
2b076f
         add_fd(&listen_fdlist, sockfd[num_sockets].fd);
2b076f
         sockfd[num_sockets].addr = listenaddrs[i];
2b076f
         num_sockets++;
2b076f
@@ -773,14 +773,14 @@ static int ncat_listen_dgram(int proto)
2b076f
 
2b076f
         if (fdn != -1) {
2b076f
             /*remove socket descriptor which is burnt */
2b076f
-            FD_CLR(sockfd[fdn].fd, &listen_fds);
2b076f
+            checked_fd_clr(sockfd[fdn].fd, &listen_fds);
2b076f
             rm_fd(&listen_fdlist, sockfd[fdn].fd);
2b076f
 
2b076f
             /* Rebuild the udp socket which got burnt */
2b076f
             sockfd[fdn].fd = do_listen(SOCK_DGRAM, proto, &sockfd[fdn].addr);
2b076f
             if (sockfd[fdn].fd == -1)
2b076f
                 bye("do_listen: %s", socket_strerror(socket_errno()));
2b076f
-            FD_SET(sockfd[fdn].fd, &listen_fds);
2b076f
+            checked_fd_set(sockfd[fdn].fd, &listen_fds);
2b076f
             add_fd(&listen_fdlist, sockfd[fdn].fd);
2b076f
 
2b076f
         }
2b076f
@@ -818,7 +818,7 @@ static int ncat_listen_dgram(int proto)
2b076f
              */
2b076f
             for (i = 0; i <= listen_fdlist.fdmax && fds_ready > 0; i++) {
2b076f
                 /* Loop through descriptors until there is something ready */
2b076f
-                if (!FD_ISSET(i, &fds))
2b076f
+                if (!checked_fd_isset(i, &fds))
2b076f
                     continue;
2b076f
 
2b076f
                 /* Check each listening socket */
2b076f
@@ -905,8 +905,8 @@ static int ncat_listen_dgram(int proto)
2b076f
             continue;
2b076f
         }
2b076f
 
2b076f
-        FD_SET(socket_n, &read_fds);
2b076f
-        FD_SET(STDIN_FILENO, &read_fds);
2b076f
+        checked_fd_set(socket_n, &read_fds);
2b076f
+        checked_fd_set(STDIN_FILENO, &read_fds);
2b076f
         fdmax = socket_n;
2b076f
 
2b076f
         /* stdin -> socket and socket -> stdout */
2b076f
@@ -926,7 +926,7 @@ static int ncat_listen_dgram(int proto)
2b076f
             if (fds_ready == 0)
2b076f
                 bye("Idle timeout expired (%d ms).", o.idletimeout);
2b076f
 
2b076f
-            if (FD_ISSET(STDIN_FILENO, &fds)) {
2b076f
+            if (checked_fd_isset(STDIN_FILENO, &fds)) {
2b076f
                 nbytes = Read(STDIN_FILENO, buf, sizeof(buf));
2b076f
                 if (nbytes <= 0) {
2b076f
                     if (nbytes < 0 && o.verbose) {
2b076f
@@ -934,7 +934,7 @@ static int ncat_listen_dgram(int proto)
2b076f
                     } else if (nbytes == 0 && o.debug) {
2b076f
                         logdebug("EOF on stdin\n");
2b076f
                     }
2b076f
-                    FD_CLR(STDIN_FILENO, &read_fds);
2b076f
+                    checked_fd_clr(STDIN_FILENO, &read_fds);
2b076f
                     if (nbytes < 0)
2b076f
                         return 1;
2b076f
                     continue;
2b076f
@@ -958,7 +958,7 @@ static int ncat_listen_dgram(int proto)
2b076f
                     tempbuf = NULL;
2b076f
                 }
2b076f
             }
2b076f
-            if (FD_ISSET(socket_n, &fds)) {
2b076f
+            if (checked_fd_isset(socket_n, &fds)) {
2b076f
                 nbytes = recv(socket_n, buf, sizeof(buf), 0);
2b076f
                 if (nbytes < 0) {
2b076f
                     loguser("%s.\n", socket_strerror(socket_errno()));
2b076f
@@ -1034,7 +1034,7 @@ static void read_and_broadcast(int recv_fd)
2b076f
 
2b076f
                 /* Don't close the file because that allows a socket to be
2b076f
                    fd 0. */
2b076f
-                FD_CLR(recv_fd, &master_readfds);
2b076f
+                checked_fd_clr(recv_fd, &master_readfds);
2b076f
                 /* But mark that we've seen EOF so it doesn't get re-added to
2b076f
                    the select list. */
2b076f
                 stdin_eof = 1;
2b076f
@@ -1061,14 +1061,14 @@ static void read_and_broadcast(int recv_fd)
2b076f
                 }
2b076f
 #endif
2b076f
                 close(recv_fd);
2b076f
-                FD_CLR(recv_fd, &master_readfds);
2b076f
+                checked_fd_clr(recv_fd, &master_readfds);
2b076f
                 rm_fd(&client_fdlist, recv_fd);
2b076f
-                FD_CLR(recv_fd, &master_broadcastfds);
2b076f
+                checked_fd_clr(recv_fd, &master_broadcastfds);
2b076f
                 rm_fd(&broadcast_fdlist, recv_fd);
2b076f
 
2b076f
                 conn_inc--;
2b076f
                 if (conn_inc == 0)
2b076f
-                    FD_CLR(STDIN_FILENO, &master_readfds);
2b076f
+                    checked_fd_clr(STDIN_FILENO, &master_readfds);
2b076f
 
2b076f
                 if (o.chat)
2b076f
                     chat_announce_disconnect(recv_fd);
2b076f
@@ -1099,7 +1099,7 @@ static void read_and_broadcast(int recv_fd)
2b076f
 
2b076f
         /* Send to everyone except the one who sent this message. */
2b076f
         broadcastfds = master_broadcastfds;
2b076f
-        FD_CLR(recv_fd, &broadcastfds);
2b076f
+        checked_fd_clr(recv_fd, &broadcastfds);
2b076f
         ncat_broadcast(&broadcastfds, &broadcast_fdlist, outbuf, n);
2b076f
 
2b076f
         free(chatbuf);
2b076f
@@ -1114,7 +1114,7 @@ static void shutdown_sockets(int how)
2b076f
     int i;
2b076f
 
2b076f
     for (i = 0; i <= broadcast_fdlist.fdmax; i++) {
2b076f
-        if (!FD_ISSET(i, &master_broadcastfds))
2b076f
+        if (!checked_fd_isset(i, &master_broadcastfds))
2b076f
             continue;
2b076f
 
2b076f
         fdn = get_fdinfo(&broadcast_fdlist, i);
2b076f
@@ -1139,7 +1139,7 @@ static int chat_announce_connect(int fd, const union sockaddr_u *su)
2b076f
         union sockaddr_u su;
2b076f
         socklen_t len = sizeof(su.storage);
2b076f
 
2b076f
-        if (i == fd || !FD_ISSET(i, &master_broadcastfds))
2b076f
+        if (i == fd || !checked_fd_isset(i, &master_broadcastfds))
2b076f
             continue;
2b076f
 
2b076f
         if (getpeername(i, &su.sockaddr, &len) == -1)
2b076f
diff --git a/ncat/ncat_posix.c b/ncat/ncat_posix.c
2b076f
index 3b01936..59e801e 100644
2b076f
--- a/ncat/ncat_posix.c
2b076f
+++ b/ncat/ncat_posix.c
2b076f
@@ -273,8 +273,8 @@ void netexec(struct fdinfo *info, char *cmdexec)
2b076f
         int r, n_r;
2b076f
 
2b076f
         FD_ZERO(&fds);
2b076f
-        FD_SET(info->fd, &fds);
2b076f
-        FD_SET(child_stdout[0], &fds);
2b076f
+        checked_fd_set(info->fd, &fds);
2b076f
+        checked_fd_set(child_stdout[0], &fds);
2b076f
 
2b076f
         r = fselect(maxfd + 1, &fds, NULL, NULL, NULL);
2b076f
         if (r == -1) {
2b076f
@@ -283,7 +283,7 @@ void netexec(struct fdinfo *info, char *cmdexec)
2b076f
             else
2b076f
                 break;
2b076f
         }
2b076f
-        if (FD_ISSET(info->fd, &fds)) {
2b076f
+        if (checked_fd_isset(info->fd, &fds)) {
2b076f
             int pending;
2b076f
 
2b076f
             do {
2b076f
@@ -293,7 +293,7 @@ void netexec(struct fdinfo *info, char *cmdexec)
2b076f
                 write_loop(child_stdin[1], buf, n_r);
2b076f
             } while (pending);
2b076f
         }
2b076f
-        if (FD_ISSET(child_stdout[0], &fds)) {
2b076f
+        if (checked_fd_isset(child_stdout[0], &fds)) {
2b076f
             char *crlf = NULL, *wbuf;
2b076f
             n_r = read(child_stdout[0], buf, sizeof(buf));
2b076f
             if (n_r <= 0)
2b076f
diff --git a/ncat/ncat_proxy.c b/ncat/ncat_proxy.c
2b076f
index d7227fc..e060e3e 100644
2b076f
--- a/ncat/ncat_proxy.c
2b076f
+++ b/ncat/ncat_proxy.c
2b076f
@@ -234,7 +234,7 @@ int ncat_http_server(void)
2b076f
         unblock_socket(listen_socket[num_sockets]);
2b076f
 
2b076f
         /* setup select sets and max fd */
2b076f
-        FD_SET(listen_socket[num_sockets], &listen_fds);
2b076f
+        checked_fd_set(listen_socket[num_sockets], &listen_fds);
2b076f
         add_fd(&listen_fdlist, listen_socket[num_sockets]);
2b076f
 
2b076f
         num_sockets++;
2b076f
@@ -267,7 +267,7 @@ int ncat_http_server(void)
2b076f
 
2b076f
         for (i = 0; i <= listen_fdlist.fdmax && fds_ready > 0; i++) {
2b076f
             /* Loop through descriptors until there is something ready */
2b076f
-            if (!FD_ISSET(i, &read_fds))
2b076f
+            if (!checked_fd_isset(i, &read_fds))
2b076f
                 continue;
2b076f
 
2b076f
             /* Check each listening socket */
2b076f
@@ -525,8 +525,8 @@ static int handle_connect(struct socket_buffer *client_sock,
2b076f
 
2b076f
     maxfd = client_sock->fdn.fd < s ? s : client_sock->fdn.fd;
2b076f
     FD_ZERO(&m);
2b076f
-    FD_SET(client_sock->fdn.fd, &m);
2b076f
-    FD_SET(s, &m);
2b076f
+    checked_fd_set(client_sock->fdn.fd, &m);
2b076f
+    checked_fd_set(s, &m);
2b076f
 
2b076f
     errno = 0;
2b076f
 
2b076f
@@ -540,7 +540,7 @@ static int handle_connect(struct socket_buffer *client_sock,
2b076f
 
2b076f
         zmem(buf, sizeof(buf));
2b076f
 
2b076f
-        if (FD_ISSET(client_sock->fdn.fd, &r)) {
2b076f
+        if (checked_fd_isset(client_sock->fdn.fd, &r)) {
2b076f
             do {
2b076f
                 do {
2b076f
                     len = fdinfo_recv(&client_sock->fdn, buf, sizeof(buf));
2b076f
@@ -556,7 +556,7 @@ static int handle_connect(struct socket_buffer *client_sock,
2b076f
             } while (fdinfo_pending(&client_sock->fdn));
2b076f
         }
2b076f
 
2b076f
-        if (FD_ISSET(s, &r)) {
2b076f
+        if (checked_fd_isset(s, &r)) {
2b076f
             do {
2b076f
                 len = recv(s, buf, sizeof(buf), 0);
2b076f
             } while (len == -1 && socket_errno() == EINTR);