|
 |
ad45ff |
From d0d83585f7f6a74ac02338a37c6860cd2f26b33b Mon Sep 17 00:00:00 2001
|
|
|
ad45ff |
From: Phil Sutter <psutter@redhat.com>
|
|
|
ad45ff |
Date: Thu, 14 Dec 2017 14:18:17 +0100
|
|
|
ad45ff |
Subject: [PATCH] netlink_linearize: exthdr op must be u32
|
|
|
ad45ff |
|
|
|
ad45ff |
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1524246
|
|
|
ad45ff |
Upstream Status: nftables commit 80f5d7fd66895
|
|
|
ad45ff |
|
|
|
ad45ff |
commit 80f5d7fd66895c651c9d1e35b2353f3020ffb538
|
|
|
ad45ff |
Author: Florian Westphal <fw@strlen.de>
|
|
|
ad45ff |
Date: Mon Dec 11 10:06:55 2017 +0100
|
|
|
ad45ff |
|
|
|
ad45ff |
netlink_linearize: exthdr op must be u32
|
|
|
ad45ff |
|
|
|
ad45ff |
libnftnl casts this to u32. Broke exthdr expressions on bigendian.
|
|
|
ad45ff |
|
|
|
ad45ff |
Reported-by: Li Shuang <shuali@redhat.com>
|
|
|
ad45ff |
Signed-off-by: Florian Westphal <fw@strlen.de>
|
|
|
ad45ff |
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
|
ad45ff |
---
|
|
|
ad45ff |
src/netlink_linearize.c | 4 ++--
|
|
|
ad45ff |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
ad45ff |
|
|
|
ad45ff |
diff --git a/src/netlink_linearize.c b/src/netlink_linearize.c
|
|
|
ad45ff |
index fb2d250..a268dcc 100644
|
|
|
ad45ff |
--- a/src/netlink_linearize.c
|
|
|
ad45ff |
+++ b/src/netlink_linearize.c
|
|
|
ad45ff |
@@ -178,7 +178,7 @@ static void netlink_gen_exthdr(struct netlink_linearize_ctx *ctx,
|
|
|
ad45ff |
nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_OFFSET, offset / BITS_PER_BYTE);
|
|
|
ad45ff |
nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_LEN,
|
|
|
ad45ff |
div_round_up(expr->len, BITS_PER_BYTE));
|
|
|
ad45ff |
- nftnl_expr_set_u8(nle, NFTNL_EXPR_EXTHDR_OP, expr->exthdr.op);
|
|
|
ad45ff |
+ nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_OP, expr->exthdr.op);
|
|
|
ad45ff |
nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_FLAGS, expr->exthdr.flags);
|
|
|
ad45ff |
nftnl_rule_add_expr(ctx->nlr, nle);
|
|
|
ad45ff |
}
|
|
|
ad45ff |
@@ -839,7 +839,7 @@ static void netlink_gen_exthdr_stmt(struct netlink_linearize_ctx *ctx,
|
|
|
ad45ff |
nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_OFFSET, offset / BITS_PER_BYTE);
|
|
|
ad45ff |
nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_LEN,
|
|
|
ad45ff |
div_round_up(expr->len, BITS_PER_BYTE));
|
|
|
ad45ff |
- nftnl_expr_set_u8(nle, NFTNL_EXPR_EXTHDR_OP, expr->exthdr.op);
|
|
|
ad45ff |
+ nftnl_expr_set_u32(nle, NFTNL_EXPR_EXTHDR_OP, expr->exthdr.op);
|
|
|
ad45ff |
nftnl_rule_add_expr(ctx->nlr, nle);
|
|
|
ad45ff |
}
|
|
|
ad45ff |
|
|
|
ad45ff |
--
|
|
|
ad45ff |
1.8.3.1
|
|
|
ad45ff |
|