Blame SOURCES/nfs-utils-1.3.0-gssd-noclear-retval.patch

64c563
commit a705076172b274463563416adffe55f129740267
64c563
Author: Steve Dickson <steved@redhat.com>
64c563
Date:   Thu Jul 30 17:06:39 2015 -0400
64c563
64c563
    rpc.gssd: Only clear the retval if it has not been set
64c563
    
64c563
    In gssd_search_krb5_keytab() an error code can be
64c563
    cleared by blindly setting retval to zero.
64c563
    
64c563
    Reported-by: Jianhong Yin <jiyin@redhat.com>
64c563
    Signed-off-by: Steve Dickson <steved@redhat.com>
64c563
64c563
diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
64c563
index f1ebc0d..ecf17a2 100644
64c563
--- a/utils/gssd/krb5_util.c
64c563
+++ b/utils/gssd/krb5_util.c
64c563
@@ -772,7 +772,9 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt,
64c563
 			    "keytab '%s'\n", k5err, kt_name);
64c563
 	}
64c563
 
64c563
-	retval = 0;
64c563
+	/* Only clear the retval if has not been set */
64c563
+	if (retval < 0)
64c563
+		retval = 0;
64c563
   out:
64c563
 	free(k5err);
64c563
 	return retval;