e19a30
commit c6b8191374d9ad064eb96423400a6314c2d0102e
e19a30
Author: Kinglong Mee <kinglongmee@gmail.com>
e19a30
Date:   Tue Jun 30 14:12:38 2015 -0400
e19a30
e19a30
    blkmapd: Fix infinite loop when reading serial
e19a30
    
e19a30
    If (dev_id->ids & 0xf) < current_id, must updates pos when continue.
e19a30
    Otherwise an infinite loop.
e19a30
    
e19a30
    No other places use the pos value, just move to the top of while.
e19a30
    
e19a30
    Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
e19a30
    Signed-off-by: Steve Dickson <steved@redhat.com>
e19a30
e19a30
diff --git a/utils/blkmapd/device-inq.c b/utils/blkmapd/device-inq.c
e19a30
index c5bf71f..6b56b67 100644
e19a30
--- a/utils/blkmapd/device-inq.c
e19a30
+++ b/utils/blkmapd/device-inq.c
e19a30
@@ -196,6 +196,8 @@ struct bl_serial *bldev_read_serial(int fd, const char *filename)
e19a30
 
e19a30
 	while (pos < (len - devid_len)) {
e19a30
 		dev_id = (struct bl_dev_id *)&(dev_root->data[pos]);
e19a30
+		pos += (dev_id->len + devid_len);
e19a30
+
e19a30
 		if ((dev_id->ids & 0xf) < current_id)
e19a30
 			continue;
e19a30
 		switch (dev_id->ids & 0xf) {
e19a30
@@ -226,7 +228,6 @@ struct bl_serial *bldev_read_serial(int fd, const char *filename)
e19a30
 		}
e19a30
 		if (current_id == 3)
e19a30
 			break;
e19a30
-		pos += (dev_id->len + devid_len);
e19a30
 	}
e19a30
  out:
e19a30
 	if (!serial_out)