959ccc
From bf842d0cf9ae13408e20963c977d3c85642a69b3 Mon Sep 17 00:00:00 2001
959ccc
From: "Kaleb S. KEITHLEY" <kkeithle@redhat.com>
959ccc
Date: Thu, 18 Jun 2020 09:38:13 -0400
959ccc
Subject: [PATCH] systemd: revised drop-in conf file handling
959ccc
959ccc
see https://bugzilla.redhat.com/show_bug.cgi?id=1848208
959ccc
959ccc
systemd service file documentation still sucks rocks
959ccc
959ccc
This is my current best guess, and at least it doesn't log errors
959ccc
959ccc
Change-Id: Iec9847356090e561bfcd5f41a64b35c2e686a3d6
959ccc
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
959ccc
---
959ccc
 src/nfs-ganesha.spec-in.cmake                         | 6 +++---
959ccc
 src/scripts/systemd/nfs-ganesha-lock.service.debian10 | 2 +-
959ccc
 src/scripts/systemd/nfs-ganesha-lock.service.el8      | 2 +-
959ccc
 src/scripts/systemd/rpc-statd.conf.debian10           | 2 +-
959ccc
 src/scripts/systemd/rpc-statd.conf.el8                | 2 +-
959ccc
 5 files changed, 7 insertions(+), 7 deletions(-)
959ccc
959ccc
diff --git a/src/nfs-ganesha.spec-in.cmake b/src/nfs-ganesha.spec-in.cmake
959ccc
index 9cfda6c0e..d66106d6f 100644
959ccc
--- a/src/nfs-ganesha.spec-in.cmake
959ccc
+++ b/src/nfs-ganesha.spec-in.cmake
959ccc
@@ -557,13 +557,13 @@ install -m 644 config_samples/vfs.conf %{buildroot}%{_sysconfdir}/ganesha
959ccc
 
959ccc
 mkdir -p %{buildroot}%{_unitdir}
959ccc
 %if ( 0%{?fedora} ) || ( 0%{?rhel} && 0%{?rhel} >= 8 )
959ccc
-mkdir -p %{buildroot}%{_sysconfdir}/systemd/system/nfs-ganesha.d
959ccc
+mkdir -p %{buildroot}%{_sysconfdir}/systemd/system/nfs-ganesha-lock.service.d
959ccc
 %endif
959ccc
 
959ccc
 install -m 644 scripts/systemd/nfs-ganesha.service.el7	%{buildroot}%{_unitdir}/nfs-ganesha.service
959ccc
 %if ( 0%{?fedora} ) || ( 0%{?rhel} && 0%{?rhel} >= 8 )
959ccc
 install -m 644 scripts/systemd/nfs-ganesha-lock.service.el8	%{buildroot}%{_unitdir}/nfs-ganesha-lock.service
959ccc
-install -m 644 scripts/systemd/rpc-statd.conf.el8	%{buildroot}%{_sysconfdir}/systemd/system/nfs-ganesha.d/rpc-statd.conf
959ccc
+install -m 644 scripts/systemd/rpc-statd.conf.el8	%{buildroot}%{_sysconfdir}/systemd/system/nfs-ganesha-lock.service.d/rpc-statd.conf
959ccc
 %else
959ccc
 install -m 644 scripts/systemd/nfs-ganesha-lock.service.el7	%{buildroot}%{_unitdir}/nfs-ganesha-lock.service
959ccc
 %endif
959ccc
@@ -677,7 +677,7 @@ exit 0
959ccc
 %{_unitdir}/nfs-ganesha-lock.service
959ccc
 %{_unitdir}/nfs-ganesha-config.service
959ccc
 %if ( 0%{?fedora} ) || ( 0%{?rhel} && 0%{?rhel} >= 8 )
959ccc
-%{_sysconfdir}/systemd/system/nfs-ganesha.d/rpc-statd.conf
959ccc
+%{_sysconfdir}/systemd/system/nfs-ganesha-lock.service.d/rpc-statd.conf
959ccc
 %endif
959ccc
 
959ccc
 %if %{with man_page}
959ccc
diff --git a/src/scripts/systemd/nfs-ganesha-lock.service.debian10 b/src/scripts/systemd/nfs-ganesha-lock.service.debian10
959ccc
index 67af058fe..da06ef4fe 100644
959ccc
--- a/src/scripts/systemd/nfs-ganesha-lock.service.debian10
959ccc
+++ b/src/scripts/systemd/nfs-ganesha-lock.service.debian10
959ccc
@@ -17,7 +17,7 @@
959ccc
 
959ccc
 [Unit]
959ccc
 Before=nfs-ganesha.service
959ccc
-Conflicts=nfs-lock.service rpc-statd.service
959ccc
+Conflicts=nfs-lock.service
959ccc
 
959ccc
 [Service]
959ccc
 ExecStartPre=
959ccc
diff --git a/src/scripts/systemd/nfs-ganesha-lock.service.el8 b/src/scripts/systemd/nfs-ganesha-lock.service.el8
959ccc
index 67af058fe..da06ef4fe 100644
959ccc
--- a/src/scripts/systemd/nfs-ganesha-lock.service.el8
959ccc
+++ b/src/scripts/systemd/nfs-ganesha-lock.service.el8
959ccc
@@ -17,7 +17,7 @@
959ccc
 
959ccc
 [Unit]
959ccc
 Before=nfs-ganesha.service
959ccc
-Conflicts=nfs-lock.service rpc-statd.service
959ccc
+Conflicts=nfs-lock.service
959ccc
 
959ccc
 [Service]
959ccc
 ExecStartPre=
959ccc
diff --git a/src/scripts/systemd/rpc-statd.conf.debian10 b/src/scripts/systemd/rpc-statd.conf.debian10
959ccc
index 2138f7467..d06fffd4c 100644
959ccc
--- a/src/scripts/systemd/rpc-statd.conf.debian10
959ccc
+++ b/src/scripts/systemd/rpc-statd.conf.debian10
959ccc
@@ -13,7 +13,7 @@ After=nfs-config.service
959ccc
 [Service]
959ccc
 EnvironmentFile=-/run/sysconfig/nfs-utils
959ccc
 Type=forking
959ccc
-PIDFile=/var/run/rpc.statd.pid
959ccc
+PIDFile=/run/rpc.statd.pid
959ccc
 ExecStart=/sbin/rpc.statd --no-notify $STATDARGS
959ccc
 
959ccc
 [Install]
959ccc
diff --git a/src/scripts/systemd/rpc-statd.conf.el8 b/src/scripts/systemd/rpc-statd.conf.el8
959ccc
index 6fec09af1..b67cfdf24 100644
959ccc
--- a/src/scripts/systemd/rpc-statd.conf.el8
959ccc
+++ b/src/scripts/systemd/rpc-statd.conf.el8
959ccc
@@ -1,3 +1,4 @@
959ccc
+[Unit]
959ccc
 Description=NFS status monitor for NFSv2/3 locking.
959ccc
 DefaultDependencies=no
959ccc
 Conflicts=umount.target
959ccc
@@ -10,5 +11,5 @@
959ccc
 [Service]
959ccc
 Environment=RPC_STATD_NO_NOTIFY=1
959ccc
 Type=forking
959ccc
-PIDFile=/var/run/rpc.statd.pid
959ccc
+PIDFile=/run/rpc.statd.pid
959ccc
 ExecStart=/usr/sbin/rpc.statd
959ccc
-- 
959ccc
2.26.2
959ccc